[ 
https://issues.apache.org/jira/browse/LUCENE-10180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430229#comment-17430229
 ] 

Vigya Sharma edited comment on LUCENE-10180 at 10/18/21, 9:28 PM:
------------------------------------------------------------------

I would like to work on this issue and get more involved with merge related 
functionality. Might need some help as I'm new here.

Is the idea here to use a function pointer (similar to the one used for 
mergeTermVectors) for each of the merge tasks?


was (Author: vigyas):
I would like to work on this issue and get more involved with merge related 
functionality. Might need some help as I'm new here.

[~jpountz] - Are you suggesting we replace these lambda invocations with 
separately named VoidMerger objects for each merge task like mergeTerms, 
mergeDocValues, ... ?

> Remove usage of lambdas in SegmentMerger?
> -----------------------------------------
>
>                 Key: LUCENE-10180
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10180
>             Project: Lucene - Core
>          Issue Type: Wish
>            Reporter: Adrien Grand
>            Priority: Minor
>         Attachments: profile.png
>
>
> SegmentMerger now uses lambdas to share the logic around logging merging 
> times for all file formats.
> One problem is that these lambdas get auto-generated names, and it makes it 
> harder to work with profilers since things that should logically end up in 
> the same sub tree end up in different sub trees because two instances of the 
> same lambda get different names.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to