jpountz commented on pull request #389: URL: https://github.com/apache/lucene/pull/389#issuecomment-945593285
> Why do we have all this delegation? It was a way to have sorted set doc values automatically benefit from the specialization of sorted numeric doc values without duplicating all the specialized cases. > If we truly must delegate, why not delegate docValueCount too? Sorted set doc values don't have a `docValueCount` API, they're just expected to return `NO_MORE_ORDS` when all ords have been exhausted. > I don't understand why we eagerly invoke it in next/advance and cache it. +1 to change this. This would fix the bug, and probably also help a bit when the iterator is used to iterate over docs that have a value while never reading the values, such as with `DocValueFieldExistsQuery`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
