gsmiller commented on pull request #2521:
URL: https://github.com/apache/lucene-solr/pull/2521#issuecomment-882695741
@gautamworah96 I don't think we want to make this non-backwards compatible
change (LUCENE-9948) in 8.10. I think we need to wait for 9.0 for that. This is
just what I've ga
dnhatn commented on a change in pull request #214:
URL: https://github.com/apache/lucene/pull/214#discussion_r672315261
##
File path: lucene/core/src/java/org/apache/lucene/index/DirectoryReader.java
##
@@ -122,6 +122,23 @@ public static DirectoryReader open(final IndexCommit
[
https://issues.apache.org/jira/browse/LUCENE-9959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384068#comment-17384068
]
Adrien Grand commented on LUCENE-9959:
--
I actually like the changes made in #180. I
Grigoriy Troitskiy created LUCENE-10030:
---
Summary: [DrillSidewaysScorer] redundant score() calculations in
doQueryFirstScoring
Key: LUCENE-10030
URL: https://issues.apache.org/jira/browse/LUCENE-10030
[
https://issues.apache.org/jira/browse/LUCENE-10030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grigoriy Troitskiy updated LUCENE-10030:
Description:
*Diff*
{code:java}
@@ -195,11 +195,8 @@ class DrillSidewaysScorer ex
gsmiller commented on pull request #2521:
URL: https://github.com/apache/lucene-solr/pull/2521#issuecomment-882695741
@gautamworah96 I don't think we want to make this non-backwards compatible
change (LUCENE-9948) in 8.10. I think we need to wait for 9.0 for that. This is
just what I've ga
dnhatn commented on a change in pull request #214:
URL: https://github.com/apache/lucene/pull/214#discussion_r672315261
##
File path: lucene/core/src/java/org/apache/lucene/index/DirectoryReader.java
##
@@ -122,6 +122,23 @@ public static DirectoryReader open(final IndexCommit
gtroitskiy opened a new pull request #217:
URL: https://github.com/apache/lucene/pull/217
https://issues.apache.org/jira/browse/LUCENE-10030
disabling scoring for near-miss hits, since it's quite heavy and it isn't
being used anywhere
please check the Jira issue for more details
--
jpountz commented on pull request #205:
URL: https://github.com/apache/lucene/pull/205#issuecomment-883355855
I prefer the current API that's been merged as part of #180 than the
proposed API where Fields, TermVectors and TermVectorsReader get renamed to
TermVectors, TermVectorsReader and
jpountz commented on a change in pull request #214:
URL: https://github.com/apache/lucene/pull/214#discussion_r673086767
##
File path: lucene/core/src/java/org/apache/lucene/index/DirectoryReader.java
##
@@ -122,6 +122,23 @@ public static DirectoryReader open(final IndexCommit
jpountz commented on a change in pull request #196:
URL: https://github.com/apache/lucene/pull/196#discussion_r673114007
##
File path: lucene/core/src/java/org/apache/lucene/search/MultiCollector.java
##
@@ -83,7 +83,7 @@ public static Collector wrap(Iterable
collectors) {
[
https://issues.apache.org/jira/browse/LUCENE-10010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384259#comment-17384259
]
Michael McCandless commented on LUCENE-10010:
-
bq. While in the NFA query,
mocobeta opened a new pull request #218:
URL: https://github.com/apache/lucene/pull/218
This is the second attempt to rename the nearest-neighbor vector search
format.
Changes in o.a.l.codec package:
- rename VectorFormat to KnnVectorsVormat, VectorReader to KnnVectorsReader,
and
mikemccand commented on pull request #2521:
URL: https://github.com/apache/lucene-solr/pull/2521#issuecomment-883450480
> @gautamworah96 I don't think we want to make this non-backwards compatible
change (LUCENE-9948) in 8.10. I think we need to wait for 9.0 for that. This is
just what I'v
[
https://issues.apache.org/jira/browse/LUCENE-9450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384320#comment-17384320
]
Michael McCandless commented on LUCENE-9450:
Catching up here...
So yeah as
mocobeta commented on pull request #207:
URL: https://github.com/apache/lucene/pull/207#issuecomment-883464749
I opened #218 since I found that it's much easier than to revert previous
commits and resolve the conflicts with the latest main here. Can you have a
look at it?
"Knn" vs.
mocobeta commented on pull request #207:
URL: https://github.com/apache/lucene/pull/207#issuecomment-883474655
> A new question is whether VectorSimilarityFunction needs renaming now that
it's been extracted out from VectorValues.
I'm fine with `VectorSimilarityFunction` and haven't
[
https://issues.apache.org/jira/browse/LUCENE-10015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384330#comment-17384330
]
Adrien Grand commented on LUCENE-10015:
---
In this case, nextDoc would hopefully re
mocobeta commented on a change in pull request #218:
URL: https://github.com/apache/lucene/pull/218#discussion_r673219671
##
File path: lucene/CHANGES.txt
##
@@ -7,7 +7,7 @@ http://s.apache.org/luceneversions
New Features
-* LUCENE-9322: Vector-valued fields, Lucene90 Code
jpountz opened a new pull request #219:
URL: https://github.com/apache/lucene/pull/219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsu
dsmiley commented on pull request #205:
URL: https://github.com/apache/lucene/pull/205#issuecomment-883540136
FWIW, what I care about most in this is that Fields.java is relegated to an
internal only thing associated with the terms index, for those that build
PostingsFormats 'n such. I fi
HoustonPutman merged pull request #2533:
URL: https://github.com/apache/lucene-solr/pull/2533
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issu
[
https://issues.apache.org/jira/browse/LUCENE-9450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384409#comment-17384409
]
Adrien Grand commented on LUCENE-9450:
--
For the record, another approach could work
jtibshirani commented on a change in pull request #219:
URL: https://github.com/apache/lucene/pull/219#discussion_r673356722
##
File path:
lucene/core/src/java/org/apache/lucene/index/VectorSimilarityFunction.java
##
@@ -62,15 +64,5 @@
* @param v2 another vector, of the sa
[
https://issues.apache.org/jira/browse/LUCENE-10015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384430#comment-17384430
]
Julie Tibshirani commented on LUCENE-10015:
---
I was initially hesitant about r
[
https://issues.apache.org/jira/browse/LUCENE-9450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384433#comment-17384433
]
Michael McCandless commented on LUCENE-9450:
Ahh that is a compelling option
gsmiller commented on pull request #2521:
URL: https://github.com/apache/lucene-solr/pull/2521#issuecomment-883666505
I'm a bit skeptical of needing to backport both of these changes together to
be honest. For LUCENE-9948, I think the easiest/best thing to do is to let it
be a breaking cha
gsmiller commented on a change in pull request #217:
URL: https://github.com/apache/lucene/pull/217#discussion_r673515186
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/DrillSidewaysScorer.java
##
@@ -195,11 +195,8 @@ private void doQueryFirstScoring(Bits acceptDo
[
https://issues.apache.org/jira/browse/LUCENE-10030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384494#comment-17384494
]
Greg Miller commented on LUCENE-10030:
--
Thanks for opening this! Left one small co
[
https://issues.apache.org/jira/browse/LUCENE-10030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384497#comment-17384497
]
Greg Miller commented on LUCENE-10030:
--
To respond to your second point above, I t
[
https://issues.apache.org/jira/browse/LUCENE-9450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384501#comment-17384501
]
Gautam Worah commented on LUCENE-9450:
--
I tried the approach of indexing the new Bi
[
https://issues.apache.org/jira/browse/LUCENE-9450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384501#comment-17384501
]
Gautam Worah edited comment on LUCENE-9450 at 7/20/21, 10:04 PM:
-
gtroitskiy commented on a change in pull request #217:
URL: https://github.com/apache/lucene/pull/217#discussion_r673540568
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/DrillSidewaysScorer.java
##
@@ -195,11 +195,8 @@ private void doQueryFirstScoring(Bits accept
gtroitskiy commented on a change in pull request #217:
URL: https://github.com/apache/lucene/pull/217#discussion_r673540568
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/DrillSidewaysScorer.java
##
@@ -195,11 +195,8 @@ private void doQueryFirstScoring(Bits accept
gsmiller commented on a change in pull request #196:
URL: https://github.com/apache/lucene/pull/196#discussion_r673536496
##
File path: lucene/core/src/java/org/apache/lucene/search/MultiCollector.java
##
@@ -83,7 +83,7 @@ public static Collector wrap(Iterable
collectors) {
[
https://issues.apache.org/jira/browse/LUCENE-10030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384524#comment-17384524
]
Greg Miller commented on LUCENE-10030:
--
Actually, I think we do need to provide a
gsmiller commented on a change in pull request #217:
URL: https://github.com/apache/lucene/pull/217#discussion_r673552569
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/DrillSidewaysScorer.java
##
@@ -195,11 +195,8 @@ private void doQueryFirstScoring(Bits acceptDo
gtroitskiy commented on a change in pull request #217:
URL: https://github.com/apache/lucene/pull/217#discussion_r673575108
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/DrillSidewaysScorer.java
##
@@ -195,11 +195,8 @@ private void doQueryFirstScoring(Bits accept
[
https://issues.apache.org/jira/browse/LUCENE-9450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384501#comment-17384501
]
Gautam Worah edited comment on LUCENE-9450 at 7/21/21, 1:01 AM:
--
39 matches
Mail list logo
