gsmiller commented on a change in pull request #217:
URL: https://github.com/apache/lucene/pull/217#discussion_r673552569
##########
File path:
lucene/facet/src/java/org/apache/lucene/facet/DrillSidewaysScorer.java
##########
@@ -195,11 +195,8 @@ private void doQueryFirstScoring(Bits acceptDocs,
LeafCollector collector, DocsA
collectDocID = docID;
Review comment:
Ah right of course. It actually makes this a bit trickier then huh?
Sorry, I wasn't thinking about this deeply enough at first, but technically,
even "near miss" collectors could call into `ScoreAndDoc` and expect to get a
score. In fact, `FacetCollector`s could do this (see the `keepScores` boolean
that can be passed to the ctor). So I think we need a meaningful score
available for the "near miss" cases after all.
Let's think about this a little more and see if we can come up with a way to
avoid computing a score until a collector accesses it. Maybe we could leverage
a `Supplier` in some way? I'll think about this a bit more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
