gtroitskiy commented on a change in pull request #217:
URL: https://github.com/apache/lucene/pull/217#discussion_r673575108
##########
File path:
lucene/facet/src/java/org/apache/lucene/facet/DrillSidewaysScorer.java
##########
@@ -195,11 +195,8 @@ private void doQueryFirstScoring(Bits acceptDocs,
LeafCollector collector, DocsA
collectDocID = docID;
Review comment:
Sorry, I removed my comment, when I saw your Jira comment
:slightly_smiling_face:
Yes, it truly makes sense to support lazy scoring for near-misses: users may
override some places to enable `keepScores` and it's not good to prevent them
from getting scores on dimensional collectors.
I pushed (with --force) some changes to fix it for `doQueryFirstScoring`
Though it doesn't look like same thing can be supported for
`doDrillDownAdvanceScoring` and `doUnionScoring`, since scores array is
computed prior collecting near-misses
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
