[jira] [Created] (LUCENE-9960) Avoid unnecessary top element replacement for equal elements in PriorityQueue

2021-05-17 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-9960: --- Summary: Avoid unnecessary top element replacement for equal elements in PriorityQueue Key: LUCENE-9960 URL: https://issues.apache.org/jira/browse/LUCENE-9960 Project:

[GitHub] [lucene] dweiss commented on a change in pull request #141: LUCENE-9960: Avoid unnecessary top element replacement for equal elements in PQ

2021-05-17 Thread GitBox
dweiss commented on a change in pull request #141: URL: https://github.com/apache/lucene/pull/141#discussion_r633528657 ## File path: lucene/core/src/java/org/apache/lucene/util/PriorityQueue.java ## @@ -138,7 +141,7 @@ public T insertWithOverflow(T element) { if (size < m

[GitHub] [lucene] dweiss opened a new pull request #141: LUCENE-9960: Avoid unnecessary top element replacement for equal elements in PQ

2021-05-17 Thread GitBox
dweiss opened a new pull request #141: URL: https://github.com/apache/lucene/pull/141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] [lucene] dweiss commented on a change in pull request #141: LUCENE-9960: Avoid unnecessary top element replacement for equal elements in PQ

2021-05-17 Thread GitBox
dweiss commented on a change in pull request #141: URL: https://github.com/apache/lucene/pull/141#discussion_r633529024 ## File path: lucene/core/src/test/org/apache/lucene/util/TestPriorityQueue.java ## @@ -47,6 +49,50 @@ protected final void checkValidity() { } } +

[jira] [Created] (LUCENE-9961) Lucene 8 causing app server threads to hang due to high rate of network usage

2021-05-17 Thread Kathleen Hilston (Jira)
Kathleen Hilston created LUCENE-9961: Summary: Lucene 8 causing app server threads to hang due to high rate of network usage Key: LUCENE-9961 URL: https://issues.apache.org/jira/browse/LUCENE-9961

[jira] [Updated] (LUCENE-9961) Lucene 8 causing app server threads to hang due to high rate of network usage

2021-05-17 Thread Kathleen Hilston (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kathleen Hilston updated LUCENE-9961: - Attachment: image-2021-05-17-10-47-42-245.png > Lucene 8 causing app server threads to h

[jira] [Updated] (LUCENE-9961) Lucene 8 causing app server threads to hang due to high rate of network usage

2021-05-17 Thread Kathleen Hilston (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kathleen Hilston updated LUCENE-9961: - Attachment: image-2021-05-17-10-48-35-739.png > Lucene 8 causing app server threads to h

[jira] [Commented] (LUCENE-9961) Lucene 8 causing app server threads to hang due to high rate of network usage

2021-05-17 Thread Kathleen Hilston (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346207#comment-17346207 ] Kathleen Hilston commented on LUCENE-9961: -- I would like to highlight this issu

[GitHub] [lucene] mikemccand commented on a change in pull request #133: LUCENE-9950: New facet counting implementation for general string doc value fields

2021-05-17 Thread GitBox
mikemccand commented on a change in pull request #133: URL: https://github.com/apache/lucene/pull/133#discussion_r633612119 ## File path: lucene/facet/src/java/org/apache/lucene/facet/StringValueFacetCounts.java ## @@ -0,0 +1,379 @@ +/* + * Licensed to the Apache Software Foun

[jira] [Commented] (LUCENE-9961) Lucene 8 causing app server threads to hang due to high rate of network usage

2021-05-17 Thread Kathleen Hilston (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346233#comment-17346233 ] Kathleen Hilston commented on LUCENE-9961: -- Also, we have received the followin

[GitHub] [lucene-solr] thelabdude opened a new pull request #2496: SOLR-11904: Mark ReplicationHandler's polling thread as a Solr server thread so the PKI Interceptor is activated

2021-05-17 Thread GitBox
thelabdude opened a new pull request #2496: URL: https://github.com/apache/lucene-solr/pull/2496 backport fixes from main to branch_8x, see: https://github.com/apache/solr/commit/ae1ac22eb70d44f80e5c89241bdd0d3e4144e62a -- This is an automated message from the Apache Git Service. To resp

[GitHub] [lucene-solr] thelabdude merged pull request #2496: SOLR-11904: Mark ReplicationHandler's polling thread as a Solr server thread so the PKI Interceptor is activated

2021-05-17 Thread GitBox
thelabdude merged pull request #2496: URL: https://github.com/apache/lucene-solr/pull/2496 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [lucene] dweiss commented on a change in pull request #141: LUCENE-9960: Avoid unnecessary top element replacement for equal elements in PQ

2021-05-17 Thread GitBox
dweiss commented on a change in pull request #141: URL: https://github.com/apache/lucene/pull/141#discussion_r633528657 ## File path: lucene/core/src/java/org/apache/lucene/util/PriorityQueue.java ## @@ -138,7 +141,7 @@ public T insertWithOverflow(T element) { if (size < m

[GitHub] [lucene-solr] dnhatn merged pull request #2494: LUCENE-9935: Enable bulk merge for stored fields with index sort

2021-05-17 Thread GitBox
dnhatn merged pull request #2494: URL: https://github.com/apache/lucene-solr/pull/2494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [lucene-solr] thelabdude merged pull request #2496: SOLR-11904: Mark ReplicationHandler's polling thread as a Solr server thread so the PKI Interceptor is activated

2021-05-17 Thread GitBox
thelabdude merged pull request #2496: URL: https://github.com/apache/lucene-solr/pull/2496 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [lucene] gautamworah96 commented on a change in pull request #138: LUCENE-9956: Make getBaseQuery, getDrillDownQueries API from DrillDownQuery public

2021-05-17 Thread GitBox
gautamworah96 commented on a change in pull request #138: URL: https://github.com/apache/lucene/pull/138#discussion_r633155578 ## File path: lucene/facet/src/java/org/apache/lucene/facet/DrillDownQuery.java ## @@ -170,11 +170,22 @@ private BooleanQuery getBooleanQuery() {

[GitHub] [lucene] mikemccand commented on a change in pull request #133: LUCENE-9950: New facet counting implementation for general string doc value fields

2021-05-17 Thread GitBox
mikemccand commented on a change in pull request #133: URL: https://github.com/apache/lucene/pull/133#discussion_r633612119 ## File path: lucene/facet/src/java/org/apache/lucene/facet/StringValueFacetCounts.java ## @@ -0,0 +1,379 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [lucene] msokolov commented on a change in pull request #83: LUCENE-9798 : Fix looping bug when calculating full KNN results in KnnGraphTester

2021-05-17 Thread GitBox
msokolov commented on a change in pull request #83: URL: https://github.com/apache/lucene/pull/83#discussion_r633753781 ## File path: lucene/test-framework/src/test/org/apache/lucene/util/TestFullKnn.java ## @@ -0,0 +1,202 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [lucene] gsmiller commented on a change in pull request #138: LUCENE-9956: Make getBaseQuery, getDrillDownQueries API from DrillDownQuery public

2021-05-17 Thread GitBox
gsmiller commented on a change in pull request #138: URL: https://github.com/apache/lucene/pull/138#discussion_r633758104 ## File path: lucene/facet/src/java/org/apache/lucene/facet/DrillDownQuery.java ## @@ -170,11 +170,22 @@ private BooleanQuery getBooleanQuery() { retur

[GitHub] [lucene] gsmiller commented on a change in pull request #133: LUCENE-9950: New facet counting implementation for general string doc value fields

2021-05-17 Thread GitBox
gsmiller commented on a change in pull request #133: URL: https://github.com/apache/lucene/pull/133#discussion_r633752063 ## File path: lucene/facet/src/java/org/apache/lucene/facet/StringValueFacetCounts.java ## @@ -0,0 +1,379 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [lucene] gsmiller opened a new pull request #142: LUCENE-9944: Allow DrillSideways users to pass a CollectorManager without requiring an ExecutorService (and concurrent DrillSideways approach

2021-05-17 Thread GitBox
gsmiller opened a new pull request #142: URL: https://github.com/apache/lucene/pull/142 # Description `DrillSideways` users should be able to provide their own `CollectorManager` without also providing an `ExecutorService` (and relying on the "concurrent approach" in `DrillSideways`

[jira] [Commented] (LUCENE-9944) Implement alternative drill sideways faceting with provided CollectorManager

2021-05-17 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346402#comment-17346402 ] Greg Miller commented on LUCENE-9944: - OK, I think I figured out a somewhat-reasonab

[jira] [Created] (LUCENE-9962) DrillSideways users should be able to opt-out of "drill down" facet collecting

2021-05-17 Thread Greg Miller (Jira)
Greg Miller created LUCENE-9962: --- Summary: DrillSideways users should be able to opt-out of "drill down" facet collecting Key: LUCENE-9962 URL: https://issues.apache.org/jira/browse/LUCENE-9962 Project:

[GitHub] [lucene] magibney commented on pull request #15: LUCENE-8972: Add ICUTransformCharFilter, to support pre-tokenizer ICU text transformation

2021-05-17 Thread GitBox
magibney commented on pull request #15: URL: https://github.com/apache/lucene/pull/15#issuecomment-842630574 Quick status update: comments are formatted properly, precommit check passes (apologies again, and thanks to all who weighed in on that). >Looks to me like removing the old tr

[jira] [Commented] (LUCENE-9335) Add a bulk scorer for disjunctions that does dynamic pruning

2021-05-17 Thread Zach Chen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346597#comment-17346597 ] Zach Chen commented on LUCENE-9335: --- [~jpountz] what do you think about the results we

[GitHub] [lucene] zacharymorn commented on pull request #128: LUCENE-9662: [WIP] CheckIndex should be concurrent

2021-05-17 Thread GitBox
zacharymorn commented on pull request #128: URL: https://github.com/apache/lucene/pull/128#issuecomment-842879141 For now I've gone ahead and implemented the idea to add segment / part ids to logging messages so that they are still usable (with some log parsing) in concurrent setting. I al

[GitHub] [lucene] dweiss commented on a change in pull request #128: LUCENE-9662: [WIP] CheckIndex should be concurrent

2021-05-17 Thread GitBox
dweiss commented on a change in pull request #128: URL: https://github.com/apache/lucene/pull/128#discussion_r634091331 ## File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java ## @@ -701,104 +765,196 @@ public Status checkIndex(List onlySegments) throws IOEx

[GitHub] [lucene] dweiss merged pull request #141: LUCENE-9960: Avoid unnecessary top element replacement for equal elements in PQ

2021-05-17 Thread GitBox
dweiss merged pull request #141: URL: https://github.com/apache/lucene/pull/141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please con

[jira] [Commented] (LUCENE-9960) Avoid unnecessary top element replacement for equal elements in PriorityQueue

2021-05-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346619#comment-17346619 ] ASF subversion and git services commented on LUCENE-9960: - Commi

[jira] [Resolved] (LUCENE-9960) Avoid unnecessary top element replacement for equal elements in PriorityQueue

2021-05-17 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9960. - Fix Version/s: main (9.0) Resolution: Fixed > Avoid unnecessary top element replacement f

[jira] [Updated] (LUCENE-9960) Avoid unnecessary top element replacement for equal elements in PriorityQueue

2021-05-17 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9960: Description: Currently the priority queue implementation always replaces the top (minimum) elemen