gsmiller opened a new pull request #142: URL: https://github.com/apache/lucene/pull/142
# Description `DrillSideways` users should be able to provide their own `CollectorManager` without also providing an `ExecutorService` (and relying on the "concurrent approach" in `DrillSideways`). # Solution Added a new `DrillSideways` implementation that uses the "standard" / "non-concurrent" approach (e.g., the one you get if you simply provide your own `Collector`) but with a `CollectorManager`. This involved modifying `DrillSidewaysQuery` to be able to work against a `FacetsCollectorManager`. This is required since the `IndexSearcher` could be executing a concurrent search, in which case `DrillSidewaysScorer` must not share `FacetsCollector` instances across threads. # Tests Added new tests to exercise the `CollectorManager` approach (no existing tests covered this code path). # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/lucene/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Lucene maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [x] I have added tests for my changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
