[
https://issues.apache.org/jira/browse/SOLR-14499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17290800#comment-17290800
]
Jan Høydahl commented on SOLR-14499:
Just realized that the 301 Redirect from .htacce
[
https://issues.apache.org/jira/browse/SOLR-14762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17290807#comment-17290807
]
Jan Høydahl commented on SOLR-14762:
{quote}1. Make all changes to lucene-solr repo (
sigram commented on pull request #2421:
URL: https://github.com/apache/lucene-solr/pull/2421#issuecomment-785767676
Merged.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
sigram closed pull request #2421:
URL: https://github.com/apache/lucene-solr/pull/2421
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/SOLR-15131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrzej Bialecki resolved SOLR-15131.
-
Resolution: Won't Fix
> Use collection properties for per-collection configuration of pla
[
https://issues.apache.org/jira/browse/SOLR-15131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17290812#comment-17290812
]
Andrzej Bialecki commented on SOLR-15131:
-
On further investigation and having im
sigram closed pull request #2344:
URL: https://github.com/apache/lucene-solr/pull/2344
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
sigram commented on pull request #2344:
URL: https://github.com/apache/lucene-solr/pull/2344#issuecomment-785769978
Abandoned in favor of PR 2421.
This is an automated message from the Apache Git Service.
To respond to the me
sigram commented on pull request #2179:
URL: https://github.com/apache/lucene-solr/pull/2179#issuecomment-785770902
This approach has been abandoned in favor of PR 2199.
This is an automated message from the Apache Git Servic
sigram closed pull request #2179:
URL: https://github.com/apache/lucene-solr/pull/2179
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
sigram commented on pull request #1329:
URL: https://github.com/apache/lucene-solr/pull/1329#issuecomment-785771487
Autoscaling framework has reached EOL status - Won't Fix.
This is an automated message from the Apache Git Se
sigram closed pull request #1329:
URL: https://github.com/apache/lucene-solr/pull/1329
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
mikemccand commented on a change in pull request #2345:
URL: https://github.com/apache/lucene-solr/pull/2345#discussion_r581398351
##
File path:
lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/feeds/ReutersContentSource.java
##
@@ -102,19 +104,43 @@ public void cl
mikemccand commented on a change in pull request #2349:
URL: https://github.com/apache/lucene-solr/pull/2349#discussion_r582790416
##
File path: lucene/benchmark/conf/indexing-flush-by-RAM-multithreaded.alg
##
@@ -53,7 +53,8 @@ log.queries=true
{ "Populate"
Crea
[
https://issues.apache.org/jira/browse/SOLR-15193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17290917#comment-17290917
]
ASF subversion and git services commented on SOLR-15193:
Commit 2
[
https://issues.apache.org/jira/browse/SOLR-14762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17290933#comment-17290933
]
Dawid Weiss commented on SOLR-14762:
I'm not really suggesting anything but I think i
Joel Bernstein created SOLR-15196:
-
Summary: Allow nodes streaming expression to rank by inbound
degree of the node
Key: SOLR-15196
URL: https://issues.apache.org/jira/browse/SOLR-15196
Project: Solr
[
https://issues.apache.org/jira/browse/SOLR-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Bernstein updated SOLR-15196:
--
Summary: Allow the nodes streaming expression to rank by inbound degree
(was: Allow nodes stre
[
https://issues.apache.org/jira/browse/SOLR-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Bernstein reassigned SOLR-15196:
-
Assignee: Joel Bernstein
> Allow the nodes streaming expression to rank by inbound degre
[
https://issues.apache.org/jira/browse/SOLR-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Bernstein updated SOLR-15196:
--
Affects Version/s: 8.9
> Allow the nodes streaming expression to rank by inbound degree
> -
[
https://issues.apache.org/jira/browse/SOLR-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Bernstein updated SOLR-15196:
--
Component/s: streaming expressions
> Allow the nodes streaming expression to rank by inbound de
Joel Bernstein created SOLR-15197:
-
Summary: Support temporal graph queries with day windows.
Key: SOLR-15197
URL: https://issues.apache.org/jira/browse/SOLR-15197
Project: Solr
Issue Type: I
[
https://issues.apache.org/jira/browse/SOLR-15197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Bernstein updated SOLR-15197:
--
Description:
The initial implementation of temporal graph queries supported ten second time
wi
[
https://issues.apache.org/jira/browse/SOLR-15197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Bernstein updated SOLR-15197:
--
Description:
The initial implementation of temporal graph queries supported ten second time
wi
[
https://issues.apache.org/jira/browse/SOLR-15197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Bernstein updated SOLR-15197:
--
Summary: Support temporal graph queries with daily windows. (was: Support
temporal graph queri
[
https://issues.apache.org/jira/browse/SOLR-15197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Bernstein updated SOLR-15197:
--
Summary: Support temporal graph queries with daily windows (was: Support
temporal graph querie
[
https://issues.apache.org/jira/browse/SOLR-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Bernstein updated SOLR-15196:
--
Description: Currently the *nodes* graph expression only calculates inbound
degree if the count
[
https://issues.apache.org/jira/browse/SOLR-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Bernstein updated SOLR-15196:
--
Summary: Allow the nodes graph expression to rank by inbound degree (was:
Allow the nodes stre
[
https://issues.apache.org/jira/browse/LUCENE-9639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17290996#comment-17290996
]
Michael Sokolov commented on LUCENE-9639:
-
We are getting build failures in the
rmuir commented on pull request #2429:
URL: https://github.com/apache/lucene-solr/pull/2429#issuecomment-785989874
> In that case we can easily implement equals without allocation.
+1 for this idea: just inline the ByteBlockPool.setBytesRef and simply avoid
the allocation.
[
https://issues.apache.org/jira/browse/LUCENE-9639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17290996#comment-17290996
]
Michael Sokolov edited comment on LUCENE-9639 at 2/25/21, 3:43 PM:
---
[
https://issues.apache.org/jira/browse/SOLR-15194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291010#comment-17291010
]
Houston Putman commented on SOLR-15194:
---
I think this is a good idea.
People also
HoustonPutman commented on pull request #2430:
URL: https://github.com/apache/lucene-solr/pull/2430#issuecomment-786009511
Very weird precommit failure, given that its suggesting you do exactly what
you have already done...
[
https://issues.apache.org/jira/browse/SOLR-15194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291020#comment-17291020
]
Jan Høydahl commented on SOLR-15194:
This is OUTGOING traffic to the IDP server to re
Peter Gromov created LUCENE-9812:
Summary: Hunspell: honor empty stripping affixes when generating
suggestions
Key: LUCENE-9812
URL: https://issues.apache.org/jira/browse/LUCENE-9812
Project: Lucene -
donnerpeter opened a new pull request #2432:
URL: https://github.com/apache/lucene-solr/pull/2432
# Description
e.g. inflect German "kennen" into "kenne"
# Solution
Process empty affixes as well, remove strip before checking affix conditions
# Tests
donnerpeter commented on pull request #2427:
URL: https://github.com/apache/lucene-solr/pull/2427#issuecomment-786037337
Thanks! I'll think how to apply this. So far it seems that Hunspell's ngram
algorithm is too automata-unfriendly :(
thelabdude commented on a change in pull request #221:
URL:
https://github.com/apache/lucene-solr-operator/pull/221#discussion_r582989907
##
File path: docs/solr-cloud/solr-cloud-crd.md
##
@@ -543,3 +543,234 @@ spec:
```
The example settings above will result in your Solr po
[
https://issues.apache.org/jira/browse/SOLR-15194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291037#comment-17291037
]
Houston Putman commented on SOLR-15194:
---
A thanks for the correction [~janhoy]!
HoustonPutman commented on a change in pull request #221:
URL:
https://github.com/apache/lucene-solr-operator/pull/221#discussion_r582992249
##
File path: controllers/util/solr_util.go
##
@@ -1157,3 +1193,240 @@ func createZkConnectionEnvVars(solrCloud
*solr.SolrCloud, solrCl
HoustonPutman commented on a change in pull request #221:
URL:
https://github.com/apache/lucene-solr-operator/pull/221#discussion_r582993985
##
File path: controllers/solrcloud_controller.go
##
@@ -256,6 +259,74 @@ func (r *SolrCloudReconciler) Reconcile(req ctrl.Request)
(ct
HoustonPutman commented on a change in pull request #221:
URL:
https://github.com/apache/lucene-solr-operator/pull/221#discussion_r582994274
##
File path: api/v1beta1/solrcloud_types.go
##
@@ -1022,3 +1040,37 @@ type SolrTLSOptions struct {
// +optional
Restart
[
https://issues.apache.org/jira/browse/SOLR-14787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291043#comment-17291043
]
Joel Bernstein commented on SOLR-14787:
---
[~gus] can you describe the advantages of
[
https://issues.apache.org/jira/browse/SOLR-15161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Eric Pugh updated SOLR-15161:
---
Description:
Years ago, to make things "simpler" in some of our example configs, we did this:
[
https://issues.apache.org/jira/browse/SOLR-15161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291046#comment-17291046
]
Steve commented on SOLR-15161:
--
I'm also experience this same behavior. Please address.
> J
pawel-bugalski-dynatrace commented on pull request #2429:
URL: https://github.com/apache/lucene-solr/pull/2429#issuecomment-786053617
I've implemented some of the ideas discussed here. What do you think?
This is an automated
[
https://issues.apache.org/jira/browse/SOLR-14787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291072#comment-17291072
]
Gus Heck commented on SOLR-14787:
-
[~jbernste] This operates at a token level not a docum
dsmiley commented on pull request #2426:
URL: https://github.com/apache/lucene-solr/pull/2426#issuecomment-786091771
Maybe I'm missing something but my suggestion is (in my head) very simple.
Remove the line `if (ft instanceof TrieField || ft.isPointField())` and closing
brace for it, and
[
https://issues.apache.org/jira/browse/SOLR-14787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291093#comment-17291093
]
Joel Bernstein edited comment on SOLR-14787 at 2/25/21, 5:59 PM:
--
[
https://issues.apache.org/jira/browse/SOLR-14787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291093#comment-17291093
]
Joel Bernstein commented on SOLR-14787:
---
Ok, this gives me a lot to think about. I'
thelabdude commented on a change in pull request #221:
URL:
https://github.com/apache/lucene-solr-operator/pull/221#discussion_r583064298
##
File path: docs/solr-cloud/solr-cloud-crd.md
##
@@ -543,3 +543,234 @@ spec:
```
The example settings above will result in your Solr po
Megan Carey created SOLR-15198:
--
Summary: Slf4j logs threadName incorrectly
Key: SOLR-15198
URL: https://issues.apache.org/jira/browse/SOLR-15198
Project: Solr
Issue Type: Bug
Security Lev
[
https://issues.apache.org/jira/browse/SOLR-15198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Megan Carey updated SOLR-15198:
---
Summary: Slf4j logs threadName incorrectly in some cases (was: Slf4j logs
threadName incorrectly)
>
zacharymorn opened a new pull request #2433:
URL: https://github.com/apache/lucene-solr/pull/2433
# Description
Fix nightly test failure by implementing SimpleTextVectorReader#ramBytesUsed
# Tests
Passed nightly tests in `TestSimpleTextVectorFormat`
```
xichen@Xis-Mac
[
https://issues.apache.org/jira/browse/LUCENE-9639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291149#comment-17291149
]
Zach Chen commented on LUCENE-9639:
---
Hi Michael, I've created another PR to implement
[
https://issues.apache.org/jira/browse/SOLR-15181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291173#comment-17291173
]
Julie Tibshirani commented on SOLR-15181:
-
Thanks for fixing this, and sorry for
thomaswoeckinger commented on pull request #2426:
URL: https://github.com/apache/lucene-solr/pull/2426#issuecomment-786156607
> Maybe I'm missing something but my suggestion is (in my head) very simple.
Remove the line `if (ft instanceof TrieField || ft.isPointField())` and closing
brace f
Timothy Potter created SOLR-15199:
-
Summary: bin/solr should expose all actions provided by SolrCLI,
such as "api"
Key: SOLR-15199
URL: https://issues.apache.org/jira/browse/SOLR-15199
Project: Solr
[
https://issues.apache.org/jira/browse/SOLR-14787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291093#comment-17291093
]
Joel Bernstein edited comment on SOLR-14787 at 2/25/21, 8:11 PM:
--
HoustonPutman opened a new pull request #226:
URL: https://github.com/apache/lucene-solr-operator/pull/226
This will use the `terminationGracePeriod`, minus a few seconds, and give
that to Solr as the `SOLR_STOP_WAIT` value.
That way Solr and Kubernetes are on the same page as to how
msokolov commented on a change in pull request #2433:
URL: https://github.com/apache/lucene-solr/pull/2433#discussion_r583149084
##
File path:
lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextVectorReader.java
##
@@ -37,10 +37,7 @@
import org.apache.lucene
madrob commented on a change in pull request #226:
URL:
https://github.com/apache/lucene-solr-operator/pull/226#discussion_r583150510
##
File path: controllers/util/solr_util.go
##
@@ -266,6 +270,9 @@ func GenerateStatefulSet(solrCloud *solr.SolrCloud,
solrCloudStatus *solr.S
HoustonPutman commented on a change in pull request #226:
URL:
https://github.com/apache/lucene-solr-operator/pull/226#discussion_r583151756
##
File path: controllers/util/solr_util.go
##
@@ -266,6 +270,9 @@ func GenerateStatefulSet(solrCloud *solr.SolrCloud,
solrCloudStatus
[
https://issues.apache.org/jira/browse/SOLR-14216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291202#comment-17291202
]
David Eric Pugh commented on SOLR-14216:
Curious what change you made [~janhoy] ?
thelabdude commented on a change in pull request #221:
URL:
https://github.com/apache/lucene-solr-operator/pull/221#discussion_r583157037
##
File path: docs/solr-cloud/solr-cloud-crd.md
##
@@ -543,3 +543,234 @@ spec:
```
The example settings above will result in your Solr po
[
https://issues.apache.org/jira/browse/SOLR-15198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291205#comment-17291205
]
David Smiley commented on SOLR-15198:
-
>From the title, if the problem is indeed in S
madrob commented on a change in pull request #2430:
URL: https://github.com/apache/lucene-solr/pull/2430#discussion_r583170235
##
File path: solr/core/src/test/org/apache/solr/security/JWTIssuerConfigTest.java
##
@@ -125,6 +128,31 @@ public void parseIssuerConfigExplicit() {
[
https://issues.apache.org/jira/browse/LUCENE-9794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291218#comment-17291218
]
Greg Miller commented on LUCENE-9794:
-
Thanks [~rcmuir] for having a look, all the i
madrob commented on a change in pull request #2429:
URL: https://github.com/apache/lucene-solr/pull/2429#discussion_r583176395
##
File path: lucene/core/src/java/org/apache/lucene/util/BytesRefHash.java
##
@@ -31,18 +31,21 @@
* to the id is encapsulated inside {@link BytesRef
[
https://issues.apache.org/jira/browse/SOLR-15198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Megan Carey updated SOLR-15198:
---
Description:
I'm running Solr 8.6, and I'm seeing some logs report threadName with the
entire log me
[
https://issues.apache.org/jira/browse/SOLR-14499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-14499:
---
Attachment: code-hilite-before.png
code-hilite-after.png
> New Solr TLP site
> --
[
https://issues.apache.org/jira/browse/SOLR-14499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291232#comment-17291232
]
Jan Høydahl commented on SOLR-14499:
I have been annoyed by the bad formatting of cod
[
https://issues.apache.org/jira/browse/SOLR-14499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-14499:
---
Attachment: code-hilite-after.png
code-hilite-before.png
> New Solr TLP site
> --
dsmiley merged pull request #2408:
URL: https://github.com/apache/lucene-solr/pull/2408
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/SOLR-14499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-14499:
---
Attachment: (was: code-hilite-after.png)
> New Solr TLP site
> -
>
>
[
https://issues.apache.org/jira/browse/SOLR-14499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-14499:
---
Attachment: (was: code-hilite-before.png)
> New Solr TLP site
> -
>
>
[
https://issues.apache.org/jira/browse/SOLR-13034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291234#comment-17291234
]
ASF subversion and git services commented on SOLR-13034:
Commit 6
[
https://issues.apache.org/jira/browse/LUCENE-9639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291237#comment-17291237
]
Mayya Sharipova commented on LUCENE-9639:
-
This test currently reproducibly fail
epugh commented on a change in pull request #2430:
URL: https://github.com/apache/lucene-solr/pull/2430#discussion_r583223688
##
File path: solr/core/src/test/org/apache/solr/security/JWTIssuerConfigTest.java
##
@@ -125,6 +128,31 @@ public void parseIssuerConfigExplicit() {
[
https://issues.apache.org/jira/browse/SOLR-13034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291239#comment-17291239
]
ASF subversion and git services commented on SOLR-13034:
Commit 1
epugh commented on a change in pull request #2430:
URL: https://github.com/apache/lucene-solr/pull/2430#discussion_r583225058
##
File path: solr/core/src/test/org/apache/solr/security/JWTIssuerConfigTest.java
##
@@ -144,13 +172,29 @@ public void wellKnownConfigFromString() thro
[
https://issues.apache.org/jira/browse/SOLR-13034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-13034.
-
Fix Version/s: 8.9
Resolution: Fixed
Note: the work-around is simply to disable enableLazy
madrob commented on a change in pull request #2430:
URL: https://github.com/apache/lucene-solr/pull/2430#discussion_r583244417
##
File path: solr/core/src/test/org/apache/solr/security/JWTIssuerConfigTest.java
##
@@ -125,6 +128,31 @@ public void parseIssuerConfigExplicit() {
HoustonPutman commented on a change in pull request #226:
URL:
https://github.com/apache/lucene-solr-operator/pull/226#discussion_r583248581
##
File path: controllers/util/solr_util.go
##
@@ -266,6 +270,9 @@ func GenerateStatefulSet(solrCloud *solr.SolrCloud,
solrCloudStatus
madrob commented on a change in pull request #2430:
URL: https://github.com/apache/lucene-solr/pull/2430#discussion_r583259647
##
File path: solr/core/src/java/org/apache/solr/security/JWTIssuerConfig.java
##
@@ -349,12 +349,18 @@ public HttpsJwksFactory(long jwkCacheDuration,
madrob commented on a change in pull request #2430:
URL: https://github.com/apache/lucene-solr/pull/2430#discussion_r583262258
##
File path: solr/core/src/test/org/apache/solr/security/JWTIssuerConfigTest.java
##
@@ -125,6 +128,31 @@ public void parseIssuerConfigExplicit() {
epugh commented on a change in pull request #2430:
URL: https://github.com/apache/lucene-solr/pull/2430#discussion_r583262322
##
File path: solr/core/src/java/org/apache/solr/security/JWTIssuerConfig.java
##
@@ -349,12 +349,18 @@ public HttpsJwksFactory(long jwkCacheDuration, l
epugh commented on pull request #2430:
URL: https://github.com/apache/lucene-solr/pull/2430#issuecomment-786284092
I've added in the environment variable that @janhoy suggested. I don't know
if the warning actually is needed anymore, since presumably if you set the
environment variable yo
epugh commented on a change in pull request #2430:
URL: https://github.com/apache/lucene-solr/pull/2430#discussion_r583262966
##
File path: solr/core/src/java/org/apache/solr/security/JWTIssuerConfig.java
##
@@ -349,12 +349,18 @@ public HttpsJwksFactory(long jwkCacheDuration, l
epugh commented on a change in pull request #2430:
URL: https://github.com/apache/lucene-solr/pull/2430#discussion_r583265431
##
File path: solr/core/src/test/org/apache/solr/security/JWTIssuerConfigTest.java
##
@@ -125,6 +128,31 @@ public void parseIssuerConfigExplicit() {
madrob commented on a change in pull request #2430:
URL: https://github.com/apache/lucene-solr/pull/2430#discussion_r583268336
##
File path: solr/core/src/test/org/apache/solr/security/JWTIssuerConfigTest.java
##
@@ -125,6 +128,31 @@ public void parseIssuerConfigExplicit() {
madrob commented on a change in pull request #2430:
URL: https://github.com/apache/lucene-solr/pull/2430#discussion_r583268708
##
File path: solr/core/src/test/org/apache/solr/security/JWTIssuerConfigTest.java
##
@@ -125,6 +128,31 @@ public void parseIssuerConfigExplicit() {
janhoy commented on pull request #2430:
URL: https://github.com/apache/lucene-solr/pull/2430#issuecomment-786317911
It's difficult to review since it suddenly contains unrelated edits. Think
you should merge in latest master again...
---
janhoy commented on a change in pull request #2430:
URL: https://github.com/apache/lucene-solr/pull/2430#discussion_r583296977
##
File path: solr/core/src/java/org/apache/solr/security/JWTIssuerConfig.java
##
@@ -68,6 +68,11 @@
private WellKnownDiscoveryConfig wellKnownDisco
tflobbe commented on pull request #2411:
URL: https://github.com/apache/lucene-solr/pull/2411#issuecomment-786327686
I don't think this will work well. Gradle runs multiple tests on the same
JVM, static state will span multiple tests (so, depending on the order of
tests, this could conflic
zacharymorn commented on a change in pull request #2433:
URL: https://github.com/apache/lucene-solr/pull/2433#discussion_r583310433
##
File path:
lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextVectorReader.java
##
@@ -37,10 +37,7 @@
import org.apache.luc
zacharymorn commented on pull request #2433:
URL: https://github.com/apache/lucene-solr/pull/2433#issuecomment-786334969
hi @mayya-sharipova, I just ran the command you provided in the jira ticket
against the change, and it now passed as well.
```
xichen@Xis-MacBook-Pro lucene-so
[
https://issues.apache.org/jira/browse/LUCENE-3320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291335#comment-17291335
]
Tomoko Uchida commented on LUCENE-3320:
---
I am very new to this issue. LUCENE-2878
msokolov merged pull request #2433:
URL: https://github.com/apache/lucene-solr/pull/2433
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
[
https://issues.apache.org/jira/browse/LUCENE-9639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291349#comment-17291349
]
ASF subversion and git services commented on LUCENE-9639:
-
Commi
1 - 100 of 111 matches
Mail list logo