zacharymorn opened a new pull request #2433:
URL: https://github.com/apache/lucene-solr/pull/2433


   # Description
   
   Fix nightly test failure by implementing  SimpleTextVectorReader#ramBytesUsed
   
   # Tests
   Passed nightly tests in `TestSimpleTextVectorFormat`
   ```
   xichen@Xis-MacBook-Pro lucene-solr % ./gradlew  :lucene:codecs:test 
--tests="org.apache.lucene.codecs.simpletext.TestSimpleTextVectorFormat" 
-Ptests.nightly=true
   
   > Task :randomizationInfo
   Running tests with randomization seed: tests.seed=7B222A36847DE944
   
   > Task :lucene:codecs:test
   :lucene:codecs:test (SUCCESS): 40 test(s), 1 skipped
   The slowest tests (exceeding 500 ms) during this run:
      5.71s TestSimpleTextVectorFormat.testRamBytesUsed (:lucene:codecs)
   
   BUILD SUCCESSFUL in 12s
   16 actionable tasks: 9 executed, 7 up-to-date
   ```
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to 
Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms 
to the standards described there to the best of my ability.
   - [x] I have created a Jira issue and added the issue ID to my pull request 
title.
   - [x] I have given Solr maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended)
   - [x] I have developed this patch against the `master` branch.
   - [x] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Ref 
Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) 
(for Solr changes only).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to