[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2267: LUCENE-9707: Hunspell: check Lucene's implementation against Hunspel's test data

2021-02-02 Thread GitBox
donnerpeter commented on a change in pull request #2267: URL: https://github.com/apache/lucene-solr/pull/2267#discussion_r568394955 ## File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/SpellCheckerTest.java ## @@ -61,59 +61,74 @@ public void needAf

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2258: LUCENE-9686: Fix read past EOF handling in DirectIODirectory

2021-02-02 Thread GitBox
dweiss commented on a change in pull request #2258: URL: https://github.com/apache/lucene-solr/pull/2258#discussion_r568395337 ## File path: lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java ## @@ -381,17 +377,18 @@ public long length() { @Override

[GitHub] [lucene-solr] dweiss merged pull request #2258: LUCENE-9686: Fix read past EOF handling in DirectIODirectory

2021-02-02 Thread GitBox
dweiss merged pull request #2258: URL: https://github.com/apache/lucene-solr/pull/2258 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Resolved] (LUCENE-9686) TestDirectIODirectory#testFloatsUnderflow can fail assertion

2021-02-02 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9686. - Fix Version/s: master (9.0) Resolution: Fixed > TestDirectIODirectory#testFloatsUnderflow

[jira] [Commented] (LUCENE-9686) TestDirectIODirectory#testFloatsUnderflow can fail assertion

2021-02-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17276925#comment-17276925 ] ASF subversion and git services commented on LUCENE-9686: - Commi

[jira] [Commented] (LUCENE-9686) TestDirectIODirectory#testFloatsUnderflow can fail assertion

2021-02-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17276927#comment-17276927 ] ASF subversion and git services commented on LUCENE-9686: - Commi

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2267: LUCENE-9707: Hunspell: check Lucene's implementation against Hunspel's test data

2021-02-02 Thread GitBox
dweiss commented on a change in pull request #2267: URL: https://github.com/apache/lucene-solr/pull/2267#discussion_r568397883 ## File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/SpellCheckerTest.java ## @@ -61,59 +61,74 @@ public void needAffixOn

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2267: LUCENE-9707: Hunspell: check Lucene's implementation against Hunspel's test data

2021-02-02 Thread GitBox
dweiss commented on a change in pull request #2267: URL: https://github.com/apache/lucene-solr/pull/2267#discussion_r568398245 ## File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/SpellCheckerTest.java ## @@ -61,59 +61,74 @@ public void needAffixOn

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2267: LUCENE-9707: Hunspell: check Lucene's implementation against Hunspel's test data

2021-02-02 Thread GitBox
donnerpeter commented on a change in pull request #2267: URL: https://github.com/apache/lucene-solr/pull/2267#discussion_r568402121 ## File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/TestsFromOriginalHunspellRepository.java ## @@ -0,0 +1,71 @@ +/

[jira] [Commented] (SOLR-15104) Restart solr will override the gc log

2021-02-02 Thread Hongxu Ma (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17276948#comment-17276948 ] Hongxu Ma commented on SOLR-15104: -- I opened a PR to improve it: https://github.com/apac

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2267: LUCENE-9707: Hunspell: check Lucene's implementation against Hunspel's test data

2021-02-02 Thread GitBox
dweiss commented on a change in pull request #2267: URL: https://github.com/apache/lucene-solr/pull/2267#discussion_r568415196 ## File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/TestsFromOriginalHunspellRepository.java ## @@ -0,0 +1,71 @@ +/* + *

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #2284: SOLR-11233: Add optional JAVA8_GC_LOG_FILE_OPTS for bin/solr.

2021-02-02 Thread GitBox
cpoerschke commented on a change in pull request #2284: URL: https://github.com/apache/lucene-solr/pull/2284#discussion_r568428808 ## File path: solr/bin/solr ## @@ -2026,7 +2026,11 @@ if [ "$GC_LOG_OPTS" != "" ]; then if [ "$JAVA_VENDOR" == "IBM J9" ]; then gc_log_

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #2263: SOLR-14978 OOM Killer in Foreground (#2055)

2021-02-02 Thread GitBox
cpoerschke commented on a change in pull request #2263: URL: https://github.com/apache/lucene-solr/pull/2263#discussion_r568436589 ## File path: solr/bin/solr ## @@ -2115,6 +2128,15 @@ function start_solr() { SOLR_OPTS+=($AUTHC_OPTS) fi + # If a heap dump directory i

[GitHub] [lucene-solr] donnerpeter commented on pull request #2267: LUCENE-9707: Hunspell: check Lucene's implementation against Hunspel's test data

2021-02-02 Thread GitBox
donnerpeter commented on pull request #2267: URL: https://github.com/apache/lucene-solr/pull/2267#issuecomment-771492242 I've done some rebasing, included your patch, renamed the test and tweaked the code a bit. Hopefully it's better now. --

[GitHub] [lucene-solr] dweiss commented on pull request #2267: LUCENE-9707: Hunspell: check Lucene's implementation against Hunspel's test data

2021-02-02 Thread GitBox
dweiss commented on pull request #2267: URL: https://github.com/apache/lucene-solr/pull/2267#issuecomment-771498850 Eh. This is why Parameterized works for you and randomizedtesting doesn't: https://github.com/JetBrains/intellij-community/blob/master/plugins/junit_rt/src/com/intellij/jun

[GitHub] [lucene-solr] dweiss commented on pull request #2267: LUCENE-9707: Hunspell: check Lucene's implementation against Hunspel's test data

2021-02-02 Thread GitBox
dweiss commented on pull request #2267: URL: https://github.com/apache/lucene-solr/pull/2267#issuecomment-771499577 If you take a look at that class you'll understand why it's such a mess to try to navigate those test descriptions... ---

[GitHub] [lucene-solr] donnerpeter commented on pull request #2267: LUCENE-9707: Hunspell: check Lucene's implementation against Hunspel's test data

2021-02-02 Thread GitBox
donnerpeter commented on pull request #2267: URL: https://github.com/apache/lucene-solr/pull/2267#issuecomment-771503328 > Eh. This is why Parameterized works for you and randomizedtesting doesn't: > https://github.com/JetBrains/intellij-community/blob/master/plugins/junit_rt/src/com/int

[GitHub] [lucene-solr] dweiss commented on pull request #2267: LUCENE-9707: Hunspell: check Lucene's implementation against Hunspel's test data

2021-02-02 Thread GitBox
dweiss commented on pull request #2267: URL: https://github.com/apache/lucene-solr/pull/2267#issuecomment-771504446 Yes, sadly. I haven't looked at junit5, shame on me. Perhaps it's improved there. This is an automated messa

[GitHub] [lucene-solr] dweiss merged pull request #2267: LUCENE-9707: Hunspell: check Lucene's implementation against Hunspel's test data

2021-02-02 Thread GitBox
dweiss merged pull request #2267: URL: https://github.com/apache/lucene-solr/pull/2267 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Resolved] (LUCENE-9707) Hunspell: check Lucene's implementation against Hunspell's test data

2021-02-02 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9707. - Fix Version/s: master (9.0) Resolution: Fixed > Hunspell: check Lucene's implementation a

[jira] [Commented] (LUCENE-9707) Hunspell: check Lucene's implementation against Hunspell's test data

2021-02-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17276991#comment-17276991 ] ASF subversion and git services commented on LUCENE-9707: - Commi

[jira] [Updated] (SOLR-15122) ClusterEventProducerTest.testEvents is unstable

2021-02-02 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki updated SOLR-15122: Fix Version/s: master (9.0) > ClusterEventProducerTest.testEvents is unstable > ---

[jira] [Assigned] (SOLR-15122) ClusterEventProducerTest.testEvents is unstable

2021-02-02 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki reassigned SOLR-15122: --- Assignee: Andrzej Bialecki > ClusterEventProducerTest.testEvents is unstable > -

[jira] [Commented] (SOLR-15122) ClusterEventProducerTest.testEvents is unstable

2021-02-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277041#comment-17277041 ] ASF subversion and git services commented on SOLR-15122: Commit 4

[jira] [Resolved] (SOLR-15068) RefGuide documentation for replica placement plugins

2021-02-02 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki resolved SOLR-15068. - Resolution: Fixed > RefGuide documentation for replica placement plugins > --

[jira] [Commented] (SOLR-15122) ClusterEventProducerTest.testEvents is unstable

2021-02-02 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277044#comment-17277044 ] Andrzej Bialecki commented on SOLR-15122: - I'll leave this open to see if the fix

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #2256: LUCENE-9507 Custom order for leaves in IndexReader and IndexWriter

2021-02-02 Thread GitBox
mayya-sharipova commented on a change in pull request #2256: URL: https://github.com/apache/lucene-solr/pull/2256#discussion_r568520864 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -941,6 +969,11 @@ public IndexWriter(Directory d, IndexWrite

[jira] [Commented] (LUCENE-9705) Move all codec formats to the o.a.l.codecs.Lucene90 package

2021-02-02 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277050#comment-17277050 ] Ignacio Vera commented on LUCENE-9705: -- Thanks Julie, I think you capture the spiri

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2277: LUCENE-9716: Hunspell: support flag usage before its format is even specified

2021-02-02 Thread GitBox
dweiss commented on a change in pull request #2277: URL: https://github.com/apache/lucene-solr/pull/2277#discussion_r568569461 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java ## @@ -696,45 +690,25 @@ char affixData(int affixInd

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2277: LUCENE-9716: Hunspell: support flag usage before its format is even specified

2021-02-02 Thread GitBox
donnerpeter commented on a change in pull request #2277: URL: https://github.com/apache/lucene-solr/pull/2277#discussion_r568575767 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java ## @@ -696,45 +690,25 @@ char affixData(int aff

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2277: LUCENE-9716: Hunspell: support flag usage before its format is even specified

2021-02-02 Thread GitBox
dweiss commented on a change in pull request #2277: URL: https://github.com/apache/lucene-solr/pull/2277#discussion_r568580925 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java ## @@ -696,45 +690,25 @@ char affixData(int affixInd

[jira] [Commented] (SOLR-15119) Make LINK splitMethod the default for SplitShardCmd

2021-02-02 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277109#comment-17277109 ] Gézapeti commented on SOLR-15119: - I've tried it out and the Link method works with HDFS

[jira] [Commented] (LUCENE-9636) Exact and operation to get a SIMD optimize

2021-02-02 Thread Markus Jelsma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277119#comment-17277119 ] Markus Jelsma commented on LUCENE-9636: --- * [LUCENE-9636|http://issues.apache.org/j

[jira] [Resolved] (LUCENE-9636) Exact and operation to get a SIMD optimize

2021-02-02 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Guo resolved LUCENE-9636. -- Resolution: Fixed > Exact and operation to get a SIMD optimize > -

[jira] [Commented] (SOLR-15122) ClusterEventProducerTest.testEvents is unstable

2021-02-02 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277129#comment-17277129 ] Mike Drob commented on SOLR-15122: -- I had just gone through and replaced a bunch of busy

[GitHub] [lucene-solr] jpountz commented on a change in pull request #2268: LUCENE-9705: Move Lucene50CompoundFormat to Lucene90CompoundFormat

2021-02-02 Thread GitBox
jpountz commented on a change in pull request #2268: URL: https://github.com/apache/lucene-solr/pull/2268#discussion_r568617447 ## File path: lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene50/Lucene50CompoundFormat.java ## @@ -0,0 +1,88 @@ +/* + * Lice

[jira] [Created] (LUCENE-9723) Hunspell: update sanity tests that load all dictionaries

2021-02-02 Thread Peter Gromov (Jira)
Peter Gromov created LUCENE-9723: Summary: Hunspell: update sanity tests that load all dictionaries Key: LUCENE-9723 URL: https://issues.apache.org/jira/browse/LUCENE-9723 Project: Lucene - Core

[GitHub] [lucene-solr] donnerpeter opened a new pull request #2290: LUCENE-9723: Hunspell: update sanity tests that load all dictionaries

2021-02-02 Thread GitBox
donnerpeter opened a new pull request #2290: URL: https://github.com/apache/lucene-solr/pull/2290 # Description `TestAllDictionaries`(2) are hard to run and their javadoc outdated, as well as the package's javadoc # Solution Make it a single test understandi

[GitHub] [lucene-solr] dweiss commented on pull request #2277: LUCENE-9716: Hunspell: support flag usage before its format is even specified

2021-02-02 Thread GitBox
dweiss commented on pull request #2277: URL: https://github.com/apache/lucene-solr/pull/2277#issuecomment-771677497 Hi Peter. I pushed a commit which replaces bom consumption with a small function so that either it's read atomically or nothing is consumed at all. Looking at the code also m

[GitHub] [lucene-solr] donnerpeter commented on pull request #2277: LUCENE-9716: Hunspell: support flag usage before its format is even specified

2021-02-02 Thread GitBox
donnerpeter commented on pull request #2277: URL: https://github.com/apache/lucene-solr/pull/2277#issuecomment-771711060 Thank you, LGTM! This is an automated message from the Apache Git Service. To respond to the message, pl

[jira] [Comment Edited] (SOLR-15119) Make LINK splitMethod the default for SplitShardCmd

2021-02-02 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277109#comment-17277109 ] Gézapeti edited comment on SOLR-15119 at 2/2/21, 4:01 PM: -- I've

[GitHub] [lucene-solr] dnhatn commented on pull request #2288: LUCENE-9722: Close merged readers on abort

2021-02-02 Thread GitBox
dnhatn commented on pull request #2288: URL: https://github.com/apache/lucene-solr/pull/2288#issuecomment-771758863 Thanks Simon. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [lucene-solr] dnhatn merged pull request #2288: LUCENE-9722: Close merged readers on abort

2021-02-02 Thread GitBox
dnhatn merged pull request #2288: URL: https://github.com/apache/lucene-solr/pull/2288 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (LUCENE-9722) Aborted merge can leak readers if the output is empty

2021-02-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277256#comment-17277256 ] ASF subversion and git services commented on LUCENE-9722: - Commi

[jira] [Created] (LUCENE-9724) Hunspell: load dictionaries with extra content on REP lines

2021-02-02 Thread Peter Gromov (Jira)
Peter Gromov created LUCENE-9724: Summary: Hunspell: load dictionaries with extra content on REP lines Key: LUCENE-9724 URL: https://issues.apache.org/jira/browse/LUCENE-9724 Project: Lucene - Core

[jira] [Updated] (LUCENE-9724) Hunspell: tolerate extra content on REP lines

2021-02-02 Thread Peter Gromov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Gromov updated LUCENE-9724: - Summary: Hunspell: tolerate extra content on REP lines (was: Hunspell: load dictionaries with e

[jira] [Updated] (SOLR-14886) Suppress stack trace in Query response.

2021-02-02 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Isabelle Giguere updated SOLR-14886: Attachment: SOLR-14886.patch > Suppress stack trace in Query response. > --

[jira] [Commented] (SOLR-14886) Suppress stack trace in Query response.

2021-02-02 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277272#comment-17277272 ] Isabelle Giguere commented on SOLR-14886: - Patch off current Solr master branch (

[GitHub] [lucene-solr] bruno-roustant commented on pull request #2213: LUCENE-9663: Adding compression to terms dict from SortedSet/Sorted DocValues

2021-02-02 Thread GitBox
bruno-roustant commented on pull request #2213: URL: https://github.com/apache/lucene-solr/pull/2213#issuecomment-771782427 I expect you don't need to change Lucene code but just write a new custom codec (with a specific name) which provides a custom DocValuesFormat. It extends PerFieldDoc

[jira] [Commented] (LUCENE-9722) Aborted merge can leak readers if the output is empty

2021-02-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277288#comment-17277288 ] ASF subversion and git services commented on LUCENE-9722: - Commi

[jira] [Commented] (LUCENE-9722) Aborted merge can leak readers if the output is empty

2021-02-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277339#comment-17277339 ] ASF subversion and git services commented on LUCENE-9722: - Commi

[jira] [Updated] (LUCENE-9724) Hunspell: tolerate existing aff/dic file typos

2021-02-02 Thread Peter Gromov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Gromov updated LUCENE-9724: - Summary: Hunspell: tolerate existing aff/dic file typos (was: Hunspell: tolerate extra content

[GitHub] [lucene-solr] jtibshirani commented on pull request #2276: Improve backwards compatibility tests for sorted indexes.

2021-02-02 Thread GitBox
jtibshirani commented on pull request #2276: URL: https://github.com/apache/lucene-solr/pull/2276#issuecomment-771834969 @mikemccand I tagged you for a (hopefully quick) review, as I think you added the TODOs? This is an aut

[jira] [Updated] (LUCENE-9722) Aborted merge can leak readers if the output is empty

2021-02-02 Thread Nhat Nguyen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-9722: Fix Version/s: 8.9 master (9.0) 8.0.1 Resolution: Fixe

[GitHub] [lucene-solr] madrob opened a new pull request #2291: SOLR-15122 Replace volatile+sleep with wait/notify

2021-02-02 Thread GitBox
madrob opened a new pull request #2291: URL: https://github.com/apache/lucene-solr/pull/2291 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (SOLR-15124) Remove node/container level admin handlers from ImplicitPlugins.json (core level).

2021-02-02 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277347#comment-17277347 ] Cassandra Targett commented on SOLR-15124: -- I'm not able to understand entirely

[jira] [Commented] (SOLR-15122) ClusterEventProducerTest.testEvents is unstable

2021-02-02 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277353#comment-17277353 ] Mike Drob commented on SOLR-15122: -- I put up a PR to demonstrate what I meant, I think t

[jira] [Commented] (SOLR-15122) ClusterEventProducerTest.testEvents is unstable

2021-02-02 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277360#comment-17277360 ] Ilan Ginzburg commented on SOLR-15122: -- ??We shouldn't use postfix increment with a

[jira] [Comment Edited] (SOLR-15122) ClusterEventProducerTest.testEvents is unstable

2021-02-02 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277360#comment-17277360 ] Ilan Ginzburg edited comment on SOLR-15122 at 2/2/21, 6:16 PM:

[GitHub] [lucene-solr] sigram commented on a change in pull request #2291: SOLR-15122 Replace volatile+sleep with wait/notify

2021-02-02 Thread GitBox
sigram commented on a change in pull request #2291: URL: https://github.com/apache/lucene-solr/pull/2291#discussion_r568832617 ## File path: solr/core/src/java/org/apache/solr/cluster/events/impl/DelegatingClusterEventProducer.java ## @@ -90,7 +95,10 @@ public void setDelegate

[GitHub] [lucene-solr] sigram commented on a change in pull request #2291: SOLR-15122 Replace volatile+sleep with wait/notify

2021-02-02 Thread GitBox
sigram commented on a change in pull request #2291: URL: https://github.com/apache/lucene-solr/pull/2291#discussion_r568833400 ## File path: solr/core/src/java/org/apache/solr/cluster/events/impl/DelegatingClusterEventProducer.java ## @@ -144,7 +152,25 @@ public synchronized v

[GitHub] [lucene-solr] sigram commented on a change in pull request #2291: SOLR-15122 Replace volatile+sleep with wait/notify

2021-02-02 Thread GitBox
sigram commented on a change in pull request #2291: URL: https://github.com/apache/lucene-solr/pull/2291#discussion_r568833741 ## File path: solr/core/src/test/org/apache/solr/cluster/events/ClusterEventProducerTest.java ## @@ -292,7 +287,7 @@ public void testListenerPlugins()

[jira] [Updated] (SOLR-15128) nodeName does not contain expected ':' separator: localhost

2021-02-02 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Potter updated SOLR-15128: -- Fix Version/s: master (9.0) > nodeName does not contain expected ':' separator: localhost > ---

[jira] [Created] (SOLR-15128) nodeName does not contain expected ':' separator: localhost

2021-02-02 Thread Timothy Potter (Jira)
Timothy Potter created SOLR-15128: - Summary: nodeName does not contain expected ':' separator: localhost Key: SOLR-15128 URL: https://issues.apache.org/jira/browse/SOLR-15128 Project: Solr I

[jira] [Commented] (SOLR-15128) nodeName does not contain expected ':' separator: localhost

2021-02-02 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277376#comment-17277376 ] Timothy Potter commented on SOLR-15128: --- Not sure why master is seeing {{localhost}

[jira] [Resolved] (SOLR-15128) nodeName does not contain expected ':' separator: localhost

2021-02-02 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Potter resolved SOLR-15128. --- Resolution: Won't Fix Ignore this ;-) Was using the wrong method to get the nodeName in some

[jira] [Commented] (SOLR-15122) ClusterEventProducerTest.testEvents is unstable

2021-02-02 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277399#comment-17277399 ] Mike Drob commented on SOLR-15122: -- I'm pretty comfortable with that blanket statement.

[GitHub] [lucene-solr] madrob commented on a change in pull request #2291: SOLR-15122 Replace volatile+sleep with wait/notify

2021-02-02 Thread GitBox
madrob commented on a change in pull request #2291: URL: https://github.com/apache/lucene-solr/pull/2291#discussion_r568852727 ## File path: solr/core/src/java/org/apache/solr/cluster/events/impl/DelegatingClusterEventProducer.java ## @@ -144,7 +152,25 @@ public synchronized v

[jira] [Commented] (SOLR-15122) ClusterEventProducerTest.testEvents is unstable

2021-02-02 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277406#comment-17277406 ] Ilan Ginzburg commented on SOLR-15122: -- You're right about no mutable Integer. Woul

[jira] [Commented] (SOLR-15122) ClusterEventProducerTest.testEvents is unstable

2021-02-02 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277423#comment-17277423 ] Mike Drob commented on SOLR-15122: -- Refactored the code in anticipation of working over

[GitHub] [lucene-solr] orenovadia commented on a change in pull request #2231: LUCENE-9680 - Re-add IndexWriter::getFieldNames

2021-02-02 Thread GitBox
orenovadia commented on a change in pull request #2231: URL: https://github.com/apache/lucene-solr/pull/2231#discussion_r568890937 ## File path: lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java ## @@ -4600,4 +4600,49 @@ public void testIndexWriterBlocksOnStall(

[GitHub] [lucene-solr] dweiss merged pull request #2277: LUCENE-9716: Hunspell: support flag usage before its format is even specified

2021-02-02 Thread GitBox
dweiss merged pull request #2277: URL: https://github.com/apache/lucene-solr/pull/2277 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Resolved] (LUCENE-9716) Hunspell: support flag usage before its format is even specified

2021-02-02 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9716. - Fix Version/s: master (9.0) Resolution: Fixed > Hunspell: support flag usage before its f

[jira] [Commented] (LUCENE-9716) Hunspell: support flag usage before its format is even specified

2021-02-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277437#comment-17277437 ] ASF subversion and git services commented on LUCENE-9716: - Commi

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2291: SOLR-15122 Replace volatile+sleep with wait/notify

2021-02-02 Thread GitBox
murblanc commented on a change in pull request #2291: URL: https://github.com/apache/lucene-solr/pull/2291#discussion_r568912229 ## File path: solr/core/src/java/org/apache/solr/cluster/events/impl/DelegatingClusterEventProducer.java ## @@ -90,7 +96,9 @@ public void setDelegat

[jira] [Commented] (SOLR-15122) ClusterEventProducerTest.testEvents is unstable

2021-02-02 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277448#comment-17277448 ] Ilan Ginzburg commented on SOLR-15122: -- Added a few comments. I like this approach m

[jira] [Updated] (SOLR-15092) Loosen Ref Guide link checking to allow empty anchors in links

2021-02-02 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-15092: -- Attachment: SOLR-15092.patch Assignee: Chris M. Hostetter Status: Open (w

[GitHub] [lucene-solr] madrob commented on a change in pull request #2291: SOLR-15122 Replace volatile+sleep with wait/notify

2021-02-02 Thread GitBox
madrob commented on a change in pull request #2291: URL: https://github.com/apache/lucene-solr/pull/2291#discussion_r568943853 ## File path: solr/core/src/test/org/apache/solr/cluster/VersionTrackerImpl.java ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [lucene-solr] madrob commented on a change in pull request #2291: SOLR-15122 Replace volatile+sleep with wait/notify

2021-02-02 Thread GitBox
madrob commented on a change in pull request #2291: URL: https://github.com/apache/lucene-solr/pull/2291#discussion_r568944250 ## File path: solr/core/src/test/org/apache/solr/cluster/events/ClusterEventProducerTest.java ## @@ -102,7 +105,7 @@ public void teardown() throws Exc

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2291: SOLR-15122 Replace volatile+sleep with wait/notify

2021-02-02 Thread GitBox
murblanc commented on a change in pull request #2291: URL: https://github.com/apache/lucene-solr/pull/2291#discussion_r568968626 ## File path: solr/core/src/test/org/apache/solr/cluster/CountingStateChangeListener.java ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [lucene-solr] msokolov merged pull request #2282: LUCENE-9615: Expose HnswGraphBuilder index-time hyperparameters as FieldType attributes

2021-02-02 Thread GitBox
msokolov merged pull request #2282: URL: https://github.com/apache/lucene-solr/pull/2282 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Commented] (LUCENE-9615) Expose HnswGraphBuilder index-time hyperparameters

2021-02-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277502#comment-17277502 ] ASF subversion and git services commented on LUCENE-9615: - Commi

[GitHub] [lucene-solr] madrob commented on a change in pull request #2291: SOLR-15122 Replace volatile+sleep with wait/notify

2021-02-02 Thread GitBox
madrob commented on a change in pull request #2291: URL: https://github.com/apache/lucene-solr/pull/2291#discussion_r568977953 ## File path: solr/core/src/test/org/apache/solr/cluster/CountingStateChangeListener.java ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene-solr] msokolov commented on a change in pull request #2231: LUCENE-9680 - Re-add IndexWriter::getFieldNames

2021-02-02 Thread GitBox
msokolov commented on a change in pull request #2231: URL: https://github.com/apache/lucene-solr/pull/2231#discussion_r568979069 ## File path: lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java ## @@ -4600,4 +4600,49 @@ public void testIndexWriterBlocksOnStall()

[GitHub] [lucene-solr] msokolov merged pull request #2231: LUCENE-9680 - Re-add IndexWriter::getFieldNames

2021-02-02 Thread GitBox
msokolov merged pull request #2231: URL: https://github.com/apache/lucene-solr/pull/2231 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Commented] (LUCENE-9680) Re-add IndexWriter.getFieldNames

2021-02-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277508#comment-17277508 ] ASF subversion and git services commented on LUCENE-9680: - Commi

[jira] [Commented] (LUCENE-9680) Re-add IndexWriter.getFieldNames

2021-02-02 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277510#comment-17277510 ] Michael Sokolov commented on LUCENE-9680: - [~oren.ovadia] do you also want to ba

[jira] [Commented] (SOLR-15122) ClusterEventProducerTest.testEvents is unstable

2021-02-02 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277519#comment-17277519 ] Mike Drob commented on SOLR-15122: -- I was thinking about this some more, and think we sh

[jira] [Commented] (SOLR-5480) Make MoreLikeThisHandler distributable

2021-02-02 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-5480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277522#comment-17277522 ] Isabelle Giguere commented on SOLR-5480: [~erickerickson], [~noble.paul], [~anshum

[jira] [Commented] (SOLR-15122) ClusterEventProducerTest.testEvents is unstable

2021-02-02 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277529#comment-17277529 ] Ilan Ginzburg commented on SOLR-15122: -- I've never used this specific class but if y

[jira] [Commented] (SOLR-15127) All-In-One Dockerfile for building local images as well as reproducible release builds directly from (remote) git tags

2021-02-02 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277530#comment-17277530 ] Houston Putman commented on SOLR-15127: --- I think there are two possible ways of goi

[jira] [Created] (SOLR-15129) Use the Solr TGZ artifact as Docker context

2021-02-02 Thread Houston Putman (Jira)
Houston Putman created SOLR-15129: - Summary: Use the Solr TGZ artifact as Docker context Key: SOLR-15129 URL: https://issues.apache.org/jira/browse/SOLR-15129 Project: Solr Issue Type: Sub-ta

[jira] [Created] (LUCENE-9725) Allow BM25FQuery to use other similarities

2021-02-02 Thread Julie Tibshirani (Jira)
Julie Tibshirani created LUCENE-9725: Summary: Allow BM25FQuery to use other similarities Key: LUCENE-9725 URL: https://issues.apache.org/jira/browse/LUCENE-9725 Project: Lucene - Core Is

[GitHub] [lucene-solr] HoustonPutman opened a new pull request #2292: SOLR-15102: Use Solr distribution TGZ as docker context

2021-02-02 Thread GitBox
HoustonPutman opened a new pull request #2292: URL: https://github.com/apache/lucene-solr/pull/2292 https://issues.apache.org/jira/browse/SOLR-15102 This should work, but there is still cleanup needed with the gradle changes. Also we might want to infer the Solr version another

[jira] [Comment Edited] (SOLR-15127) All-In-One Dockerfile for building local images as well as reproducible release builds directly from (remote) git tags

2021-02-02 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277530#comment-17277530 ] Houston Putman edited comment on SOLR-15127 at 2/2/21, 11:49 PM: --

[jira] [Updated] (LUCENE-9725) Allow BM25FQuery to use other similarities

2021-02-02 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julie Tibshirani updated LUCENE-9725: - Description: >From a high level, BM25FQuery works as follows: # Given a list of fields a

[jira] [Commented] (SOLR-15127) All-In-One Dockerfile for building local images as well as reproducible release builds directly from (remote) git tags

2021-02-02 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277542#comment-17277542 ] Chris M. Hostetter commented on SOLR-15127: --- bq. David Smiley's suggestion of u

[GitHub] [lucene-solr] jtibshirani opened a new pull request #2293: LUCENE-9725: Allow BM25FQuery to use other similarities.

2021-02-02 Thread GitBox
jtibshirani opened a new pull request #2293: URL: https://github.com/apache/lucene-solr/pull/2293 From a high level, BM25FQuery (1) computes statistic that represent the combined field content and (2) passes these to a score function. This model makes sense for many similarities besi

[jira] [Commented] (LUCENE-9725) Allow BM25FQuery to use other similarities

2021-02-02 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277545#comment-17277545 ] Julie Tibshirani commented on LUCENE-9725: -- I opened https://github.com/apache/

[GitHub] [lucene-solr] zhaih commented on pull request #2213: LUCENE-9663: Adding compression to terms dict from SortedSet/Sorted DocValues

2021-02-02 Thread GitBox
zhaih commented on pull request #2213: URL: https://github.com/apache/lucene-solr/pull/2213#issuecomment-771265310 I see, so I think for now I could test it via a customized PerFieldDocValuesFormat, I'll give PerFieldDocValuesFormat route a try then. Tho IMO I would prefer a simpler

  1   2   >