[
https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277353#comment-17277353
]
Mike Drob commented on SOLR-15122:
----------------------------------
I put up a PR to demonstrate what I meant, I think the same pattern should be
applied to the DelegatingPlacementPlugin code, if this was based on that.
I trust that the design here is correct for accomplishing what we need, but the
implementation needed a few touch ups from what you did.
* We shouldn't use postfix increment with a volatile variable, as that is not
an atomic operation.
* Using wait/notify is going to be more efficient use of resources than a busy
wait.
* You weren't saving the new value of version on subsequent calls, so I updated
that too.
Please take a look and confirm that this still maintains the intent of what you
were trying to do.
> ClusterEventProducerTest.testEvents is unstable
> -----------------------------------------------
>
> Key: SOLR-15122
> URL: https://issues.apache.org/jira/browse/SOLR-15122
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Tests
> Reporter: Mike Drob
> Assignee: Andrzej Bialecki
> Priority: Major
> Fix For: master (9.0)
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This test looks to be unstable according to Jenkins since about Nov 5. I just
> started seeing occasional failures locally when running the whole suite but
> cannot reproduce when running in isolation.
> https://lists.apache.org/thread.html/rf0c16b257bc3236ea414be51451806352b55f15d4949f4fd54a3b71a%40%3Cbuilds.lucene.apache.org%3E
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
