sigram commented on a change in pull request #2291: URL: https://github.com/apache/lucene-solr/pull/2291#discussion_r568833400
########## File path: solr/core/src/java/org/apache/solr/cluster/events/impl/DelegatingClusterEventProducer.java ########## @@ -144,7 +152,25 @@ public synchronized void stop() { } @VisibleForTesting - public int getVersion() { - return version; + public int waitForVersionChange(int currentVersion, int timeoutSec) throws InterruptedException, TimeoutException { Review comment: I debated whether to add this to the wrappers... it's only needed in tests. OTOH putting it here makes the test code much simpler. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org