iverase commented on pull request #2155:
URL: https://github.com/apache/lucene-solr/pull/2155#issuecomment-751994065
if there are no more comments, I will push this change next week.
This is an automated message from the Apac
[
https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-9570:
Description:
Review and correct all the javadocs before they're messed up by automatic
formatting
[
https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-9570:
Description:
Review and correct all the javadocs before they're messed up by automatic
formatting
Dawid Weiss created LUCENE-9651:
---
Summary: Correct javadoc for benchmarks
Key: LUCENE-9651
URL: https://issues.apache.org/jira/browse/LUCENE-9651
Project: Lucene - Core
Issue Type: Task
[
https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-9570:
Description:
Review and correct all the javadocs before they're messed up by automatic
formatting
trdillon commented on a change in pull request #2169:
URL: https://github.com/apache/lucene-solr/pull/2169#discussion_r549674546
##
File path: solr/core/src/test-files/solr/collection1/conf/solrconfig-caching.xml
##
@@ -21,19 +21,16 @@
trdillon commented on pull request #2169:
URL: https://github.com/apache/lucene-solr/pull/2169#issuecomment-752048769
>
>
> For `TestSolr4Spatial2`, I think you just need to add [this
line](https://github.com/apache/lucene-solr/blob/master/solr/core/src/test/org/apache/solr/search/T
[
https://issues.apache.org/jira/browse/LUCENE-9650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255972#comment-17255972
]
Uwe Schindler commented on LUCENE-9650:
---
That's what I did, see the log dump a pos
[
https://issues.apache.org/jira/browse/LUCENE-9650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255973#comment-17255973
]
Uwe Schindler commented on LUCENE-9650:
---
My testing:
{noformat}
> gradlew compile
[
https://issues.apache.org/jira/browse/SOLR-14608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256020#comment-17256020
]
ASF subversion and git services commented on SOLR-14608:
Commit c
[
https://issues.apache.org/jira/browse/SOLR-15058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothy Potter reassigned SOLR-15058:
-
Assignee: Timothy Potter
> Solr can not get correct hostname when hostname contain '_'
>
[
https://issues.apache.org/jira/browse/SOLR-15058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256071#comment-17256071
]
Timothy Potter commented on SOLR-15058:
---
Let's get this fixed for 8.8 ... I'll work
[
https://issues.apache.org/jira/browse/SOLR-14608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256081#comment-17256081
]
ASF subversion and git services commented on SOLR-14608:
Commit d
thelabdude commented on a change in pull request #2164:
URL: https://github.com/apache/lucene-solr/pull/2164#discussion_r549791687
##
File path: solr/solrj/src/test/org/apache/solr/common/cloud/UrlSchemeTest.java
##
@@ -35,12 +35,12 @@ public void testApplyUrlScheme() {
St
thelabdude commented on a change in pull request #2164:
URL: https://github.com/apache/lucene-solr/pull/2164#discussion_r549791973
##
File path: solr/solrj/src/test/org/apache/solr/common/cloud/UrlSchemeTest.java
##
@@ -35,12 +35,12 @@ public void testApplyUrlScheme() {
St
nknize commented on pull request #2155:
URL: https://github.com/apache/lucene-solr/pull/2155#issuecomment-752197102
With the holidays and folks out on vacation would you mind holding off until
the end of next week? I plan to have a look at the other two changes by the end
of this week and
thelabdude commented on a change in pull request #2164:
URL: https://github.com/apache/lucene-solr/pull/2164#discussion_r549807523
##
File path: solr/solrj/src/test/org/apache/solr/common/cloud/UrlSchemeTest.java
##
@@ -35,12 +35,12 @@ public void testApplyUrlScheme() {
St
[
https://issues.apache.org/jira/browse/LUCENE-9622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir resolved LUCENE-9622.
-
Resolution: Duplicate
Fixed by LUCENE-9650
> provide gradle option to disable error-prone check
tflobbe commented on pull request #2169:
URL: https://github.com/apache/lucene-solr/pull/2169#issuecomment-752336456
> Should I make changes to this class?
Looks to me that this change will be needed given the changes in this PR,
right? this test is failing for me in your branch
--
tflobbe commented on a change in pull request #2152:
URL: https://github.com/apache/lucene-solr/pull/2152#discussion_r549948394
##
File path: solr/core/src/test/org/apache/solr/cloud/HttpPartitionTest.java
##
@@ -548,9 +548,6 @@ protected int sendDoc(int docId, Integer minRf, S
iverase commented on pull request #2155:
URL: https://github.com/apache/lucene-solr/pull/2155#issuecomment-752362243
Sure, just hope it can make it to the next release.
This is an automated message from the Apache Git Service
[
https://issues.apache.org/jira/browse/SOLR-14723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256360#comment-17256360
]
ASF subversion and git services commented on SOLR-14723:
Commit 1
[
https://issues.apache.org/jira/browse/SOLR-14723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256361#comment-17256361
]
ASF subversion and git services commented on SOLR-14723:
Commit 1
[
https://issues.apache.org/jira/browse/SOLR-14723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256358#comment-17256358
]
ASF subversion and git services commented on SOLR-14723:
Commit 1
[
https://issues.apache.org/jira/browse/SOLR-14723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256359#comment-17256359
]
ASF subversion and git services commented on SOLR-14723:
Commit 1
tflobbe commented on pull request #2169:
URL: https://github.com/apache/lucene-solr/pull/2169#issuecomment-752364628
Merged to 8.x. Not needed in master
This is an automated message from the Apache Git Service.
To respond to
tflobbe closed pull request #2169:
URL: https://github.com/apache/lucene-solr/pull/2169
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/SOLR-14723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomas Eduardo Fernandez Lobbe updated SOLR-14723:
-
Comment: was deleted
(was: Commit 196632d538a26b0c92a67941ad7c47e
[
https://issues.apache.org/jira/browse/SOLR-14723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomas Eduardo Fernandez Lobbe updated SOLR-14723:
-
Comment: was deleted
(was: Commit 196632d538a26b0c92a67941ad7c47e
[
https://issues.apache.org/jira/browse/SOLR-14723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomas Eduardo Fernandez Lobbe updated SOLR-14723:
-
Comment: was deleted
(was: Commit 196632d538a26b0c92a67941ad7c47e
[
https://issues.apache.org/jira/browse/SOLR-14723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256367#comment-17256367
]
Tomas Eduardo Fernandez Lobbe commented on SOLR-14723:
--
Thanks [~trd
[
https://issues.apache.org/jira/browse/SOLR-14723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomas Eduardo Fernandez Lobbe resolved SOLR-14723.
--
Fix Version/s: 8.8
Resolution: Fixed
> Rremove the class
32 matches
Mail list logo
