[jira] [Created] (SOLR-15058) Solr can not get current hostname when hostname contain '_'

Zhaolong Li created SOLR-15058: -- Summary: Solr can not get current hostname when hostname contain '_' Key: SOLR-15058 URL: https://issues.apache.org/jira/browse/SOLR-15058 Project: Solr Issue T

[jira] [Updated] (SOLR-15058) Solr can not get correct hostname when hostname contain '_'

[ https://issues.apache.org/jira/browse/SOLR-15058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Su Sasa updated SOLR-15058: --- Summary: Solr can not get correct hostname when hostname contain '_' (was: Solr can not get current hostname

[jira] [Updated] (SOLR-15058) Solr can not get correct hostname when hostname contain '_'

[ https://issues.apache.org/jira/browse/SOLR-15058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Su Sasa updated SOLR-15058: --- Attachment: 0001-SOLR-15058-get-the-correct-hostname-when-hostname-co.patch > Solr can not get correct hostna

[jira] [Updated] (SOLR-15058) Solr can not get correct hostname when hostname contain '_'

[ https://issues.apache.org/jira/browse/SOLR-15058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Su Sasa updated SOLR-15058: --- Priority: Minor (was: Major) > Solr can not get correct hostname when hostname contain '_' > ---

[GitHub] [lucene-solr] Sasasu opened a new pull request #2164: SOLR-15058: get the correct hostname when hostname contain '_'

Sasasu opened a new pull request #2164: URL: https://github.com/apache/lucene-solr/pull/2164 # Description `Utils.getBaseUrlForNodeName` split the nodename by the first '_' In ZK, Solr add '_solr' to the end of the hostname # Solution should sp

[jira] [Updated] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied

[ https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9570: Description: Review and correct all the javadocs before they're messed up by automatic formatting

[GitHub] [lucene-solr] sigram commented on a change in pull request #2148: SOLR-15052: Per-replica states for reducing overseer bottlenecks

sigram commented on a change in pull request #2148: URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r547887149 ## File path: solr/core/src/test/org/apache/solr/handler/TestContainerPlugin.java ## @@ -73,6 +79,29 @@ public void teardown() { System.clearPrope

[GitHub] [lucene-solr] sigram commented on a change in pull request #2148: SOLR-15052: Per-replica states for reducing overseer bottlenecks

sigram commented on a change in pull request #2148: URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r547890418 ## File path: solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java ## @@ -81,6 +81,7 @@ public class SolrCloudTestCase extends S

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2133: SOLR-15019: Replica placement API needs a way to fetch existing replica metrics

murblanc commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r547915021 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/AttributeFetcher.java ## @@ -18,93 +18,53 @@ package org.apache.solr.cluster.pla

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2133: SOLR-15019: Replica placement API needs a way to fetch existing replica metrics

murblanc commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r547915611 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/AttributeValues.java ## @@ -65,11 +35,10 @@ /** * For the given node: metr

[jira] [Commented] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied

[ https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254042#comment-17254042 ] ASF subversion and git services commented on LUCENE-9570: - Commi

[jira] [Commented] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied

[ https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254041#comment-17254041 ] ASF subversion and git services commented on LUCENE-9570: - Commi

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2133: SOLR-15019: Replica placement API needs a way to fetch existing replica metrics

murblanc commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r547918055 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/NodeMetric.java ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Founda

[jira] [Commented] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied

[ https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254043#comment-17254043 ] ASF subversion and git services commented on LUCENE-9570: - Commi

[jira] [Commented] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied

[ https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254044#comment-17254044 ] ASF subversion and git services commented on LUCENE-9570: - Commi

[jira] [Commented] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied

[ https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254045#comment-17254045 ] ASF subversion and git services commented on LUCENE-9570: - Commi

[jira] [Updated] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied

[ https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9570: Description: Review and correct all the javadocs before they're messed up by automatic formatting

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2133: SOLR-15019: Replica placement API needs a way to fetch existing replica metrics

murblanc commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r547920372 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/MetricAttribute.java ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2133: SOLR-15019: Replica placement API needs a way to fetch existing replica metrics

murblanc commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r547921749 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/impl/MetricAttributeImpl.java ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache

[jira] [Updated] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied

[ https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9570: Description: Review and correct all the javadocs before they're messed up by automatic formatting

[jira] [Updated] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied

[ https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9570: Description: Review and correct all the javadocs before they're messed up by automatic formatting

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2133: SOLR-15019: Replica placement API needs a way to fetch existing replica metrics

murblanc commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r547930986 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/MetricAttribute.java ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2133: SOLR-15019: Replica placement API needs a way to fetch existing replica metrics

murblanc commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r547932957 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/ReplicaMetrics.java ## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software F

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2133: SOLR-15019: Replica placement API needs a way to fetch existing replica metrics

murblanc commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r547934318 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/impl/AttributeFetcherImpl.java ## @@ -33,18 +37,18 @@ import java.lang.invoke.Me

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2133: SOLR-15019: Replica placement API needs a way to fetch existing replica metrics

murblanc commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r547935041 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/impl/AttributeFetcherImpl.java ## @@ -33,18 +37,18 @@ import java.lang.invoke.Me

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2133: SOLR-15019: Replica placement API needs a way to fetch existing replica metrics

murblanc commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r547935638 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/impl/AttributeFetcherImpl.java ## @@ -113,72 +90,46 @@ public AttributeFetcher fe

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2133: SOLR-15019: Replica placement API needs a way to fetch existing replica metrics

murblanc commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r547936763 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/impl/AttributeFetcherImpl.java ## @@ -113,72 +90,46 @@ public AttributeFetcher fe

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2133: SOLR-15019: Replica placement API needs a way to fetch existing replica metrics

murblanc commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r547938685 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/impl/AttributeFetcherImpl.java ## @@ -197,32 +148,78 @@ public AttributeValues fe

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2133: SOLR-15019: Replica placement API needs a way to fetch existing replica metrics

murblanc commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r547939345 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/impl/AttributeFetcherImpl.java ## @@ -197,32 +148,78 @@ public AttributeValues fe

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2133: SOLR-15019: Replica placement API needs a way to fetch existing replica metrics

murblanc commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r547940278 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/impl/AttributeFetcherImpl.java ## @@ -197,32 +148,78 @@ public AttributeValues fe

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2133: SOLR-15019: Replica placement API needs a way to fetch existing replica metrics

murblanc commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r547943012 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/impl/AttributeFetcherImpl.java ## @@ -197,32 +148,78 @@ public AttributeValues fe

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2133: SOLR-15019: Replica placement API needs a way to fetch existing replica metrics

murblanc commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r547948300 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/impl/MetricAttributeImpl.java ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2133: SOLR-15019: Replica placement API needs a way to fetch existing replica metrics

murblanc commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r547949666 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/impl/MetricAttributeImpl.java ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2133: SOLR-15019: Replica placement API needs a way to fetch existing replica metrics

murblanc commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r547952921 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementFactory.java ## @@ -194,7 +195,9 @@ public PlacementPlan

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2133: SOLR-15019: Replica placement API needs a way to fetch existing replica metrics

murblanc commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r547954091 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementFactory.java ## @@ -194,7 +195,9 @@ public PlacementPlan

[GitHub] [lucene-solr] sigram commented on a change in pull request #2133: SOLR-15019: Replica placement API needs a way to fetch existing replica metrics

sigram commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r547957901 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/AttributeFetcher.java ## @@ -18,93 +18,53 @@ package org.apache.solr.cluster.place

[GitHub] [lucene-solr] sigram commented on a change in pull request #2133: SOLR-15019: Replica placement API needs a way to fetch existing replica metrics

sigram commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r547969376 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/MetricAttribute.java ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [lucene-solr] sigram commented on a change in pull request #2133: SOLR-15019: Replica placement API needs a way to fetch existing replica metrics

sigram commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r547976517 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/ReplicaMetrics.java ## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [lucene-solr] ErickErickson commented on a change in pull request #2164: SOLR-15058: get the correct hostname when hostname contain '_'

ErickErickson commented on a change in pull request #2164: URL: https://github.com/apache/lucene-solr/pull/2164#discussion_r547980795 ## File path: solr/solrj/src/test/org/apache/solr/common/cloud/UrlSchemeTest.java ## @@ -35,12 +35,12 @@ public void testApplyUrlScheme() {

[jira] [Commented] (SOLR-15058) Solr can not get correct hostname when hostname contain '_'

[ https://issues.apache.org/jira/browse/SOLR-15058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254095#comment-17254095 ] Erick Erickson commented on SOLR-15058: --- [~ab] [~noble]  This certainly seems wrong

[GitHub] [lucene-solr] Sasasu commented on a change in pull request #2164: SOLR-15058: get the correct hostname when hostname contain '_'

Sasasu commented on a change in pull request #2164: URL: https://github.com/apache/lucene-solr/pull/2164#discussion_r547981945 ## File path: solr/solrj/src/test/org/apache/solr/common/cloud/UrlSchemeTest.java ## @@ -35,12 +35,12 @@ public void testApplyUrlScheme() { String

[GitHub] [lucene-solr] Sasasu commented on a change in pull request #2164: SOLR-15058: get the correct hostname when hostname contain '_'

Sasasu commented on a change in pull request #2164: URL: https://github.com/apache/lucene-solr/pull/2164#discussion_r547981945 ## File path: solr/solrj/src/test/org/apache/solr/common/cloud/UrlSchemeTest.java ## @@ -35,12 +35,12 @@ public void testApplyUrlScheme() { String

[GitHub] [lucene-solr] sigram commented on a change in pull request #2133: SOLR-15019: Replica placement API needs a way to fetch existing replica metrics

sigram commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r547997354 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/impl/AttributeFetcherImpl.java ## @@ -33,18 +37,18 @@ import java.lang.invoke.Meth

[GitHub] [lucene-solr] sigram commented on a change in pull request #2133: SOLR-15019: Replica placement API needs a way to fetch existing replica metrics

sigram commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r548000385 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/impl/AttributeFetcherImpl.java ## @@ -197,32 +148,78 @@ public AttributeValues fetc

[GitHub] [lucene-solr] sigram commented on a change in pull request #2133: SOLR-15019: Replica placement API needs a way to fetch existing replica metrics

sigram commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r548001677 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/impl/AttributeFetcherImpl.java ## @@ -197,32 +148,78 @@ public AttributeValues fetc

[GitHub] [lucene-solr] sigram commented on a change in pull request #2133: SOLR-15019: Replica placement API needs a way to fetch existing replica metrics

sigram commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r548003144 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/impl/AttributeFetcherImpl.java ## @@ -197,32 +148,78 @@ public AttributeValues fetc

[jira] [Commented] (SOLR-14923) Indexing performance is unacceptable when child documents are involved

[ https://issues.apache.org/jira/browse/SOLR-14923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254118#comment-17254118 ] Thomas Wöckinger commented on SOLR-14923: - I run the indexing tests five times, o

[GitHub] [lucene-solr] sigram commented on a change in pull request #2133: SOLR-15019: Replica placement API needs a way to fetch existing replica metrics

sigram commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r548004312 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/impl/MetricAttributeImpl.java ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache S

[jira] [Commented] (SOLR-15057) avoid unnecessary object retention in FacetRangeProcessor

[ https://issues.apache.org/jira/browse/SOLR-15057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254141#comment-17254141 ] Mike Drob commented on SOLR-15057: -- This looks like a good change - curious how it was f

[jira] [Created] (SOLR-15059) Default Grafana dashboard needs to expose graphs for monitoring query performance

Timothy Potter created SOLR-15059: - Summary: Default Grafana dashboard needs to expose graphs for monitoring query performance Key: SOLR-15059 URL: https://issues.apache.org/jira/browse/SOLR-15059 Pro

[jira] [Updated] (SOLR-15059) Default Grafana dashboard needs to expose graphs for monitoring query performance

[ https://issues.apache.org/jira/browse/SOLR-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Potter updated SOLR-15059: -- Fix Version/s: master (9.0) 8.8 > Default Grafana dashboard needs to expose

[jira] [Updated] (SOLR-15059) Default Grafana dashboard needs to expose graphs for monitoring query performance

[ https://issues.apache.org/jira/browse/SOLR-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Potter updated SOLR-15059: -- Description: The default Grafana dashboard doesn't expose graphs for monitoring query performa

[GitHub] [lucene-solr] thelabdude opened a new pull request #2165: SOLR-15059: Improve query performance monitoring

thelabdude opened a new pull request #2165: URL: https://github.com/apache/lucene-solr/pull/2165 # Description See JIRA: https://issues.apache.org/jira/browse/SOLR-15059 # Solution Improve the Grafana dashboard to include graphs for monitoring query performance.

[jira] [Updated] (SOLR-15059) Default Grafana dashboard needs to expose graphs for monitoring query performance

[ https://issues.apache.org/jira/browse/SOLR-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Potter updated SOLR-15059: -- Status: Patch Available (was: Open) > Default Grafana dashboard needs to expose graphs for mon

[jira] [Updated] (SOLR-15059) Default Grafana dashboard needs to expose graphs for monitoring query performance

[ https://issues.apache.org/jira/browse/SOLR-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Potter updated SOLR-15059: -- Attachment: Screen Shot 2020-12-23 at 10.22.43 AM.png Status: Open (was: Open) > Defau

[GitHub] [lucene-solr] MarcusSorealheis commented on pull request #2165: SOLR-15059: Improve query performance monitoring

MarcusSorealheis commented on pull request #2165: URL: https://github.com/apache/lucene-solr/pull/2165#issuecomment-750402943 Is `stripWs` a term of art? Its definition is semi-obvious but will be even more obvious with a new name. The test files will live a long time and this PR is a key

[jira] [Commented] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied

[ https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254165#comment-17254165 ] Mike Drob commented on LUCENE-9570: --- I tried applying the git blame ignore revisions m

[GitHub] [lucene-solr] epugh commented on pull request #2165: SOLR-15059: Improve query performance monitoring

epugh commented on pull request #2165: URL: https://github.com/apache/lucene-solr/pull/2165#issuecomment-750418268 How does this compare/overlap with any of the dashboards on Grafana's site? https://grafana.com/grafana/dashboards?search=solr Specifically, the one published by @janho

[GitHub] [lucene-solr] thelabdude commented on pull request #2165: SOLR-15059: Improve query performance monitoring

thelabdude commented on pull request #2165: URL: https://github.com/apache/lucene-solr/pull/2165#issuecomment-750423446 @epugh If you diff the dashboard you linked to with the version in master (https://github.com/apache/lucene-solr/blob/master/solr/contrib/prometheus-exporter/conf/grafana-

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #2152: SOLR-14034: remove deprecated min_rf references

cpoerschke commented on a change in pull request #2152: URL: https://github.com/apache/lucene-solr/pull/2152#discussion_r548124061 ## File path: solr/core/src/test/org/apache/solr/cloud/HttpPartitionTest.java ## @@ -548,9 +548,6 @@ protected int sendDoc(int docId, Integer minRf

[GitHub] [lucene-solr] madrob commented on a change in pull request #2165: SOLR-15059: Improve query performance monitoring

madrob commented on a change in pull request #2165: URL: https://github.com/apache/lucene-solr/pull/2165#discussion_r548076192 ## File path: solr/contrib/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/MetricsConfiguration.java ## @@ -105,17 +108,23 @@ public

[GitHub] [lucene-solr] madrob commented on pull request #2163: LUCENE-9647 Add back github action for Ant

madrob commented on pull request #2163: URL: https://github.com/apache/lucene-solr/pull/2163#issuecomment-750424612 It needs to be in the default branch. That we didn't have this for 8.x before isn't a reason not to add it now. -

[GitHub] [lucene-solr] thelabdude commented on a change in pull request #2165: SOLR-15059: Improve query performance monitoring

thelabdude commented on a change in pull request #2165: URL: https://github.com/apache/lucene-solr/pull/2165#discussion_r548126909 ## File path: solr/contrib/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/MetricsConfiguration.java ## @@ -105,17 +108,23 @@ pub

[GitHub] [lucene-solr] thelabdude commented on a change in pull request #2165: SOLR-15059: Improve query performance monitoring

thelabdude commented on a change in pull request #2165: URL: https://github.com/apache/lucene-solr/pull/2165#discussion_r548128158 ## File path: solr/contrib/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/MetricsQueryTemplate.java ## @@ -0,0 +1,128 @@ +/* + *

[jira] [Commented] (SOLR-15057) avoid unnecessary object retention in FacetRangeProcessor

[ https://issues.apache.org/jira/browse/SOLR-15057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254194#comment-17254194 ] Christine Poerschke commented on SOLR-15057: {quote}... curious how it was fo

[GitHub] [lucene-solr] madrob closed pull request #1436: SOLR-14413: allow timeAllowed and cursorMark parameters

madrob closed pull request #1436: URL: https://github.com/apache/lucene-solr/pull/1436 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Updated] (SOLR-14413) allow timeAllowed and cursorMark parameters

[ https://issues.apache.org/jira/browse/SOLR-14413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-14413: - Fix Version/s: master (9.0) 8.8 Assignee: Mike Drob Resolution: Fixed

[jira] [Commented] (SOLR-14413) allow timeAllowed and cursorMark parameters

[ https://issues.apache.org/jira/browse/SOLR-14413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254199#comment-17254199 ] ASF subversion and git services commented on SOLR-14413: Commit b

[GitHub] [lucene-solr] thelabdude commented on a change in pull request #2165: SOLR-15059: Improve query performance monitoring

thelabdude commented on a change in pull request #2165: URL: https://github.com/apache/lucene-solr/pull/2165#discussion_r548158086 ## File path: solr/contrib/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/MetricsConfiguration.java ## @@ -105,17 +108,23 @@ pub

[jira] [Commented] (SOLR-14413) allow timeAllowed and cursorMark parameters

[ https://issues.apache.org/jira/browse/SOLR-14413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254200#comment-17254200 ] ASF subversion and git services commented on SOLR-14413: Commit 7

[GitHub] [lucene-solr] thelabdude commented on pull request #2165: SOLR-15059: Improve query performance monitoring

thelabdude commented on pull request #2165: URL: https://github.com/apache/lucene-solr/pull/2165#issuecomment-750440460 > Is `stripWs` a term of art? Its definition is semi-obvious but will be even more obvious with a new name. The test files will live a long time and this PR is a key addi

[jira] [Updated] (SOLR-15059) Default Grafana dashboard needs to expose graphs for monitoring query performance

[ https://issues.apache.org/jira/browse/SOLR-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Potter updated SOLR-15059: -- Description: The default Grafana dashboard doesn't expose graphs for monitoring query performa

[GitHub] [lucene-solr] tflobbe commented on pull request #2163: LUCENE-9647 Add back github action for Ant

tflobbe commented on pull request #2163: URL: https://github.com/apache/lucene-solr/pull/2163#issuecomment-750441504 > That we didn't have this for 8.x before isn't a reason not to add it now. +1! didn't mean we shouldn't, I was just referring to the fact that I didn't remove it for a pa

[GitHub] [lucene-solr] tflobbe edited a comment on pull request #2163: LUCENE-9647 Add back github action for Ant

tflobbe edited a comment on pull request #2163: URL: https://github.com/apache/lucene-solr/pull/2163#issuecomment-750441504 > That we didn't have this for 8.x before isn't a reason not to add it now. +1! didn't mean we shouldn't, I was just referring to the fact that I didn't remove

[GitHub] [lucene-solr] madrob closed pull request #413: SOLR-11431: Leader candidate cannot become leader if replica responds 500 to PeerSync

madrob closed pull request #413: URL: https://github.com/apache/lucene-solr/pull/413 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [lucene-solr] madrob commented on pull request #413: SOLR-11431: Leader candidate cannot become leader if replica responds 500 to PeerSync

madrob commented on pull request #413: URL: https://github.com/apache/lucene-solr/pull/413#issuecomment-750444015 Closing a stale PR, it looks like this might have had changes once upon a time but then they got lost in a rebase.

[GitHub] [lucene-solr] madrob commented on pull request #383: In ContextQuery, use a more comprehensive check for an empty prefix automaton.

madrob commented on pull request #383: URL: https://github.com/apache/lucene-solr/pull/383#issuecomment-750447704 Going through old patches trying to clean some up before the end of the year. @jtibshirani this patch looks good to me, would you like to commit it? --

[GitHub] [lucene-solr] jtibshirani commented on pull request #383: In ContextQuery, use a more comprehensive check for an empty prefix automaton.

jtibshirani commented on pull request #383: URL: https://github.com/apache/lucene-solr/pull/383#issuecomment-750451014 Thanks @madrob for pinging on this, I'll commit in the next few days. This is an automated message from th

[GitHub] [lucene-solr] madrob commented on pull request #908: Change the file format of README files from README.txt to README.md a…

madrob commented on pull request #908: URL: https://github.com/apache/lucene-solr/pull/908#issuecomment-750451742 Done in #1450 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [lucene-solr] madrob closed pull request #908: Change the file format of README files from README.txt to README.md a…

madrob closed pull request #908: URL: https://github.com/apache/lucene-solr/pull/908 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [lucene-solr] madrob merged pull request #2163: LUCENE-9647 Add back github action for Ant

madrob merged pull request #2163: URL: https://github.com/apache/lucene-solr/pull/2163 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Updated] (LUCENE-9647) Add back ant precommit on PR for branch 8

[ https://issues.apache.org/jira/browse/LUCENE-9647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated LUCENE-9647: -- Priority: Minor (was: Major) > Add back ant precommit on PR for branch 8 > --

[jira] [Resolved] (LUCENE-9647) Add back ant precommit on PR for branch 8

[ https://issues.apache.org/jira/browse/LUCENE-9647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved LUCENE-9647. --- Fix Version/s: master (9.0) Resolution: Fixed > Add back ant precommit on PR for branch 8 > -

[jira] [Commented] (LUCENE-9647) Add back ant precommit on PR for branch 8

[ https://issues.apache.org/jira/browse/LUCENE-9647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254234#comment-17254234 ] ASF subversion and git services commented on LUCENE-9647: - Commi

[jira] [Assigned] (LUCENE-9647) Add back ant precommit on PR for branch 8

[ https://issues.apache.org/jira/browse/LUCENE-9647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob reassigned LUCENE-9647: - Assignee: Mike Drob > Add back ant precommit on PR for branch 8 > -

[GitHub] [lucene-solr] dweiss commented on pull request #2163: LUCENE-9647 Add back github action for Ant

dweiss commented on pull request #2163: URL: https://github.com/apache/lucene-solr/pull/2163#issuecomment-750461143 Why merge it with master though? It does not apply to master - only to 8x? This is an automated message from

[jira] [Commented] (SOLR-14608) Faster sorting for the /export handler

[ https://issues.apache.org/jira/browse/SOLR-14608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254250#comment-17254250 ] ASF subversion and git services commented on SOLR-14608: Commit 0

[jira] [Created] (SOLR-15060) Introduce DelegatingDirectoryFactory

Bruno Roustant created SOLR-15060: - Summary: Introduce DelegatingDirectoryFactory Key: SOLR-15060 URL: https://issues.apache.org/jira/browse/SOLR-15060 Project: Solr Issue Type: Improvement

[jira] [Updated] (SOLR-15060) Introduce DelegatingDirectoryFactory

[ https://issues.apache.org/jira/browse/SOLR-15060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant updated SOLR-15060: -- Description: FilterDirectory already exists to delegate to a Directory, but there is no delega

[GitHub] [lucene-solr] bruno-roustant opened a new pull request #2166: SOLR-15060: Introduce DelegatingDirectoryFactory.

bruno-roustant opened a new pull request #2166: URL: https://github.com/apache/lucene-solr/pull/2166 For the description, see https://issues.apache.org/jira/browse/SOLR-15060 This PR adds a new method get(String path, DirContext dirContext, String rawLockType, Function wrappingFuncti

[jira] [Updated] (SOLR-15060) Introduce DelegatingDirectoryFactory

[ https://issues.apache.org/jira/browse/SOLR-15060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant updated SOLR-15060: -- Description: FilterDirectory already exists to delegate to a Directory, but there is no delega

[GitHub] [lucene-solr] dweiss opened a new pull request #2167: LUCENE-9643: git revisions for .git-blame-ignore-revs need to be full

dweiss opened a new pull request #2167: URL: https://github.com/apache/lucene-solr/pull/2167 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [lucene-solr] dweiss merged pull request #2167: LUCENE-9643: git revisions for .git-blame-ignore-revs need to be full

dweiss merged pull request #2167: URL: https://github.com/apache/lucene-solr/pull/2167 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (LUCENE-9643) Create .git-blame-ignore-revs file with revisions that only apply reformatting

[ https://issues.apache.org/jira/browse/LUCENE-9643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254293#comment-17254293 ] ASF subversion and git services commented on LUCENE-9643: - Commi

[jira] [Commented] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied

[ https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254295#comment-17254295 ] Dawid Weiss commented on LUCENE-9570: - Seems like those refs need to be complete sha

[GitHub] [lucene-solr] dweiss commented on pull request #2163: LUCENE-9647 Add back github action for Ant

dweiss commented on pull request #2163: URL: https://github.com/apache/lucene-solr/pull/2163#issuecomment-750516702 bq. It needs to be in the default branch. Oh, ok. So it needs to be on the default branch even if it applies only to a filtered set of branches? Get it.

[jira] [Updated] (SOLR-15048) collapse + query elevation behaves inconsistenty w/ 'null group' docs depending on group head selector

[ https://issues.apache.org/jira/browse/SOLR-15048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-15048: -- Attachment: SOLR-15048.patch Status: Open (was: Open) There are twe distinct b

[jira] [Commented] (SOLR-14923) Indexing performance is unacceptable when child documents are involved

[ https://issues.apache.org/jira/browse/SOLR-14923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254315#comment-17254315 ] David Smiley commented on SOLR-14923: - Today I made further modifications to NestedSh

[jira] [Updated] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied

[ https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated LUCENE-9570: --- Description: Review and correct all the javadocs before they're messed up by automatic form

[jira] [Commented] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied

[ https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254382#comment-17254382 ] Erick Erickson commented on LUCENE-9570: [~dweiss] I've run tidy, checked the di

  1   2   >