thelabdude commented on a change in pull request #2165:
URL: https://github.com/apache/lucene-solr/pull/2165#discussion_r548126909
##########
File path:
solr/contrib/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/MetricsConfiguration.java
##########
@@ -105,17 +108,23 @@ public static MetricsConfiguration from(String resource)
throws Exception {
public static MetricsConfiguration from(Document config) throws Exception {
Node settings = getNode(config, "/config/settings");
+ Map<String,MetricsQueryTemplate> jqTemplatesMap = null;
+ NodeList jqTemplates =
(NodeList)(xpathFactory.newXPath()).evaluate("/config/jq-templates/template",
config, XPathConstants.NODESET);
Review comment:
The code is already using XPath, I'm not introducing it here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
