murblanc commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r547948300
########## File path: solr/core/src/java/org/apache/solr/cluster/placement/impl/MetricAttributeImpl.java ########## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.cluster.placement.impl; + +import org.apache.solr.cluster.placement.MetricAttribute; + +import java.util.Objects; +import java.util.function.Function; + +/** + * Base class for {@link MetricAttribute} implementations. + */ +public class MetricAttributeImpl<T> implements MetricAttribute<T> { + + public static final double GB = 1024 * 1024 * 1024; + + /** + * Identity converter. It returns the raw value unchanged IFF + * the value's type can be cast to the generic type of this attribute, + * otherwise it returns null. + */ + @SuppressWarnings("unchecked") + public final Function<Object, T> IDENTITY_CONVERTER = v -> { + try { + return (T) v; + } catch (ClassCastException cce) { + return null; + } + }; + + /** + * Bytes to gigabytes converter. Supports converting number or string + * representations of raw values expressed in bytes. + */ + @SuppressWarnings("unchecked") + public static final Function<Object, Double> BYTES_TO_GB_CONVERTER = v -> { + double sizeInBytes; + if (!(v instanceof Number)) { + if (v == null) { + return null; + } + try { + sizeInBytes = Double.valueOf(String.valueOf(v)).doubleValue(); Review comment: `Double.parseDouble(String.valueOf(v))` does the job. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
