[GitHub] [lucene-solr] noblepaul removed a comment on pull request #1679: SOLR-14656: Removing autoscaling from master

2020-07-19 Thread GitBox
noblepaul removed a comment on pull request #1679: URL: https://github.com/apache/lucene-solr/pull/1679#issuecomment-660597516 LGTM This is an automated message from the Apache Git Service. To respond to the message, please l

[jira] [Created] (SOLR-14668) CompositeID change provokes duplicates

2020-07-19 Thread Alexander S. (Jira)
Alexander S. created SOLR-14668: --- Summary: CompositeID change provokes duplicates Key: SOLR-14668 URL: https://issues.apache.org/jira/browse/SOLR-14668 Project: Solr Issue Type: Bug Secur

[jira] [Commented] (LUCENE-9433) Remove Ant support from trunk

2020-07-19 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160616#comment-17160616 ] Dawid Weiss commented on LUCENE-9433: - bq. "CustomizedAsciidoctorAntTask.java" mostl

[jira] [Updated] (SOLR-14583) Spell suggestion is returned even if hits are non-zero when spellcheck.maxResultsForSuggest=0

2020-07-19 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Munendra S N updated SOLR-14583: Attachment: SOLR-14583.patch > Spell suggestion is returned even if hits are non-zero when > spell

[jira] [Commented] (SOLR-14583) Spell suggestion is returned even if hits are non-zero when spellcheck.maxResultsForSuggest=0

2020-07-19 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160631#comment-17160631 ] Munendra S N commented on SOLR-14583: - [^SOLR-14583.patch] [~jdyer] I was testing

[jira] [Commented] (LUCENE-9433) Remove Ant support from trunk

2020-07-19 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160634#comment-17160634 ] Robert Muir commented on LUCENE-9433: - The other thing i'm still using is {{ant ecli

[jira] [Updated] (SOLR-14516) NPE during Realtime GET

2020-07-19 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Munendra S N updated SOLR-14516: Attachment: SOLR-14516.patch > NPE during Realtime GET > --- > >

[jira] [Commented] (SOLR-14516) NPE during Realtime GET

2020-07-19 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160635#comment-17160635 ] Munendra S N commented on SOLR-14516: - [^SOLR-14516.patch] I have added the javadoc

[jira] [Commented] (LUCENE-9433) Remove Ant support from trunk

2020-07-19 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160636#comment-17160636 ] Robert Muir commented on LUCENE-9433: - Maybe, the best solution is so simply port {{

[jira] [Updated] (LUCENE-9433) Remove Ant support from trunk

2020-07-19 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated LUCENE-9433: --- Description: Items that may need to be addressed: * Testing with OpenJDK early access relea

[jira] [Created] (LUCENE-9435) Clean up ant compatability remnants in Gradle build

2020-07-19 Thread Erick Erickson (Jira)
Erick Erickson created LUCENE-9435: -- Summary: Clean up ant compatability remnants in Gradle build Key: LUCENE-9435 URL: https://issues.apache.org/jira/browse/LUCENE-9435 Project: Lucene - Core

[jira] [Commented] (LUCENE-9433) Remove Ant support from trunk

2020-07-19 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160639#comment-17160639 ] Uwe Schindler commented on LUCENE-9433: --- Hi Erick: As said before. Please don't pu

[jira] [Comment Edited] (LUCENE-9433) Remove Ant support from trunk

2020-07-19 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160639#comment-17160639 ] Uwe Schindler edited comment on LUCENE-9433 at 7/19/20, 11:30 AM:

[jira] [Comment Edited] (LUCENE-9433) Remove Ant support from trunk

2020-07-19 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160639#comment-17160639 ] Uwe Schindler edited comment on LUCENE-9433 at 7/19/20, 11:31 AM:

[jira] [Commented] (SOLR-11262) XML writer does not implement PushWriter

2020-07-19 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160640#comment-17160640 ] Munendra S N commented on SOLR-11262: - [~dsmiley] I think to modify the changes entry

[jira] [Comment Edited] (LUCENE-9433) Remove Ant support from trunk

2020-07-19 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160639#comment-17160639 ] Uwe Schindler edited comment on LUCENE-9433 at 7/19/20, 11:32 AM:

[jira] [Commented] (LUCENE-9433) Remove Ant support from trunk

2020-07-19 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160642#comment-17160642 ] Uwe Schindler commented on LUCENE-9433: --- [~rcmuir]: I fully agree. Eclipse does no

[jira] [Updated] (LUCENE-9433) Remove Ant support from trunk

2020-07-19 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated LUCENE-9433: --- Description: Items that may need to be addressed: * Testing with OpenJDK early access relea

[jira] [Comment Edited] (LUCENE-9433) Remove Ant support from trunk

2020-07-19 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160642#comment-17160642 ] Uwe Schindler edited comment on LUCENE-9433 at 7/19/20, 11:37 AM:

[jira] [Comment Edited] (LUCENE-9433) Remove Ant support from trunk

2020-07-19 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160642#comment-17160642 ] Uwe Schindler edited comment on LUCENE-9433 at 7/19/20, 11:38 AM:

[jira] [Commented] (LUCENE-9433) Remove Ant support from trunk

2020-07-19 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160648#comment-17160648 ] Dawid Weiss commented on LUCENE-9433: - Can you provide a patch that would help make

[jira] [Commented] (LUCENE-9433) Remove Ant support from trunk

2020-07-19 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160649#comment-17160649 ] Erick Erickson commented on LUCENE-9433: I don't intend to push this until the b

[jira] [Commented] (SOLR-14668) CompositeID change provokes duplicates

2020-07-19 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160655#comment-17160655 ] Erick Erickson commented on SOLR-14668: --- How do you propose that would be done? How

[jira] [Commented] (LUCENE-9433) Remove Ant support from trunk

2020-07-19 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160665#comment-17160665 ] Uwe Schindler commented on LUCENE-9433: --- Hi both, Sorry for the misunderstanding.

[jira] [Commented] (SOLR-14668) CompositeID change provokes duplicates

2020-07-19 Thread Alexander S. (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160668#comment-17160668 ] Alexander S. commented on SOLR-14668: - Well, the ID doesn't change, changes only the

[jira] [Commented] (LUCENE-9433) Remove Ant support from trunk

2020-07-19 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160670#comment-17160670 ] Robert Muir commented on LUCENE-9433: - Also, before removing ant, the various docume

[jira] [Commented] (LUCENE-9312) Allow builds against arbitrary JVMs (even those unsupported by gradle)

2020-07-19 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160683#comment-17160683 ] Tomoko Uchida commented on LUCENE-9312: --- I finally found the previous github threa

[jira] [Commented] (LUCENE-9433) Remove Ant support from trunk

2020-07-19 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160688#comment-17160688 ] Tomoko Uchida commented on LUCENE-9433: --- As a reminder, we need to fix some relati

[jira] [Commented] (SOLR-11262) XML writer does not implement PushWriter

2020-07-19 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160720#comment-17160720 ] David Smiley commented on SOLR-11262: - Your proposed CHANGES.txt message is definitel

[jira] [Updated] (LUCENE-9433) Remove Ant support from trunk

2020-07-19 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated LUCENE-9433: --- Description: Items that may need to be addressed: * Testing with OpenJDK early access relea

[jira] [Updated] (LUCENE-9433) Remove Ant support from trunk

2020-07-19 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated LUCENE-9433: --- Description: Items that may need to be addressed: * Testing with OpenJDK early access relea

[jira] [Commented] (SOLR-14583) Spell suggestion is returned even if hits are non-zero when spellcheck.maxResultsForSuggest=0

2020-07-19 Thread Lucene/Solr QA (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160785#comment-17160785 ] Lucene/Solr QA commented on SOLR-14583: --- | (x) *{color:red}-1 overall{color}* | \\

[jira] [Commented] (SOLR-14516) NPE during Realtime GET

2020-07-19 Thread Lucene/Solr QA (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160799#comment-17160799 ] Lucene/Solr QA commented on SOLR-14516: --- | (/) *{color:green}+1 overall{color}* | \

[jira] [Assigned] (LUCENE-9435) Clean up ant compatability remnants in Gradle build

2020-07-19 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss reassigned LUCENE-9435: --- Assignee: Dawid Weiss (was: Erick Erickson) > Clean up ant compatability remnants in Gradl

[jira] [Commented] (LUCENE-9312) Allow builds against arbitrary JVMs (even those unsupported by gradle)

2020-07-19 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160817#comment-17160817 ] Dawid Weiss commented on LUCENE-9312: - Exactly, thanks for looking it up, Tomoko. >

[jira] [Commented] (LUCENE-7672) CachingNaiveBayesClassifier doesn't compute log prior.

2020-07-19 Thread Kevin Crosby (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-7672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160821#comment-17160821 ] Kevin Crosby commented on LUCENE-7672: -- Note that my patch repository was renamed t

[jira] [Commented] (SOLR-14636) Provide a reference implementation for SolrCloud that is stable and fast.

2020-07-19 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160823#comment-17160823 ] Jan Høydahl commented on SOLR-14636: Thanks for once again tackling all of this Mark,

[jira] [Updated] (SOLR-11656) TLOG replication doesn't work properly after rebalancing leaders.

2020-07-19 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated SOLR-11656: -- Attachment: SOLR-11656.patch > TLOG replication doesn't work properly after rebalancing leaders

[jira] [Commented] (SOLR-11656) TLOG replication doesn't work properly after rebalancing leaders.

2020-07-19 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160825#comment-17160825 ] Erick Erickson commented on SOLR-11656: --- [~tflobbe] Any comments? The fix is a smal

[jira] [Commented] (SOLR-14630) CloudSolrClient doesn't pick correct core when server contains more shards

2020-07-19 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160863#comment-17160863 ] David Smiley commented on SOLR-14630: - While I appreciate your code level diagnosis,

[jira] [Commented] (SOLR-14636) Provide a reference implementation for SolrCloud that is stable and fast.

2020-07-19 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160881#comment-17160881 ] Mark Robert Miller commented on SOLR-14636: --- I am def surprised how things are

[jira] [Commented] (SOLR-14638) Edismax boost function zero score

2020-07-19 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160892#comment-17160892 ] David Smiley commented on SOLR-14638: - There might be a problem; I'm not sure.  The f

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1678: SOLR-14613: Initial POC based on Ilan's proposal.

2020-07-19 Thread GitBox
noblepaul commented on a change in pull request #1678: URL: https://github.com/apache/lucene-solr/pull/1678#discussion_r457099407 ## File path: solr/core/src/java/org/apache/solr/cloud/api/collections/assign/AssignerNodeState.java ## @@ -0,0 +1,35 @@ +/* + * Licensed to the Ap

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1678: SOLR-14613: Initial POC based on Ilan's proposal.

2020-07-19 Thread GitBox
noblepaul commented on a change in pull request #1678: URL: https://github.com/apache/lucene-solr/pull/1678#discussion_r457099762 ## File path: solr/core/src/java/org/apache/solr/cloud/api/collections/assign/AssignerShardState.java ## @@ -0,0 +1,31 @@ +/* + * Licensed to the A

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1678: SOLR-14613: Initial POC based on Ilan's proposal.

2020-07-19 Thread GitBox
noblepaul commented on a change in pull request #1678: URL: https://github.com/apache/lucene-solr/pull/1678#discussion_r457100953 ## File path: solr/core/src/java/org/apache/solr/cloud/api/collections/assign/ReplicaType.java ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache S

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1678: SOLR-14613: Initial POC based on Ilan's proposal.

2020-07-19 Thread GitBox
noblepaul commented on a change in pull request #1678: URL: https://github.com/apache/lucene-solr/pull/1678#discussion_r457100735 ## File path: solr/core/src/java/org/apache/solr/cloud/api/collections/assign/ReplicaState.java ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache