noblepaul removed a comment on pull request #1679:
URL: https://github.com/apache/lucene-solr/pull/1679#issuecomment-660597516
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please l
Alexander S. created SOLR-14668:
---
Summary: CompositeID change provokes duplicates
Key: SOLR-14668
URL: https://issues.apache.org/jira/browse/SOLR-14668
Project: Solr
Issue Type: Bug
Secur
[
https://issues.apache.org/jira/browse/LUCENE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160616#comment-17160616
]
Dawid Weiss commented on LUCENE-9433:
-
bq. "CustomizedAsciidoctorAntTask.java" mostl
[
https://issues.apache.org/jira/browse/SOLR-14583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Munendra S N updated SOLR-14583:
Attachment: SOLR-14583.patch
> Spell suggestion is returned even if hits are non-zero when
> spell
[
https://issues.apache.org/jira/browse/SOLR-14583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160631#comment-17160631
]
Munendra S N commented on SOLR-14583:
-
[^SOLR-14583.patch]
[~jdyer]
I was testing
[
https://issues.apache.org/jira/browse/LUCENE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160634#comment-17160634
]
Robert Muir commented on LUCENE-9433:
-
The other thing i'm still using is {{ant ecli
[
https://issues.apache.org/jira/browse/SOLR-14516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Munendra S N updated SOLR-14516:
Attachment: SOLR-14516.patch
> NPE during Realtime GET
> ---
>
>
[
https://issues.apache.org/jira/browse/SOLR-14516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160635#comment-17160635
]
Munendra S N commented on SOLR-14516:
-
[^SOLR-14516.patch]
I have added the javadoc
[
https://issues.apache.org/jira/browse/LUCENE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160636#comment-17160636
]
Robert Muir commented on LUCENE-9433:
-
Maybe, the best solution is so simply port {{
[
https://issues.apache.org/jira/browse/LUCENE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson updated LUCENE-9433:
---
Description:
Items that may need to be addressed:
* Testing with OpenJDK early access relea
Erick Erickson created LUCENE-9435:
--
Summary: Clean up ant compatability remnants in Gradle build
Key: LUCENE-9435
URL: https://issues.apache.org/jira/browse/LUCENE-9435
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160639#comment-17160639
]
Uwe Schindler commented on LUCENE-9433:
---
Hi Erick: As said before. Please don't pu
[
https://issues.apache.org/jira/browse/LUCENE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160639#comment-17160639
]
Uwe Schindler edited comment on LUCENE-9433 at 7/19/20, 11:30 AM:
[
https://issues.apache.org/jira/browse/LUCENE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160639#comment-17160639
]
Uwe Schindler edited comment on LUCENE-9433 at 7/19/20, 11:31 AM:
[
https://issues.apache.org/jira/browse/SOLR-11262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160640#comment-17160640
]
Munendra S N commented on SOLR-11262:
-
[~dsmiley]
I think to modify the changes entry
[
https://issues.apache.org/jira/browse/LUCENE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160639#comment-17160639
]
Uwe Schindler edited comment on LUCENE-9433 at 7/19/20, 11:32 AM:
[
https://issues.apache.org/jira/browse/LUCENE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160642#comment-17160642
]
Uwe Schindler commented on LUCENE-9433:
---
[~rcmuir]: I fully agree. Eclipse does no
[
https://issues.apache.org/jira/browse/LUCENE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson updated LUCENE-9433:
---
Description:
Items that may need to be addressed:
* Testing with OpenJDK early access relea
[
https://issues.apache.org/jira/browse/LUCENE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160642#comment-17160642
]
Uwe Schindler edited comment on LUCENE-9433 at 7/19/20, 11:37 AM:
[
https://issues.apache.org/jira/browse/LUCENE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160642#comment-17160642
]
Uwe Schindler edited comment on LUCENE-9433 at 7/19/20, 11:38 AM:
[
https://issues.apache.org/jira/browse/LUCENE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160648#comment-17160648
]
Dawid Weiss commented on LUCENE-9433:
-
Can you provide a patch that would help make
[
https://issues.apache.org/jira/browse/LUCENE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160649#comment-17160649
]
Erick Erickson commented on LUCENE-9433:
I don't intend to push this until the b
[
https://issues.apache.org/jira/browse/SOLR-14668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160655#comment-17160655
]
Erick Erickson commented on SOLR-14668:
---
How do you propose that would be done? How
[
https://issues.apache.org/jira/browse/LUCENE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160665#comment-17160665
]
Uwe Schindler commented on LUCENE-9433:
---
Hi both,
Sorry for the misunderstanding.
[
https://issues.apache.org/jira/browse/SOLR-14668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160668#comment-17160668
]
Alexander S. commented on SOLR-14668:
-
Well, the ID doesn't change, changes only the
[
https://issues.apache.org/jira/browse/LUCENE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160670#comment-17160670
]
Robert Muir commented on LUCENE-9433:
-
Also, before removing ant, the various docume
[
https://issues.apache.org/jira/browse/LUCENE-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160683#comment-17160683
]
Tomoko Uchida commented on LUCENE-9312:
---
I finally found the previous github threa
[
https://issues.apache.org/jira/browse/LUCENE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160688#comment-17160688
]
Tomoko Uchida commented on LUCENE-9433:
---
As a reminder, we need to fix some relati
[
https://issues.apache.org/jira/browse/SOLR-11262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160720#comment-17160720
]
David Smiley commented on SOLR-11262:
-
Your proposed CHANGES.txt message is definitel
[
https://issues.apache.org/jira/browse/LUCENE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson updated LUCENE-9433:
---
Description:
Items that may need to be addressed:
* Testing with OpenJDK early access relea
[
https://issues.apache.org/jira/browse/LUCENE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson updated LUCENE-9433:
---
Description:
Items that may need to be addressed:
* Testing with OpenJDK early access relea
[
https://issues.apache.org/jira/browse/SOLR-14583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160785#comment-17160785
]
Lucene/Solr QA commented on SOLR-14583:
---
| (x) *{color:red}-1 overall{color}* |
\\
[
https://issues.apache.org/jira/browse/SOLR-14516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160799#comment-17160799
]
Lucene/Solr QA commented on SOLR-14516:
---
| (/) *{color:green}+1 overall{color}* |
\
[
https://issues.apache.org/jira/browse/LUCENE-9435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss reassigned LUCENE-9435:
---
Assignee: Dawid Weiss (was: Erick Erickson)
> Clean up ant compatability remnants in Gradl
[
https://issues.apache.org/jira/browse/LUCENE-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160817#comment-17160817
]
Dawid Weiss commented on LUCENE-9312:
-
Exactly, thanks for looking it up, Tomoko.
>
[
https://issues.apache.org/jira/browse/LUCENE-7672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160821#comment-17160821
]
Kevin Crosby commented on LUCENE-7672:
--
Note that my patch repository was renamed t
[
https://issues.apache.org/jira/browse/SOLR-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160823#comment-17160823
]
Jan Høydahl commented on SOLR-14636:
Thanks for once again tackling all of this Mark,
[
https://issues.apache.org/jira/browse/SOLR-11656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson updated SOLR-11656:
--
Attachment: SOLR-11656.patch
> TLOG replication doesn't work properly after rebalancing leaders
[
https://issues.apache.org/jira/browse/SOLR-11656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160825#comment-17160825
]
Erick Erickson commented on SOLR-11656:
---
[~tflobbe] Any comments? The fix is a smal
[
https://issues.apache.org/jira/browse/SOLR-14630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160863#comment-17160863
]
David Smiley commented on SOLR-14630:
-
While I appreciate your code level diagnosis,
[
https://issues.apache.org/jira/browse/SOLR-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160881#comment-17160881
]
Mark Robert Miller commented on SOLR-14636:
---
I am def surprised how things are
[
https://issues.apache.org/jira/browse/SOLR-14638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160892#comment-17160892
]
David Smiley commented on SOLR-14638:
-
There might be a problem; I'm not sure. The f
noblepaul commented on a change in pull request #1678:
URL: https://github.com/apache/lucene-solr/pull/1678#discussion_r457099407
##
File path:
solr/core/src/java/org/apache/solr/cloud/api/collections/assign/AssignerNodeState.java
##
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Ap
noblepaul commented on a change in pull request #1678:
URL: https://github.com/apache/lucene-solr/pull/1678#discussion_r457099762
##
File path:
solr/core/src/java/org/apache/solr/cloud/api/collections/assign/AssignerShardState.java
##
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the A
noblepaul commented on a change in pull request #1678:
URL: https://github.com/apache/lucene-solr/pull/1678#discussion_r457100953
##
File path:
solr/core/src/java/org/apache/solr/cloud/api/collections/assign/ReplicaType.java
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache S
noblepaul commented on a change in pull request #1678:
URL: https://github.com/apache/lucene-solr/pull/1678#discussion_r457100735
##
File path:
solr/core/src/java/org/apache/solr/cloud/api/collections/assign/ReplicaState.java
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache
46 matches
Mail list logo