[GitHub] [lucene-solr] romseygeek commented on a change in pull request #1467: LUCENE-9350: Don't hold references to large automata on FuzzyQuery

2020-04-30 Thread GitBox
romseygeek commented on a change in pull request #1467: URL: https://github.com/apache/lucene-solr/pull/1467#discussion_r417810173 ## File path: lucene/core/src/java/org/apache/lucene/search/FuzzyAutomatonBuilder.java ## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-04-30 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17096267#comment-17096267 ] Dawid Weiss commented on LUCENE-9321: - Remember you should be celebrating the intern

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-04-30 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17096270#comment-17096270 ] Tomoko Uchida commented on LUCENE-9321: --- To my limited knowledge about perl, the D

[GitHub] [lucene-solr] mocobeta commented on pull request #1468: LUCENE-9333: Add gradle task to compile changes.txt to a html

2020-04-30 Thread GitBox
mocobeta commented on pull request #1468: URL: https://github.com/apache/lucene-solr/pull/1468#issuecomment-621684273 Thanks, I will merge it to upstream soon. This is an automated message from the Apache Git Service. To resp

[jira] [Commented] (LUCENE-9333) Gradle task equivalent to ant's "change-to-html"

2020-04-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17096300#comment-17096300 ] ASF subversion and git services commented on LUCENE-9333: - Commi

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-04-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17096303#comment-17096303 ] ASF subversion and git services commented on LUCENE-9278: - Commi

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-04-30 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17096304#comment-17096304 ] Tomoko Uchida commented on LUCENE-9321: --- I merged the branch to the master. Thanks

[jira] [Resolved] (LUCENE-9333) Gradle task equivalent to ant's "change-to-html"

2020-04-30 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida resolved LUCENE-9333. --- Fix Version/s: master (9.0) Resolution: Fixed > Gradle task equivalent to ant's "chan

[jira] [Commented] (SOLR-14354) Async or using threads in better way for HttpShardHandler

2020-04-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17096333#comment-17096333 ] ASF subversion and git services commented on SOLR-14354: Commit 4

[jira] [Commented] (SOLR-14354) Async or using threads in better way for HttpShardHandler

2020-04-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17096334#comment-17096334 ] ASF subversion and git services commented on SOLR-14354: Commit 7

[jira] [Commented] (SOLR-14354) Async or using threads in better way for HttpShardHandler

2020-04-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17096335#comment-17096335 ] ASF subversion and git services commented on SOLR-14354: Commit 7

[GitHub] [lucene-solr] CaoManhDat opened a new pull request #1470: SOLR-14354: Async or using threads in better way for HttpShardHandler

2020-04-30 Thread GitBox
CaoManhDat opened a new pull request #1470: URL: https://github.com/apache/lucene-solr/pull/1470 # Description Sending request in an async way inside HttpShardHandler This is an automated message from the Apache Git Servic

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1464: LUCENE-9087: Build always trees with full leaves and lower the default value for maxPointsPerLeafNode

2020-04-30 Thread GitBox
jpountz commented on a change in pull request #1464: URL: https://github.com/apache/lucene-solr/pull/1464#discussion_r417888402 ## File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java ## @@ -730,6 +730,22 @@ private void rotateToTree(int nodeID, int offset,

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-04-30 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17096397#comment-17096397 ] Uwe Schindler commented on LUCENE-9321: --- bq. I don't see any Jira access on the cu

[jira] [Comment Edited] (LUCENE-9321) Port documentation task to gradle

2020-04-30 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17096397#comment-17096397 ] Uwe Schindler edited comment on LUCENE-9321 at 4/30/20, 10:18 AM:

[GitHub] [lucene-solr] iverase commented on a change in pull request #1464: LUCENE-9087: Build always trees with full leaves and lower the default value for maxPointsPerLeafNode

2020-04-30 Thread GitBox
iverase commented on a change in pull request #1464: URL: https://github.com/apache/lucene-solr/pull/1464#discussion_r417917762 ## File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java ## @@ -730,6 +730,22 @@ private void rotateToTree(int nodeID, int offset,

[GitHub] [lucene-solr] iverase commented on a change in pull request #1464: LUCENE-9087: Build always trees with full leaves and lower the default value for maxPointsPerLeafNode

2020-04-30 Thread GitBox
iverase commented on a change in pull request #1464: URL: https://github.com/apache/lucene-solr/pull/1464#discussion_r417917762 ## File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java ## @@ -730,6 +730,22 @@ private void rotateToTree(int nodeID, int offset,

[jira] [Created] (SOLR-14449) Two reproducing failures hdfs tests, CheckHdfsIndexTest and StressHdfsTest

2020-04-30 Thread Erick Erickson (Jira)
Erick Erickson created SOLR-14449: - Summary: Two reproducing failures hdfs tests, CheckHdfsIndexTest and StressHdfsTest Key: SOLR-14449 URL: https://issues.apache.org/jira/browse/SOLR-14449 Project: S

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1464: LUCENE-9087: Build always trees with full leaves and lower the default value for maxPointsPerLeafNode

2020-04-30 Thread GitBox
jpountz commented on a change in pull request #1464: URL: https://github.com/apache/lucene-solr/pull/1464#discussion_r417948820 ## File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java ## @@ -730,6 +730,22 @@ private void rotateToTree(int nodeID, int offset,

[jira] [Assigned] (SOLR-14409) Existing violations allow bypassing policy rules when adding new replicas

2020-04-30 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul reassigned SOLR-14409: - Assignee: Noble Paul (was: Andrzej Bialecki) > Existing violations allow bypassing policy rules

[jira] [Commented] (SOLR-14409) Existing violations allow bypassing policy rules when adding new replicas

2020-04-30 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17096457#comment-17096457 ] Noble Paul commented on SOLR-14409: --- I'll fix this soon > Existing violations allow by

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1464: LUCENE-9087: Build always trees with full leaves and lower the default value for maxPointsPerLeafNode

2020-04-30 Thread GitBox
jpountz commented on a change in pull request #1464: URL: https://github.com/apache/lucene-solr/pull/1464#discussion_r417953430 ## File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java ## @@ -420,16 +421,13 @@ private long writeFieldNDims(IndexOutput out, St

[GitHub] [lucene-solr] iverase commented on a change in pull request #1464: LUCENE-9087: Build always trees with full leaves and lower the default value for maxPointsPerLeafNode

2020-04-30 Thread GitBox
iverase commented on a change in pull request #1464: URL: https://github.com/apache/lucene-solr/pull/1464#discussion_r418033004 ## File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java ## @@ -420,16 +421,13 @@ private long writeFieldNDims(IndexOutput out, St

[GitHub] [lucene-solr] iverase commented on a change in pull request #1464: LUCENE-9087: Build always trees with full leaves and lower the default value for maxPointsPerLeafNode

2020-04-30 Thread GitBox
iverase commented on a change in pull request #1464: URL: https://github.com/apache/lucene-solr/pull/1464#discussion_r418033425 ## File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java ## @@ -665,55 +663,45 @@ assert valuesInOrderAndBounds(leafCount, 0, Arr

[GitHub] [lucene-solr] iverase commented on a change in pull request #1464: LUCENE-9087: Build always trees with full leaves and lower the default value for maxPointsPerLeafNode

2020-04-30 Thread GitBox
iverase commented on a change in pull request #1464: URL: https://github.com/apache/lucene-solr/pull/1464#discussion_r418033875 ## File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java ## @@ -822,39 +804,27 @@ public long finish(IndexOutput out) throws IOExc

[jira] [Created] (SOLR-14450) SegmentsInfoRequestHandler doesn't properly close ref-counted IW

2020-04-30 Thread Andrzej Bialecki (Jira)
Andrzej Bialecki created SOLR-14450: --- Summary: SegmentsInfoRequestHandler doesn't properly close ref-counted IW Key: SOLR-14450 URL: https://issues.apache.org/jira/browse/SOLR-14450 Project: Solr

[jira] [Commented] (SOLR-14450) SegmentsInfoRequestHandler doesn't properly close ref-counted IW

2020-04-30 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17096635#comment-17096635 ] Andrzej Bialecki commented on SOLR-14450: - Indeed, this iwRef should be called re

[jira] [Commented] (SOLR-14237) Add authenticated user principal in Solr admin UI

2020-04-30 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17096647#comment-17096647 ] Mike Drob commented on SOLR-14237: -- I think this is causing failures on Jenkins - https

[jira] [Commented] (LUCENE-7788) fail precommit on unparameterised log messages and examine for wasted work/objects

2020-04-30 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17096654#comment-17096654 ] Mike Drob commented on LUCENE-7788: --- [~erickerickson] - I think you broke some logging

[jira] [Commented] (SOLR-14237) Add authenticated user principal in Solr admin UI

2020-04-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17096656#comment-17096656 ] ASF subversion and git services commented on SOLR-14237: Commit 9

[jira] [Commented] (SOLR-14237) Add authenticated user principal in Solr admin UI

2020-04-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17096658#comment-17096658 ] ASF subversion and git services commented on SOLR-14237: Commit 5

[jira] [Commented] (SOLR-14237) Add authenticated user principal in Solr admin UI

2020-04-30 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17096661#comment-17096661 ] Ishan Chattopadhyaya commented on SOLR-14237: - Thanks [~mdrob], fixed. I hadn

[GitHub] [lucene-solr] madrob commented on a change in pull request #1467: LUCENE-9350: Don't hold references to large automata on FuzzyQuery

2020-04-30 Thread GitBox
madrob commented on a change in pull request #1467: URL: https://github.com/apache/lucene-solr/pull/1467#discussion_r418113621 ## File path: lucene/core/src/java/org/apache/lucene/search/FuzzyQuery.java ## @@ -183,7 +162,7 @@ public void visit(QueryVisitor visitor) { if

[jira] [Commented] (LUCENE-7788) fail precommit on unparameterised log messages and examine for wasted work/objects

2020-04-30 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17096703#comment-17096703 ] Erick Erickson commented on LUCENE-7788: Thanks, I see what happened, I'll fix i

[GitHub] [lucene-solr] madrob commented on a change in pull request #1467: LUCENE-9350: Don't hold references to large automata on FuzzyQuery

2020-04-30 Thread GitBox
madrob commented on a change in pull request #1467: URL: https://github.com/apache/lucene-solr/pull/1467#discussion_r418121317 ## File path: lucene/core/src/java/org/apache/lucene/search/FuzzyTermsEnum.java ## @@ -88,43 +89,44 @@ * @throws IOException if there is a low-leve

[jira] [Commented] (SOLR-14449) Two reproducing failures hdfs tests, CheckHdfsIndexTest and StressHdfsTest

2020-04-30 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17096779#comment-17096779 ] Kevin Risden commented on SOLR-14449: - [~erickerickson] not sure if this is fixed by

[jira] [Resolved] (SOLR-14449) Two reproducing failures hdfs tests, CheckHdfsIndexTest and StressHdfsTest

2020-04-30 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson resolved SOLR-14449. --- Fix Version/s: 8.6 Resolution: Fixed 3/3 failures before updating after the latest pus

[GitHub] [lucene-solr] madrob commented on a change in pull request #1470: SOLR-14354: Async or using threads in better way for HttpShardHandler

2020-04-30 Thread GitBox
madrob commented on a change in pull request #1470: URL: https://github.com/apache/lucene-solr/pull/1470#discussion_r418163481 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBSolrClient.java ## @@ -136,6 +137,91 @@ public boolean equals(Object obj) {

[GitHub] [lucene-solr] MarcusSorealheis commented on a change in pull request #1391: SOLR-14014 Add a disable Admin UI Flag

2020-04-30 Thread GitBox
MarcusSorealheis commented on a change in pull request #1391: URL: https://github.com/apache/lucene-solr/pull/1391#discussion_r418302531 ## File path: solr/core/src/java/org/apache/solr/servlet/LoadAdminUiServlet.java ## @@ -24,6 +24,7 @@ import org.apache.solr.core.CoreContai

[GitHub] [lucene-solr] MarcusSorealheis commented on a change in pull request #1391: SOLR-14014 Add a disable Admin UI Flag

2020-04-30 Thread GitBox
MarcusSorealheis commented on a change in pull request #1391: URL: https://github.com/apache/lucene-solr/pull/1391#discussion_r418302240 ## File path: solr/core/src/java/org/apache/solr/servlet/LoadAdminUiServlet.java ## @@ -24,6 +24,7 @@ import org.apache.solr.core.CoreContai

[jira] [Created] (LUCENE-9353) Move metadata of the terms dictionary to its own file

2020-04-30 Thread Adrien Grand (Jira)
Adrien Grand created LUCENE-9353: Summary: Move metadata of the terms dictionary to its own file Key: LUCENE-9353 URL: https://issues.apache.org/jira/browse/LUCENE-9353 Project: Lucene - Core

[jira] [Commented] (LUCENE-9331) TestIndexWriterDelete.testDeletesOnDiskFull can run for minutes

2020-04-30 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097007#comment-17097007 ] Michael McCandless commented on LUCENE-9331: [~jpountz] that fix looks fine

[GitHub] [lucene-solr] MarcusSorealheis opened a new pull request #1471: Revised SOLR-14014 PR Against Master

2020-04-30 Thread GitBox
MarcusSorealheis opened a new pull request #1471: URL: https://github.com/apache/lucene-solr/pull/1471 # Description I added a system property to allow users to disable the Solr Admin UI on start. # Solution I added this property, which accepts a boolean val

[GitHub] [lucene-solr] MarcusSorealheis commented on pull request #1471: Revised SOLR-14014 PR Against Master

2020-04-30 Thread GitBox
MarcusSorealheis commented on pull request #1471: URL: https://github.com/apache/lucene-solr/pull/1471#issuecomment-622140309 @madrob and @gerlowskija I made a new PR and merged master, but it looks like another typo fix on my local made it in there, which is fine because it should be ther

[jira] [Commented] (LUCENE-7788) fail precommit on unparameterised log messages and examine for wasted work/objects

2020-04-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097065#comment-17097065 ] ASF subversion and git services commented on LUCENE-7788: - Commi

[jira] [Commented] (LUCENE-7788) fail precommit on unparameterised log messages and examine for wasted work/objects

2020-04-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097067#comment-17097067 ] ASF subversion and git services commented on LUCENE-7788: - Commi

[jira] [Created] (SOLR-14451) debug=query does not reliably ensure json.facet debug info returned in cloud clusters

2020-04-30 Thread Chris M. Hostetter (Jira)
Chris M. Hostetter created SOLR-14451: - Summary: debug=query does not reliably ensure json.facet debug info returned in cloud clusters Key: SOLR-14451 URL: https://issues.apache.org/jira/browse/SOLR-14451

[jira] [Commented] (SOLR-14451) debug=query does not reliably ensure json.facet debug info returned in cloud clusters

2020-04-30 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097068#comment-17097068 ] Chris M. Hostetter commented on SOLR-14451: --- NOTE: I'm not actively investigati

[jira] [Created] (SOLR-14452) "classloading deadlock" issue with DocSet/SortedIntDocSet

2020-04-30 Thread Chris M. Hostetter (Jira)
Chris M. Hostetter created SOLR-14452: - Summary: "classloading deadlock" issue with DocSet/SortedIntDocSet Key: SOLR-14452 URL: https://issues.apache.org/jira/browse/SOLR-14452 Project: Solr

[GitHub] [lucene-solr] mrsoong opened a new pull request #1472: SOLR-13184: Added some input validation in ValueSourceParser

2020-04-30 Thread GitBox
mrsoong opened a new pull request #1472: URL: https://github.com/apache/lucene-solr/pull/1472 # Description The joindf parser inside ValueSourceParser did not check for null qfield values before calling JoinDocFreqValueSource(), however JoinDocFreqValueSource() expects q

[GitHub] [lucene-solr] CaoManhDat commented on a change in pull request #1470: SOLR-14354: Async or using threads in better way for HttpShardHandler

2020-04-30 Thread GitBox
CaoManhDat commented on a change in pull request #1470: URL: https://github.com/apache/lucene-solr/pull/1470#discussion_r418391517 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBSolrClient.java ## @@ -136,6 +137,91 @@ public boolean equals(Object obj) {

[GitHub] [lucene-solr] CaoManhDat commented on a change in pull request #1470: SOLR-14354: Async or using threads in better way for HttpShardHandler

2020-04-30 Thread GitBox
CaoManhDat commented on a change in pull request #1470: URL: https://github.com/apache/lucene-solr/pull/1470#discussion_r418394131 ## File path: solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java ## @@ -64,18 +62,23 @@ * by the RealtimeGet handler,

[GitHub] [lucene-solr] CaoManhDat commented on a change in pull request #1470: SOLR-14354: Async or using threads in better way for HttpShardHandler

2020-04-30 Thread GitBox
CaoManhDat commented on a change in pull request #1470: URL: https://github.com/apache/lucene-solr/pull/1470#discussion_r418394732 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java ## @@ -359,65 +366,95 @@ public void send(OutStream outSt

[jira] [Commented] (SOLR-14437) Remove/refactor "ApiSupport" interface? (for V2 API)

2020-04-30 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097137#comment-17097137 ] David Smiley commented on SOLR-14437: - bq. can you explain a bit more on the getApis(

[GitHub] [lucene-solr] dsmiley commented on pull request #1469: SOLR-14274 More avoid re-registering multiple JVM metrics

2020-04-30 Thread GitBox
dsmiley commented on pull request #1469: URL: https://github.com/apache/lucene-solr/pull/1469#issuecomment-67752 @sigram should review metric stuff (not me). This is an automated message from the Apache Git Service. To re

[jira] [Commented] (SOLR-14452) "classloading deadlock" issue with DocSet/SortedIntDocSet

2020-04-30 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097138#comment-17097138 ] David Smiley commented on SOLR-14452: - I think your master branch is out of date. Ma

[GitHub] [lucene-solr] CaoManhDat commented on a change in pull request #1470: SOLR-14354: Async or using threads in better way for HttpShardHandler

2020-04-30 Thread GitBox
CaoManhDat commented on a change in pull request #1470: URL: https://github.com/apache/lucene-solr/pull/1470#discussion_r418399765 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java ## @@ -359,65 +366,95 @@ public void send(OutStream outSt

[jira] [Commented] (SOLR-13292) Provide extended per-segment status of a collection

2020-04-30 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097141#comment-17097141 ] David Smiley commented on SOLR-13292: - This issue creates a new SolrClientCache insta

[GitHub] [lucene-solr] CaoManhDat commented on a change in pull request #1470: SOLR-14354: Async or using threads in better way for HttpShardHandler

2020-04-30 Thread GitBox
CaoManhDat commented on a change in pull request #1470: URL: https://github.com/apache/lucene-solr/pull/1470#discussion_r418404455 ## File path: solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java ## @@ -243,12 +233,13 @@ public ShardResponse takeComplet

[GitHub] [lucene-solr] CaoManhDat commented on a change in pull request #1470: SOLR-14354: Async or using threads in better way for HttpShardHandler

2020-04-30 Thread GitBox
CaoManhDat commented on a change in pull request #1470: URL: https://github.com/apache/lucene-solr/pull/1470#discussion_r418416790 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java ## @@ -66,4 +80,132 @@ public LBHttp2SolrClient(Http2So

[GitHub] [lucene-solr] CaoManhDat commented on a change in pull request #1470: SOLR-14354: Async or using threads in better way for HttpShardHandler

2020-04-30 Thread GitBox
CaoManhDat commented on a change in pull request #1470: URL: https://github.com/apache/lucene-solr/pull/1470#discussion_r418416881 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java ## @@ -359,65 +366,95 @@ public void send(OutStream outSt

[GitHub] [lucene-solr] CaoManhDat commented on a change in pull request #1470: SOLR-14354: Async or using threads in better way for HttpShardHandler

2020-04-30 Thread GitBox
CaoManhDat commented on a change in pull request #1470: URL: https://github.com/apache/lucene-solr/pull/1470#discussion_r418394131 ## File path: solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java ## @@ -64,18 +62,23 @@ * by the RealtimeGet handler,

[GitHub] [lucene-solr] CaoManhDat commented on a change in pull request #1470: SOLR-14354: Async or using threads in better way for HttpShardHandler

2020-04-30 Thread GitBox
CaoManhDat commented on a change in pull request #1470: URL: https://github.com/apache/lucene-solr/pull/1470#discussion_r418394732 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java ## @@ -359,65 +366,95 @@ public void send(OutStream outSt

[GitHub] [lucene-solr] dsmiley commented on pull request #1446: SOLR-14425: Aliases: ZK sync() needs to be synchronous

2020-04-30 Thread GitBox
dsmiley commented on pull request #1446: URL: https://github.com/apache/lucene-solr/pull/1446#issuecomment-622249258 It appears I am mistaken about this whole thing: https://github.com/Netflix/curator/issues/194 Pretty non-obvious. I can see why the Zk CLI for sync does wait for the ca