[
https://issues.apache.org/jira/browse/LUCENE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17096703#comment-17096703
]
Erick Erickson commented on LUCENE-7788:
----------------------------------------
Thanks, I see what happened, I'll fix it when I commit the last bunch of mass
edits today or tomorrow.
Unfortunately, there's a lot of changes. Although I double check them a couple
of times, I'm sure a few will escape notice. Please point any out you see!
"the right number of arguments" would get complicated. Any number of entries
are of the form:
log.level("some text", e);
where e is an exception, and that prints out the entire stack trace whereas
log.level("some text{}, e)
prints out the message associated with the exception, so just counting won't
work. And there are some quite complex arguments to log statements, as in
multi-parameter method calls. I'll see what I can do as a final check after I
get this last batch done, but it'll probably be a one-off to catch changes for
this mass edits.
> fail precommit on unparameterised log messages and examine for wasted
> work/objects
> ----------------------------------------------------------------------------------
>
> Key: LUCENE-7788
> URL: https://issues.apache.org/jira/browse/LUCENE-7788
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Christine Poerschke
> Assignee: Erick Erickson
> Priority: Minor
> Attachments: LUCENE-7788.patch, LUCENE-7788.patch, gradle_only.patch,
> gradle_only.patch
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> SOLR-10415 would be removing existing unparameterised log.trace messages use
> and once that is in place then this ticket's one-line change would be for
> 'ant precommit' to reject any future unparameterised log.trace message use.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]