Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

ChrisHegarty merged PR #14482: URL: https://github.com/apache/lucene/pull/14482 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucen

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

thecoop commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2066731184 ## lucene/core/src/java/org/apache/lucene/store/DefaultIOContext.java: ## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

jpountz commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2066581896 ## lucene/core/src/java/org/apache/lucene/store/DefaultIOContext.java: ## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

thecoop commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2066539532 ## lucene/core/src/java/org/apache/lucene/store/FileDataHint.java: ## @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * c

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

thecoop commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2066539532 ## lucene/core/src/java/org/apache/lucene/store/FileDataHint.java: ## @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * c

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

thecoop commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2066560536 ## lucene/test-framework/src/java/module-info.java: ## @@ -22,6 +22,7 @@ requires org.apache.lucene.codecs; requires transitive junit; requires transitive ran

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

jpountz commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2066550453 ## lucene/core/src/java/org/apache/lucene/store/FileDataHint.java: ## @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * c

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

thecoop commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2066552180 ## lucene/core/src/java/org/apache/lucene/store/DefaultIOContext.java: ## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

thecoop commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2066539532 ## lucene/core/src/java/org/apache/lucene/store/FileDataHint.java: ## @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * c

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

thecoop commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2066360099 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

jpountz commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2066497910 ## lucene/test-framework/src/java/module-info.java: ## @@ -22,6 +22,7 @@ requires org.apache.lucene.codecs; requires transitive junit; requires transitive ran

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

thecoop commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2066360099 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

thecoop commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2066360099 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

jpountz commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2064548591 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

ChrisHegarty commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2063884540 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abst

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

thecoop commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2059809065 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

thecoop commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2059828062 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

thecoop commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2059809065 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

jpountz commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2059104981 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

jpountz commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2059102197 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

ChrisHegarty commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2057993129 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abst

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

thecoop commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2057921646 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

ChrisHegarty commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2057896977 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abst

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

thecoop commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2057921646 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

thecoop commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2057921646 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

thecoop commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2057921646 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

thecoop commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2057921646 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

thecoop commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2057921646 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

thecoop commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2057921646 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

thecoop commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2057921646 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

ChrisHegarty commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2057896977 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abst

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

ChrisHegarty commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2057828737 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abst

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

jpountz commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2056836360 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

thecoop commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2056382795 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

thecoop commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2055991981 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

thecoop commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2056382795 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

thecoop commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2056374094 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

thecoop commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2055991981 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

thecoop commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2055991981 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

jpountz commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2055940755 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

jpountz commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2055940755 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

jpountz commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2055961207 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

jpountz commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2055959591 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

thecoop commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2055950140 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

jpountz commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2055947695 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

thecoop commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2055706972 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

ChrisHegarty commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2055674573 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abst

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

thecoop commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2055636449 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

rmuir commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2055620022 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract lo

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

thecoop commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2055496607 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

thecoop commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2055502471 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

thecoop commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2055497713 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

thecoop commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2055496607 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

jpountz commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2054788526 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

rmuir commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2054469931 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract lo

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

rmuir commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2054468730 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract lo

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

thecoop commented on PR #14482: URL: https://github.com/apache/lucene/pull/14482#issuecomment-2821545922 @jpountz @rmuir What are your thoughts? Dependent PRs using this functionality are linked in -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

thecoop commented on PR #14482: URL: https://github.com/apache/lucene/pull/14482#issuecomment-2805013373 To stop this PR getting too big, I suggest merging this here (which doesn't change any existing behaviour), and work on updating uses of IOContext to use hints rather than ReadAdvice in

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

ChrisHegarty commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2044187179 ## lucene/core/src/test/org/apache/lucene/store/TestDirectory.java: ## @@ -126,4 +126,27 @@ public void testListAll() throws Throwable { assertTrue(files.con

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

thecoop commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2041871342 ## lucene/core/src/java/org/apache/lucene/store/IOContext.java: ## @@ -44,71 +37,125 @@ public enum Context { DEFAULT }; + /** Implemented by classes that c