jpountz commented on code in PR #14482:
URL: https://github.com/apache/lucene/pull/14482#discussion_r2055940755


##########
lucene/core/src/java/org/apache/lucene/store/Directory.java:
##########
@@ -79,6 +83,31 @@ public abstract class Directory implements Closeable {
    */
   public abstract long fileLength(String name) throws IOException;
 
+  protected void validateIOContext(IOContext context) {

Review Comment:
   Could this be a compile-time invariant instead of a runtime invariant, e.g. 
~~by tracking the 3 hints separately, or~~ by using something similar to 
Guava's ClassToInstanceMap instead of a Set?
   
   EDIT: lated read the explanation why it can't be 3 different hints



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to