thecoop commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2066539532
########## lucene/core/src/java/org/apache/lucene/store/FileDataHint.java: ########## @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.store; + +/** Hints on the type of data stored in the file */ +public enum FileDataHint implements IOContext.FileOpenHint { + /** The file contains postings data */ + POSTINGS, + /** The file contains stored fields */ + STORED_FIELDS, + /** The file contains vector data */ + VECTORS Review Comment: `KNN_VECTORS` it is. I'm not sure about adding all the various types at this point, especially since we'll then need to go and find, then annotate all the various different uses in the right places. This change is mainly useful for modifying the context for knn vectors, so I've left it at the most obvious ones for now. We can always add more later, if the context would be useful for those types too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org