Re: [PR] Misc cleanups postings codec [lucene]

2024-10-08 Thread via GitHub
original-brownbear merged PR #13862: URL: https://github.com/apache/lucene/pull/13862 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

Re: [PR] Misc cleanups postings codec [lucene]

2024-10-08 Thread via GitHub
original-brownbear commented on PR #13862: URL: https://github.com/apache/lucene/pull/13862#issuecomment-2400389468 Thanks Adrien! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] Misc cleanups postings codec [lucene]

2024-10-08 Thread via GitHub
original-brownbear commented on code in PR #13862: URL: https://github.com/apache/lucene/pull/13862#discussion_r1792205301 ## lucene/core/src/java/org/apache/lucene/codecs/lucene912/Lucene912PostingsReader.java: ## @@ -1502,7 +1471,7 @@ public int advance(int target) throws IOEx

Re: [PR] Misc cleanups postings codec [lucene]

2024-10-08 Thread via GitHub
original-brownbear commented on code in PR #13862: URL: https://github.com/apache/lucene/pull/13862#discussion_r1792215104 ## lucene/core/src/java/org/apache/lucene/codecs/lucene912/Lucene912PostingsReader.java: ## @@ -1502,7 +1471,7 @@ public int advance(int target) throws IOEx

Re: [PR] Misc cleanups postings codec [lucene]

2024-10-08 Thread via GitHub
jpountz commented on code in PR #13862: URL: https://github.com/apache/lucene/pull/13862#discussion_r1792211239 ## lucene/core/src/java/org/apache/lucene/codecs/lucene912/Lucene912PostingsReader.java: ## @@ -1502,7 +1471,7 @@ public int advance(int target) throws IOException {

Re: [PR] Misc cleanups postings codec [lucene]

2024-10-08 Thread via GitHub
jpountz commented on code in PR #13862: URL: https://github.com/apache/lucene/pull/13862#discussion_r1792194753 ## lucene/core/src/java/org/apache/lucene/codecs/lucene912/Lucene912PostingsReader.java: ## @@ -1529,36 +1498,27 @@ public int getDocIdUpTo(int level) { l

Re: [PR] Misc cleanups postings codec [lucene]

2024-10-08 Thread via GitHub
original-brownbear commented on code in PR #13862: URL: https://github.com/apache/lucene/pull/13862#discussion_r1792194308 ## lucene/core/src/java/org/apache/lucene/codecs/lucene912/Lucene912PostingsReader.java: ## @@ -1533,7 +1502,6 @@ public int getDocIdUpTo(int level) {

Re: [PR] Misc cleanups postings codec [lucene]

2024-10-08 Thread via GitHub
jpountz commented on code in PR #13862: URL: https://github.com/apache/lucene/pull/13862#discussion_r1792143872 ## lucene/core/src/java/org/apache/lucene/codecs/lucene912/Lucene912PostingsReader.java: ## @@ -1502,7 +1471,7 @@ public int advance(int target) throws IOException {

Re: [PR] Misc cleanups postings codec [lucene]

2024-10-08 Thread via GitHub
jpountz commented on code in PR #13862: URL: https://github.com/apache/lucene/pull/13862#discussion_r1792142174 ## lucene/core/src/java/org/apache/lucene/codecs/lucene912/Lucene912PostingsReader.java: ## @@ -1533,7 +1502,6 @@ public int getDocIdUpTo(int level) { if