jpountz commented on code in PR #13862: URL: https://github.com/apache/lucene/pull/13862#discussion_r1792194753
########## lucene/core/src/java/org/apache/lucene/codecs/lucene912/Lucene912PostingsReader.java: ########## @@ -1529,36 +1498,27 @@ public int getDocIdUpTo(int level) { level--; } - if (level1LastDocID != NO_MORE_DOCS) { - if (level == 0) { - return level1LastDocID; - } - level--; + if (level1LastDocID != NO_MORE_DOCS && level == 0) { Review Comment: No need to check `level1LastDocID` against `NO_MORE_DOCS` since we return `NO_MORE_DOCS` otherwise anyway? ```suggestion if (level == 0) { ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org