jpountz commented on code in PR #13862:
URL: https://github.com/apache/lucene/pull/13862#discussion_r1792211239
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene912/Lucene912PostingsReader.java:
##########
@@ -1502,7 +1471,7 @@ public int advance(int target) throws IOException {
}
@Override
- public Impacts getImpacts() throws IOException {
+ public Impacts getImpacts() {
return new Impacts() {
Review Comment:
As a first step, let's allocate it once per `BlockDocsImpactsEnum` instance,
rather than once per `getImpacts()` call, this should already save a lot?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
