original-brownbear commented on code in PR #13862:
URL: https://github.com/apache/lucene/pull/13862#discussion_r1792205301
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene912/Lucene912PostingsReader.java:
##########
@@ -1502,7 +1471,7 @@ public int advance(int target) throws IOException {
}
@Override
- public Impacts getImpacts() throws IOException {
+ public Impacts getImpacts() {
return new Impacts() {
Review Comment:
Yea I made that thing's tmp buffer `ThreadLocal` in ES's fork of this class
a while back already, That was the easiest and ok for an application, wasn't
so sure about we would address this in Lucene. `ThreadLocal` kinda sucks for a
library but this is eating so much memory that you'd ideally not just share per
reader instance but per thread if possible, so maybe it's ok to go for
thread-local?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
