mikemccand commented on PR #12831:
URL: https://github.com/apache/lucene/pull/12831#issuecomment-1932617133
> Thank you for merging @mikemccand !
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
dungba88 commented on PR #12831:
URL: https://github.com/apache/lucene/pull/12831#issuecomment-1928655191
Thank you for merging @mikemccand !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
mikemccand merged PR #12831:
URL: https://github.com/apache/lucene/pull/12831
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
mikemccand commented on PR #12831:
URL: https://github.com/apache/lucene/pull/12831#issuecomment-1927303409
This is technically an API break, but `FSTCompiler` is an experimental API
and effectively an internal Lucene datastructure, so I think we can safely
backport to 9.x without deprecati
github-actions[bot] commented on PR #12831:
URL: https://github.com/apache/lucene/pull/12831#issuecomment-1915807375
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
dungba88 commented on PR #12831:
URL: https://github.com/apache/lucene/pull/12831#issuecomment-1891168778
Thanks bot and @mikemccand, apparently I forgot about this PR!
I'll make another revision. The rebase after conflict seems to break the
build.
--
This is an automated message f
mikemccand commented on PR #12831:
URL: https://github.com/apache/lucene/pull/12831#issuecomment-1889722033
Thank you stale bot!
@dungba88 -- what is the status of this change?
I think it makes sense to have two FST compile+consume paths -- one on heap,
that you can (efficientl
github-actions[bot] commented on PR #12831:
URL: https://github.com/apache/lucene/pull/12831#issuecomment-1885965745
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
dungba88 commented on code in PR #12831:
URL: https://github.com/apache/lucene/pull/12831#discussion_r1421299753
##
lucene/analysis/common/src/java/org/apache/lucene/analysis/charfilter/NormalizeCharMap.java:
##
@@ -111,7 +111,7 @@ public NormalizeCharMap build() {
for
dungba88 commented on PR #12831:
URL: https://github.com/apache/lucene/pull/12831#issuecomment-184998
One of the point I'm unsure about this PR is that there is now 2 (obscured)
ways to construct the FST, one using the DataInput+FSTStore and one using
FSTReader returned by the on-heap D
dungba88 commented on code in PR #12831:
URL: https://github.com/apache/lucene/pull/12831#discussion_r1420866991
##
lucene/core/src/java/org/apache/lucene/util/fst/FST.java:
##
@@ -503,9 +518,7 @@ public FSTMetadata getMetadata() {
}
/**
- * Save the FST to DataOutput.
dungba88 commented on PR #12831:
URL: https://github.com/apache/lucene/pull/12831#issuecomment-1840269923
I'll put the CHANGES.txt for #12624 together with this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
12 matches
Mail list logo
