dungba88 commented on PR #12831: URL: https://github.com/apache/lucene/pull/12831#issuecomment-1849000098
One of the point I'm unsure about this PR is that there is now 2 (obscured) ways to construct the FST, one using the DataInput+FSTStore and one using FSTReader returned by the on-heap DataOutput, while the previous way there is only 1 way (calling `compile()`). If users don't read the Javadoc, they might be confused on how to get the FST. Maybe there could be other way which feels more natural. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
