dungba88 commented on code in PR #12831:
URL: https://github.com/apache/lucene/pull/12831#discussion_r1421299753
##########
lucene/analysis/common/src/java/org/apache/lucene/analysis/charfilter/NormalizeCharMap.java:
##########
@@ -111,7 +111,7 @@ public NormalizeCharMap build() {
for (Map.Entry<String, String> ent : pendingPairs.entrySet()) {
fstCompiler.add(Util.toUTF16(ent.getKey(), scratch), new
CharsRef(ent.getValue()));
}
- map = fstCompiler.compile();
+ map = FST.fromFSTReader(fstCompiler.compile(),
fstCompiler.getFSTReader());
Review Comment:
This `fromFSTReader` is there to avoid the boilerplate null-check that each
consumer must now do. Open for method name suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
