dungba88 commented on code in PR #12831:
URL: https://github.com/apache/lucene/pull/12831#discussion_r1420866991
##########
lucene/core/src/java/org/apache/lucene/util/fst/FST.java:
##########
@@ -503,9 +518,7 @@ public FSTMetadata<T> getMetadata() {
}
/**
- * Save the FST to DataOutput. If you use an {@link
org.apache.lucene.store.IndexOutput} to build
- * the FST, then you should not and do not need to call this method, as the
FST is already saved.
- * Doing so will throw an {@link UnsupportedOperationException}.
+ * Save the FST to DataOutput.
Review Comment:
It's no longer possible for user to create a FST that uses `NullFSTReader`,
so this Javadoc will no longer holds. If users are able to create FST, then it
will always be readable.
##########
lucene/core/src/java/org/apache/lucene/util/fst/FSTCompiler.java:
##########
@@ -175,7 +176,7 @@ private FSTCompiler(
fst =
new FST<>(
new FST.FSTMetadata<>(inputType, outputs, null, -1,
VERSION_CURRENT, 0),
- toFSTReader(dataOutput));
+ NULL_FST_READER);
Review Comment:
As we can't pass actual null to FSTReader, `NullFSTReader` will be used
instead.
##########
lucene/analysis/common/src/java/org/apache/lucene/analysis/charfilter/NormalizeCharMap.java:
##########
@@ -111,7 +111,7 @@ public NormalizeCharMap build() {
for (Map.Entry<String, String> ent : pendingPairs.entrySet()) {
fstCompiler.add(Util.toUTF16(ent.getKey(), scratch), new
CharsRef(ent.getValue()));
}
- map = fstCompiler.compile();
+ map = FST.fromFSTReader(fstCompiler.compile(),
fstCompiler.getFSTReader());
Review Comment:
This `fromFSTReader` is there to avoid the boilerplate null-check that each
consumer must now do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
