jpountz commented on PR #14511:
URL: https://github.com/apache/lucene/pull/14511#issuecomment-2830415622
This sounds safe enough for 10.2.1 for me. Can you move the CHANGES entry to
10.2.1 then? cc @ChrisHegarty
--
This is an automated message from the Apache Git Service.
To respond to t
expani commented on PR #14511:
URL: https://github.com/apache/lucene/pull/14511#issuecomment-2830167911
Addressed comments.
I want to backport these to `9.12.x` and `10.2.x` as well. Will open
separate PRs for the same.
--
This is an automated message from the Apache Git Serv
expani commented on code in PR #14511:
URL: https://github.com/apache/lucene/pull/14511#discussion_r2059942355
##
lucene/core/src/java/org/apache/lucene/codecs/lucene103/Lucene103PostingsReader.java:
##
@@ -1286,14 +1298,11 @@ public long cost() {
@Override
expani commented on PR #14511:
URL: https://github.com/apache/lucene/pull/14511#issuecomment-2829961538
Added the changes entry.
>undo the new line in SlowImpactsEnum?
```
./gradlew tidy
./gradlew spotlessApply
./gradlew spotlessJavaApply
```
All these command
jpountz commented on code in PR #14511:
URL: https://github.com/apache/lucene/pull/14511#discussion_r2059900940
##
lucene/core/src/java/org/apache/lucene/codecs/lucene103/Lucene103PostingsReader.java:
##
@@ -1286,14 +1298,11 @@ public long cost() {
@Override
expani commented on code in PR #14511:
URL: https://github.com/apache/lucene/pull/14511#discussion_r2059897538
##
lucene/core/src/java/org/apache/lucene/codecs/lucene103/Lucene103PostingsReader.java:
##
@@ -1286,14 +1298,11 @@ public long cost() {
@Override
expani commented on code in PR #14511:
URL: https://github.com/apache/lucene/pull/14511#discussion_r2059808880
##
lucene/core/src/java/org/apache/lucene/codecs/lucene103/Lucene103PostingsReader.java:
##
@@ -1286,14 +1298,11 @@ public long cost() {
@Override
expani commented on code in PR #14511:
URL: https://github.com/apache/lucene/pull/14511#discussion_r2059808880
##
lucene/core/src/java/org/apache/lucene/codecs/lucene103/Lucene103PostingsReader.java:
##
@@ -1286,14 +1298,11 @@ public long cost() {
@Override
expani commented on code in PR #14511:
URL: https://github.com/apache/lucene/pull/14511#discussion_r2059790054
##
lucene/core/src/java/org/apache/lucene/codecs/lucene103/Lucene103PostingsReader.java:
##
@@ -66,13 +67,20 @@
public final class Lucene103PostingsReader extends Post
expani commented on code in PR #14511:
URL: https://github.com/apache/lucene/pull/14511#discussion_r2058428825
##
lucene/core/src/java/org/apache/lucene/codecs/lucene103/Lucene103PostingsReader.java:
##
@@ -282,6 +290,10 @@ public PostingsEnum postings(
@Override
public Im
jpountz commented on code in PR #14511:
URL: https://github.com/apache/lucene/pull/14511#discussion_r2058399082
##
lucene/core/src/java/org/apache/lucene/codecs/lucene103/Lucene103PostingsReader.java:
##
@@ -1286,14 +1298,11 @@ public long cost() {
@Override
expani commented on code in PR #14511:
URL: https://github.com/apache/lucene/pull/14511#discussion_r2052812090
##
lucene/core/src/java/org/apache/lucene/codecs/lucene103/Lucene103PostingsReader.java:
##
@@ -1310,7 +1317,7 @@ public List getImpacts(int level) {
r
expani commented on code in PR #14511:
URL: https://github.com/apache/lucene/pull/14511#discussion_r2050377465
##
lucene/core/src/java/org/apache/lucene/codecs/lucene103/Lucene103PostingsReader.java:
##
@@ -282,6 +288,10 @@ public PostingsEnum postings(
@Override
public Im
expani commented on code in PR #14511:
URL: https://github.com/apache/lucene/pull/14511#discussion_r2047829308
##
lucene/core/src/java/org/apache/lucene/codecs/lucene103/Lucene103PostingsReader.java:
##
@@ -1310,7 +1317,7 @@ public List getImpacts(int level) {
r
expani commented on code in PR #14511:
URL: https://github.com/apache/lucene/pull/14511#discussion_r2047828296
##
lucene/core/src/java/org/apache/lucene/codecs/lucene103/Lucene103PostingsReader.java:
##
@@ -282,6 +288,10 @@ public PostingsEnum postings(
@Override
public Im
expani commented on code in PR #14511:
URL: https://github.com/apache/lucene/pull/14511#discussion_r2047828296
##
lucene/core/src/java/org/apache/lucene/codecs/lucene103/Lucene103PostingsReader.java:
##
@@ -282,6 +288,10 @@ public PostingsEnum postings(
@Override
public Im
expani commented on code in PR #14511:
URL: https://github.com/apache/lucene/pull/14511#discussion_r2047828296
##
lucene/core/src/java/org/apache/lucene/codecs/lucene103/Lucene103PostingsReader.java:
##
@@ -282,6 +288,10 @@ public PostingsEnum postings(
@Override
public Im
expani commented on code in PR #14511:
URL: https://github.com/apache/lucene/pull/14511#discussion_r2047829308
##
lucene/core/src/java/org/apache/lucene/codecs/lucene103/Lucene103PostingsReader.java:
##
@@ -1310,7 +1317,7 @@ public List getImpacts(int level) {
r
msfroh commented on code in PR #14511:
URL: https://github.com/apache/lucene/pull/14511#discussion_r2047793102
##
lucene/core/src/java/org/apache/lucene/codecs/lucene103/Lucene103PostingsReader.java:
##
@@ -1310,7 +1317,7 @@ public List getImpacts(int level) {
r
expani opened a new pull request, #14511:
URL: https://github.com/apache/lucene/pull/14511
### Description
Fix for https://github.com/apache/lucene/issues/14445
Falling back to return a SlowImpactsEnum for all default cases but ensuring
skip data is read for case where field i
20 matches
Mail list logo
