expani commented on code in PR #14511:
URL: https://github.com/apache/lucene/pull/14511#discussion_r2052812090
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene103/Lucene103PostingsReader.java:
##########
@@ -1310,7 +1317,7 @@ public List<Impact> getImpacts(int level) {
return readImpacts(level1SerializedImpacts, level1Impacts);
}
}
- return DUMMY_IMPACTS;
+ return NON_COMPETITIVE_IMPACTS;
Review Comment:
Looks like there was a case in CheckIndex failing due to this.
So added it back for fields that have at least freqs enabled.
Failing test
```
./gradlew :lucene:benchmark:test --tests
"org.apache.lucene.benchmark.quality.TestQualityRun.testTrecQuality"
-Ptests.jvms=1 -Ptests.jvmargs= -Ptests.seed=6AD36F6087951803
-Ptests.useSecurityManager=true -Ptests.gui=true
-Ptests.file.encoding=ISO-8859-1 -Ptests.vectorsize=256
-Ptests.forceintegervectors=true
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
