msfroh commented on code in PR #14511:
URL: https://github.com/apache/lucene/pull/14511#discussion_r2047793102
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene103/Lucene103PostingsReader.java:
##########
@@ -1310,7 +1317,7 @@ public List<Impact> getImpacts(int level) {
return readImpacts(level1SerializedImpacts, level1Impacts);
}
}
- return DUMMY_IMPACTS;
+ return NON_COMPETITIVE_IMPACTS;
Review Comment:
This was the only reference to `DUMMY_IMPACTS`, right? Can we remove it?
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene103/Lucene103PostingsReader.java:
##########
@@ -282,6 +288,10 @@ public PostingsEnum postings(
@Override
public ImpactsEnum impacts(FieldInfo fieldInfo, BlockTermState state, int
flags)
throws IOException {
+ if (state.docFreq <= BLOCK_SIZE) {
+ // no skip data
+ return new SlowImpactsEnum(postings(fieldInfo, state, null, flags));
+ }
Review Comment:
This is essentially taking the place of `DUMMY_IMPACTS`, right?
It's the thing that kicks in on tail blocks, which is what `DUMMY_IMPACTS`
was there for. (I'm trying to make sure I understand the change.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
