Re: [PR] Convert more classes to record classes [lucene]

shubhamvishu commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1755293825 ## lucene/core/src/java/org/apache/lucene/search/MaxScoreAccumulator.java: ## @@ -101,11 +93,6 @@ public boolean equals(Object o) { return docBase == resul

Re: [PR] Convert more classes to record classes [lucene]

shubhamvishu commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1753134745 ## lucene/core/src/java/org/apache/lucene/search/MaxScoreAccumulator.java: ## @@ -101,11 +93,6 @@ public boolean equals(Object o) { return docBase == resul

Re: [PR] Convert more classes to record classes [lucene]

shubhamvishu commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1753129302 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/search/CombinedFieldQuery.java: ## @@ -163,11 +156,6 @@ public boolean equals(Object o) { FieldAndWeig

Re: [PR] Convert more classes to record classes [lucene]

uschindler commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1752895892 ## lucene/core/src/java/org/apache/lucene/search/MaxScoreAccumulator.java: ## @@ -101,11 +93,6 @@ public boolean equals(Object o) { return docBase == result.

Re: [PR] Convert more classes to record classes [lucene]

uschindler commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1752842660 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/search/CombinedFieldQuery.java: ## @@ -163,11 +156,6 @@ public boolean equals(Object o) { FieldAndWeight

Re: [PR] Convert more classes to record classes [lucene]

uschindler commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1752860507 ## lucene/core/src/java/org/apache/lucene/search/MaxScoreAccumulator.java: ## @@ -101,11 +93,6 @@ public boolean equals(Object o) { return docBase == result.

Re: [PR] Convert more classes to record classes [lucene]

uschindler commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1752842660 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/search/CombinedFieldQuery.java: ## @@ -163,11 +156,6 @@ public boolean equals(Object o) { FieldAndWeight

Re: [PR] Convert more classes to record classes [lucene]

uschindler commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1752842660 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/search/CombinedFieldQuery.java: ## @@ -163,11 +156,6 @@ public boolean equals(Object o) { FieldAndWeight

Re: [PR] Convert more classes to record classes [lucene]

jpountz commented on PR #13328: URL: https://github.com/apache/lucene/pull/13328#issuecomment-2342059732 @javanna just fixed it, thanks @javanna ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Convert more classes to record classes [lucene]

stefanvodita commented on PR #13328: URL: https://github.com/apache/lucene/pull/13328#issuecomment-2342037249 I think we've run into a conflict with #13689. @jpountz - should I fix that or are you already doing it? -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Convert more classes to record classes [lucene]

jpountz merged PR #13328: URL: https://github.com/apache/lucene/pull/13328 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Convert more classes to record classes [lucene]

mikemccand commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1752005115 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/search/CombinedFieldQuery.java: ## @@ -163,11 +156,6 @@ public boolean equals(Object o) { FieldAndWeight

Re: [PR] Convert more classes to record classes [lucene]

shubhamvishu commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1751558206 ## lucene/core/src/java/org/apache/lucene/util/FixedBits.java: ## @@ -17,15 +17,7 @@ package org.apache.lucene.util; /** Immutable twin of FixedBitSet. */ -fi

Re: [PR] Convert more classes to record classes [lucene]

shubhamvishu commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1751557625 ## lucene/test-framework/src/java/org/apache/lucene/tests/codecs/asserting/AssertingLiveDocsFormat.java: ## @@ -68,9 +68,7 @@ public String toString() { retu

Re: [PR] Convert more classes to record classes [lucene]

shubhamvishu commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1751550108 ## lucene/misc/src/java/org/apache/lucene/misc/util/fst/UpToTwoPositiveIntOutputs.java: ## @@ -42,36 +42,11 @@ public final class UpToTwoPositiveIntOutputs exten

Re: [PR] Convert more classes to record classes [lucene]

github-actions[bot] commented on PR #13328: URL: https://github.com/apache/lucene/pull/13328#issuecomment-2237834830 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Convert more classes to record classes [lucene]

shubhamvishu commented on PR #13328: URL: https://github.com/apache/lucene/pull/13328#issuecomment-2209345556 Hi @uschindler, Could you please review the current code changes once you get some time and if it looks good maybe we can move this forward? -- This is an automated message from t

Re: [PR] Convert more classes to record classes [lucene]

shubhamvishu commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1623687790 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/GeneratingSuggester.java: ## @@ -447,14 +446,8 @@ private static int commonCharacterPositio

Re: [PR] Convert more classes to record classes [lucene]

shubhamvishu commented on PR #13328: URL: https://github.com/apache/lucene/pull/13328#issuecomment-2144096151 Hi @uschindler , thanks for the review. I took another pass at the changes and pushed some commits addressing your comments. Please have a look when you get a chance. Thanks! --

Re: [PR] Convert more classes to record classes [lucene]

shubhamvishu commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1623688659 ## lucene/core/src/java/org/apache/lucene/document/NearestNeighbor.java: ## @@ -34,20 +34,16 @@ /** KNN search on top of 2D lat/lon indexed points. */ class Nea

Re: [PR] Convert more classes to record classes [lucene]

shubhamvishu commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1623688408 ## lucene/codecs/src/java/org/apache/lucene/codecs/blocktreeords/OrdsBlockTreeTermsWriter.java: ## @@ -139,18 +139,17 @@ public final class OrdsBlockTreeTermsWrit

Re: [PR] Convert more classes to record classes [lucene]

shubhamvishu commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1623688124 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/synonym/word2vec/TermAndBoost.java: ## @@ -18,14 +18,13 @@ import org.apache.lucene.util.BytesRef

Re: [PR] Convert more classes to record classes [lucene]

shubhamvishu commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1623687790 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/GeneratingSuggester.java: ## @@ -447,14 +446,8 @@ private static int commonCharacterPositio

Re: [PR] Convert more classes to record classes [lucene]

shubhamvishu commented on PR #13328: URL: https://github.com/apache/lucene/pull/13328#issuecomment-2120851082 Hi @uschindler , sorry I was on vacation until last week, so this PR stalled. I'll take a look at the comments today or tomorrow. -- This is an automated message from the Apache G

Re: [PR] Convert more classes to record classes [lucene]

uschindler commented on PR #13328: URL: https://github.com/apache/lucene/pull/13328#issuecomment-2118884788 Hi @shubhamvishu, can you check my comments? The changes here look fine, please fix the remaining issues. Uwe -- This is an automated message from the Apache Git Service. To

Re: [PR] Convert more classes to record classes [lucene]

github-actions[bot] commented on PR #13328: URL: https://github.com/apache/lucene/pull/13328#issuecomment-2116414026 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Convert more classes to record classes [lucene]

uschindler commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1588461460 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/GeneratingSuggester.java: ## @@ -447,14 +446,8 @@ private static int commonCharacterPositionS

Re: [PR] Convert more classes to record classes [lucene]

uschindler commented on PR #13328: URL: https://github.com/apache/lucene/pull/13328#issuecomment-2091805740 Thanks, looks fine. I have no time to do another closer review, please give me some time to proceed. -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] Convert more classes to record classes [lucene]

shubhamvishu commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1586937485 ## lucene/core/src/java/org/apache/lucene/util/TermAndVector.java: ## @@ -24,23 +24,7 @@ * * @lucene.experimental */ -public class TermAndVector { - - priv

Re: [PR] Convert more classes to record classes [lucene]

shubhamvishu commented on PR #13328: URL: https://github.com/apache/lucene/pull/13328#issuecomment-2089321284 I addressed your comments in the new revision and all the checks are passing now after your fix. Thanks! -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Convert more classes to record classes [lucene]

shubhamvishu commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1586937659 ## lucene/core/src/java/org/apache/lucene/util/packed/PackedInts.java: ## @@ -171,14 +171,7 @@ public final float overheadRatio(int bitsPerValue) { } /**

Re: [PR] Convert more classes to record classes [lucene]

shubhamvishu commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1586937857 ## lucene/core/src/java/org/apache/lucene/search/CollectionStatistics.java: ## @@ -116,7 +105,8 @@ public CollectionStatistics( * * @return field's name,

Re: [PR] Convert more classes to record classes [lucene]

shubhamvishu commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1586937485 ## lucene/core/src/java/org/apache/lucene/util/TermAndVector.java: ## @@ -24,23 +24,7 @@ * * @lucene.experimental */ -public class TermAndVector { - - priv

Re: [PR] Convert more classes to record classes [lucene]

uschindler commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1585154771 ## lucene/core/src/java/org/apache/lucene/search/CollectionStatistics.java: ## @@ -116,7 +105,8 @@ public CollectionStatistics( * * @return field's name, no

Re: [PR] Convert more classes to record classes [lucene]

uschindler commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1585152280 ## lucene/core/src/java/org/apache/lucene/util/packed/PackedInts.java: ## @@ -171,14 +171,7 @@ public final float overheadRatio(int bitsPerValue) { } /** Si

Re: [PR] Convert more classes to record classes [lucene]

uschindler commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1585147534 ## lucene/core/src/java/org/apache/lucene/util/TermAndVector.java: ## @@ -24,23 +24,7 @@ * * @lucene.experimental */ -public class TermAndVector { - - privat

Re: [PR] Convert more classes to record classes [lucene]

uschindler commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1585133751 ## lucene/core/src/java/org/apache/lucene/codecs/TermStats.java: ## @@ -16,24 +16,10 @@ */ package org.apache.lucene.codecs; -import org.apache.lucene.index.Te

Re: [PR] Convert more classes to record classes [lucene]

uschindler commented on PR #13328: URL: https://github.com/apache/lucene/pull/13328#issuecomment-2085780025 Hi, you can merge main into your branch and hopefully checks pass. For some packages like the "codecs" one the new code requires you to also document all record components with `@para

Re: [PR] Convert more classes to record classes [lucene]

uschindler commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1585004047 ## lucene/core/src/java/org/apache/lucene/codecs/TermStats.java: ## @@ -16,24 +16,10 @@ */ package org.apache.lucene.codecs; -import org.apache.lucene.index.Te

Re: [PR] Convert more classes to record classes [lucene]

shubhamvishu commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1584467051 ## lucene/core/src/java/org/apache/lucene/codecs/TermStats.java: ## @@ -16,24 +16,10 @@ */ package org.apache.lucene.codecs; -import org.apache.lucene.index.

Re: [PR] Convert more classes to record classes [lucene]

shubhamvishu commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1584391143 ## lucene/core/src/java/org/apache/lucene/codecs/TermStats.java: ## @@ -16,24 +16,10 @@ */ package org.apache.lucene.codecs; -import org.apache.lucene.index.

Re: [PR] Convert more classes to record classes [lucene]

uschindler commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1584332062 ## lucene/core/src/java/org/apache/lucene/codecs/TermStats.java: ## @@ -16,24 +16,10 @@ */ package org.apache.lucene.codecs; -import org.apache.lucene.index.Te

Re: [PR] Convert more classes to record classes [lucene]

uschindler commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1584314019 ## lucene/core/src/java/org/apache/lucene/codecs/TermStats.java: ## @@ -16,24 +16,10 @@ */ package org.apache.lucene.codecs; -import org.apache.lucene.index.Te

Re: [PR] Convert more classes to record classes [lucene]

uschindler commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1584276533 ## lucene/core/src/java/org/apache/lucene/codecs/TermStats.java: ## @@ -16,24 +16,10 @@ */ package org.apache.lucene.codecs; -import org.apache.lucene.index.Te

Re: [PR] Convert more classes to record classes [lucene]

uschindler commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1584267265 ## lucene/core/src/java/org/apache/lucene/codecs/TermStats.java: ## @@ -16,24 +16,10 @@ */ package org.apache.lucene.codecs; -import org.apache.lucene.index.Te

Re: [PR] Convert more classes to record classes [lucene]

uschindler commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1584264324 ## lucene/core/src/java/org/apache/lucene/codecs/TermStats.java: ## @@ -16,24 +16,10 @@ */ package org.apache.lucene.codecs; -import org.apache.lucene.index.Te

Re: [PR] Convert more classes to record classes [lucene]

uschindler commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1584262673 ## lucene/core/src/java/org/apache/lucene/codecs/TermStats.java: ## @@ -16,24 +16,10 @@ */ package org.apache.lucene.codecs; -import org.apache.lucene.index.Te

Re: [PR] Convert more classes to record classes [lucene]

shubhamvishu commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1584249124 ## lucene/core/src/java/org/apache/lucene/codecs/TermStats.java: ## @@ -16,24 +16,10 @@ */ package org.apache.lucene.codecs; -import org.apache.lucene.index.

Re: [PR] Convert more classes to record classes [lucene]

uschindler commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1584223935 ## lucene/core/src/java/org/apache/lucene/codecs/TermStats.java: ## @@ -16,24 +16,10 @@ */ package org.apache.lucene.codecs; -import org.apache.lucene.index.Te

Re: [PR] Convert more classes to record classes [lucene]

uschindler commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1584221042 ## lucene/core/src/java/org/apache/lucene/codecs/TermStats.java: ## @@ -16,24 +16,10 @@ */ package org.apache.lucene.codecs; -import org.apache.lucene.index.Te

Re: [PR] Convert more classes to record classes [lucene]

uschindler commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1584211054 ## lucene/core/src/java/org/apache/lucene/codecs/TermStats.java: ## @@ -16,24 +16,10 @@ */ package org.apache.lucene.codecs; -import org.apache.lucene.index.Te

Re: [PR] Convert more classes to record classes [lucene]

shubhamvishu commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1584056472 ## lucene/core/src/java/org/apache/lucene/codecs/TermStats.java: ## @@ -16,24 +16,10 @@ */ package org.apache.lucene.codecs; -import org.apache.lucene.index.

Re: [PR] Convert more classes to record classes [lucene]

shubhamvishu commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1584056472 ## lucene/core/src/java/org/apache/lucene/codecs/TermStats.java: ## @@ -16,24 +16,10 @@ */ package org.apache.lucene.codecs; -import org.apache.lucene.index.

[PR] Convert more classes to record classes [lucene]

shubhamvishu opened a new pull request, #13328: URL: https://github.com/apache/lucene/pull/13328 ### Description - This PR addresses #13207 to convert more classes on `main` branch to record classes on main (Lucene 10 only). - It moves a lot of data classes(120 to be precise) to us