shubhamvishu opened a new pull request, #13328:
URL: https://github.com/apache/lucene/pull/13328

   ### Description
   
   - This PR addresses #13207 to convert more classes on `main` branch to 
record classes on main (Lucene 10 only).
   - It moves a lot of data classes(120 to be precise) to use record classes 
that were flagged suitable in my IDE and seemed good candidate in general.
   - I left a couple of them like `TotalHits` and `SynonymMap` as the PR is 
already very big and including those were leading to a lot more changes. Maybe 
we could do those as a separate PR.
   
    
   Raising this PR since all the tests are passing(`./gradlew test`) but 
`renderJavadoc` task is complaining about missing java docs on some record 
classes(converted in this PR) which I see has the javadocs already eg: 
`TermStats`, `ReaderSlice`. I'm not sure why its flagging those incorrectly or 
if maybe I'm missing something.
   
   <!--
   If this is your first contribution to Lucene, please make sure you have 
reviewed the contribution guide.
   https://github.com/apache/lucene/blob/main/CONTRIBUTING.md
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to