uschindler commented on code in PR #13328:
URL: https://github.com/apache/lucene/pull/13328#discussion_r1584276533
##########
lucene/core/src/java/org/apache/lucene/codecs/TermStats.java:
##########
@@ -16,24 +16,10 @@
*/
package org.apache.lucene.codecs;
-import org.apache.lucene.index.TermsEnum; // javadocs
-
/**
* Holder for per-term statistics.
*
- * @see TermsEnum#docFreq
- * @see TermsEnum#totalTermFreq
+ * @param docFreq How many documents have at least one occurrence of this term.
+ * @param totalTermFreq Total number of times this term occurs across all
documents in the field.
*/
-public class TermStats {
- /** How many documents have at least one occurrence of this term. */
- public final int docFreq;
-
- /** Total number of times this term occurs across all documents in the
field. */
- public final long totalTermFreq;
-
- /** Sole constructor. */
- public TermStats(int docFreq, long totalTermFreq) {
- this.docFreq = docFreq;
- this.totalTermFreq = totalTermFreq;
- }
-}
+public record TermStats(int docFreq, long totalTermFreq) {}
Review Comment:
It's complicated: we need to find all accessor methods and automatically
generated ctors and exclude them. You can get the accessor method from the
record component. Maybe we should build a set of them and exclude them from the
checks:
https://docs.oracle.com/en/java/javase/21/docs/api/java.compiler/javax/lang/model/element/RecordComponentElement.html
Let's make a separate issue and remove all problematic records from this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
