Re: [PR] Allow skip cache factor to be updated dynamically [lucene]

sgup432 commented on PR #14412: URL: https://github.com/apache/lucene/pull/14412#issuecomment-2763186278 @jpountz Added a CHANGES entry. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] Allow skip cache factor to be updated dynamically [lucene]

sgup432 commented on code in PR #14412: URL: https://github.com/apache/lucene/pull/14412#discussion_r2019109527 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -122,12 +123,30 @@ public LRUQueryCache( long maxRamBytesUsed, Predicate leave

Re: [PR] Allow skip cache factor to be updated dynamically [lucene]

jpountz commented on PR #14412: URL: https://github.com/apache/lucene/pull/14412#issuecomment-2765833637 Sorry I'm not sure I get your suggestion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Allow skip cache factor to be updated dynamically [lucene]

sgup432 commented on PR #14412: URL: https://github.com/apache/lucene/pull/14412#issuecomment-2766561573 @jpountz Thanks for expanding on the reasoning above w.r.t. query cache usage. I was working on [refactoring](https://github.com/apache/lucene/issues/14222) query cache so that it is no

Re: [PR] Allow skip cache factor to be updated dynamically [lucene]

kkewwei commented on PR #14412: URL: https://github.com/apache/lucene/pull/14412#issuecomment-2764949091 Thank you for your reply. I understand your perspective. You aim to optimize execution efficiency rather than focus on cache optimization. In certain rare scenarios, the querycache

Re: [PR] Allow skip cache factor to be updated dynamically [lucene]

jpountz commented on PR #14412: URL: https://github.com/apache/lucene/pull/14412#issuecomment-2764454882 > I am wondering if we should also make maxRamBytesUsed dynamic as well. What is your use-case for tuning it? Related to my comment on the issue linked to this PR, I worry a bit ab

Re: [PR] Allow skip cache factor to be updated dynamically [lucene]

jpountz merged PR #14412: URL: https://github.com/apache/lucene/pull/14412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Allow skip cache factor to be updated dynamically [lucene]

sgup432 commented on code in PR #14412: URL: https://github.com/apache/lucene/pull/14412#discussion_r2019868684 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -142,6 +142,20 @@ public LRUQueryCache( missCount = new LongAdder(); } + public f

Re: [PR] Allow skip cache factor to be updated dynamically [lucene]

sgup432 commented on code in PR #14412: URL: https://github.com/apache/lucene/pull/14412#discussion_r2019870708 ## lucene/CHANGES.txt: ## @@ -47,6 +47,7 @@ Other - * GITHUB#14229: Bump minimum required Java version to 25 +* GITHUB#14412: Allow skip cache

Re: [PR] Allow skip cache factor to be updated dynamically [lucene]

sgup432 commented on code in PR #14412: URL: https://github.com/apache/lucene/pull/14412#discussion_r2019868684 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -142,6 +142,20 @@ public LRUQueryCache( missCount = new LongAdder(); } + public f

Re: [PR] Allow skip cache factor to be updated dynamically [lucene]

kkewwei commented on PR #14412: URL: https://github.com/apache/lucene/pull/14412#issuecomment-2763254947 I am wondering if we should also make `maxRamBytesUsed` dynamic as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Allow skip cache factor to be updated dynamically [lucene]

jpountz commented on code in PR #14412: URL: https://github.com/apache/lucene/pull/14412#discussion_r2019755560 ## lucene/CHANGES.txt: ## @@ -47,6 +47,7 @@ Other - * GITHUB#14229: Bump minimum required Java version to 25 +* GITHUB#14412: Allow skip cache

Re: [PR] Allow skip cache factor to be updated dynamically [lucene]

sgup432 commented on code in PR #14412: URL: https://github.com/apache/lucene/pull/14412#discussion_r2019729847 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -142,6 +144,14 @@ public LRUQueryCache( missCount = new LongAdder(); } + public f

Re: [PR] Allow skip cache factor to be updated dynamically [lucene]

jpountz commented on code in PR #14412: URL: https://github.com/apache/lucene/pull/14412#discussion_r2019386671 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -125,7 +125,9 @@ public LRUQueryCache( this.maxSize = maxSize; this.maxRamBytesUse

Re: [PR] Allow skip cache factor to be updated dynamically [lucene]

sgup432 commented on code in PR #14412: URL: https://github.com/apache/lucene/pull/14412#discussion_r2019115721 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -269,8 +292,8 @@ boolean requiresEviction() { } CacheAndCount get(Query key, IndexRe

Re: [PR] Allow skip cache factor to be updated dynamically [lucene]

sgup432 commented on code in PR #14412: URL: https://github.com/apache/lucene/pull/14412#discussion_r2019109207 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -142,6 +161,10 @@ public LRUQueryCache( missCount = new LongAdder(); } + AtomicRe

Re: [PR] Allow skip cache factor to be updated dynamically [lucene]

sgup432 commented on code in PR #14412: URL: https://github.com/apache/lucene/pull/14412#discussion_r2019087636 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -99,7 +100,7 @@ public class LRUQueryCache implements QueryCache, Accountable { private

Re: [PR] Allow skip cache factor to be updated dynamically [lucene]

sgup432 commented on code in PR #14412: URL: https://github.com/apache/lucene/pull/14412#discussion_r2019040588 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -122,12 +123,30 @@ public LRUQueryCache( long maxRamBytesUsed, Predicate leave

Re: [PR] Allow skip cache factor to be updated dynamically [lucene]

jpountz commented on code in PR #14412: URL: https://github.com/apache/lucene/pull/14412#discussion_r2018865956 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -122,12 +123,30 @@ public LRUQueryCache( long maxRamBytesUsed, Predicate leave

Re: [PR] Allow skip cache factor to be updated dynamically [lucene]

sgup432 commented on code in PR #14412: URL: https://github.com/apache/lucene/pull/14412#discussion_r2017693759 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -122,12 +123,30 @@ public LRUQueryCache( long maxRamBytesUsed, Predicate leave

Re: [PR] Allow skip cache factor to be updated dynamically [lucene]

sgup432 commented on code in PR #14412: URL: https://github.com/apache/lucene/pull/14412#discussion_r2017693759 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -122,12 +123,30 @@ public LRUQueryCache( long maxRamBytesUsed, Predicate leave

Re: [PR] Allow skip cache factor to be updated dynamically [lucene]

jpountz commented on code in PR #14412: URL: https://github.com/apache/lucene/pull/14412#discussion_r2017616847 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -99,7 +100,7 @@ public class LRUQueryCache implements QueryCache, Accountable { private

Re: [PR] Allow skip cache factor to be updated dynamically [lucene]

sgup432 commented on PR #14412: URL: https://github.com/apache/lucene/pull/14412#issuecomment-2756202209 @jpountz Might need your review as discussed in https://github.com/apache/lucene/issues/14183 -- This is an automated message from the Apache Git Service. To respond to the message, pl

[PR] Allow skip cache factor to be updated dynamically [lucene]

sgup432 opened a new pull request, #14412: URL: https://github.com/apache/lucene/pull/14412 ### Description Related issue - https://github.com/apache/lucene/issues/14183 This change allows skip cache factor to be updated dynamically within LRU query cache. This can be done by passi