jpountz commented on code in PR #14412:
URL: https://github.com/apache/lucene/pull/14412#discussion_r2019386671
##########
lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java:
##########
@@ -125,7 +125,9 @@ public LRUQueryCache(
this.maxSize = maxSize;
this.maxRamBytesUsed = maxRamBytesUsed;
this.leavesToCache = leavesToCache;
- if (skipCacheFactor >= 1 == false) { // NaN >= 1 evaluates false
+ if (skipCacheFactor < 1) { //
+ // NaN >= 1
+ // evaluates false
Review Comment:
Please revert so that we keep rejecting skipCacheFactor=Float.NaN?
##########
lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java:
##########
@@ -142,6 +144,14 @@ public LRUQueryCache(
missCount = new LongAdder();
}
+ public float getSkipCacheFactor() {
+ return skipCacheFactor;
+ }
+
+ public void setSkipCacheFactor(float skipCacheFactor) {
+ this.skipCacheFactor = skipCacheFactor;
+ }
Review Comment:
Can you add javadocs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
