sgup432 commented on code in PR #14412:
URL: https://github.com/apache/lucene/pull/14412#discussion_r2019087636
##########
lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java:
##########
@@ -99,7 +100,7 @@ public class LRUQueryCache implements QueryCache,
Accountable {
private final Map<IndexReader.CacheKey, LeafCache> cache;
private final ReentrantReadWriteLock.ReadLock readLock;
private final ReentrantReadWriteLock.WriteLock writeLock;
- private final float skipCacheFactor;
+ private final AtomicReference<Float> skipCacheFactor;
Review Comment:
Yeah considering we are just doing set/get, volatile should be enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
