github-actions[bot] commented on PR #13948:
URL: https://github.com/apache/lucene/pull/13948#issuecomment-2709158794
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
github-actions[bot] commented on PR #13948:
URL: https://github.com/apache/lucene/pull/13948#issuecomment-2673020214
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
github-actions[bot] commented on PR #13948:
URL: https://github.com/apache/lucene/pull/13948#issuecomment-2568551704
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
iverase commented on code in PR #13948:
URL: https://github.com/apache/lucene/pull/13948#discussion_r1890139004
##
lucene/core/src/java/org/apache/lucene/util/RandomAccessInputRef.java:
##
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
jpountz commented on code in PR #13948:
URL: https://github.com/apache/lucene/pull/13948#discussion_r188862
##
lucene/core/src/test/org/apache/lucene/util/TestBytesRefArray.java:
##
@@ -43,8 +44,17 @@ public void testAppend() throws IOException {
for (int i = 0; i < e
iverase commented on code in PR #13948:
URL: https://github.com/apache/lucene/pull/13948#discussion_r1877904767
##
lucene/core/src/java/org/apache/lucene/search/FieldComparator.java:
##
@@ -234,7 +235,8 @@ public TermValComparator(int numHits, String field, boolean
sortMissingL
iverase commented on code in PR #13948:
URL: https://github.com/apache/lucene/pull/13948#discussion_r1877894071
##
lucene/core/src/java/org/apache/lucene/util/UnicodeUtil.java:
##
@@ -627,35 +629,58 @@ public static String toHexString(String s) {
}
/**
- * Interprets t
iverase commented on code in PR #13948:
URL: https://github.com/apache/lucene/pull/13948#discussion_r1877892464
##
lucene/core/src/java/org/apache/lucene/store/RandomAccessInputDataInput.java:
##
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
iverase commented on code in PR #13948:
URL: https://github.com/apache/lucene/pull/13948#discussion_r1877891198
##
lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextDocValuesReader.java:
##
@@ -383,17 +392,31 @@ public long cost() {
@Override
p
jpountz commented on code in PR #13948:
URL: https://github.com/apache/lucene/pull/13948#discussion_r1876152549
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesProducer.java:
##
@@ -791,25 +792,26 @@ public BinaryDocValues getBinary(FieldInfo field) th
github-actions[bot] commented on PR #13948:
URL: https://github.com/apache/lucene/pull/13948#issuecomment-2467011723
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
iverase commented on PR #13948:
URL: https://github.com/apache/lucene/pull/13948#issuecomment-2439897160
I have a second iteration and I realise that this change can be easily done
if we introduce a new abstraction. I have called it `RandomAccessInputRef` and
it is equivalent to BytesRef b
jpountz commented on PR #13948:
URL: https://github.com/apache/lucene/pull/13948#issuecomment-2437732473
In my experience, binary doc values are more often used to encode structured
data, such as maps that help build scoring signals, geo shapes, etc. than
actual binary content, so this chan
iverase commented on code in PR #13948:
URL: https://github.com/apache/lucene/pull/13948#discussion_r1816323891
##
lucene/core/src/java/org/apache/lucene/store/RandomAccessInputDataInput.java:
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
iverase commented on code in PR #13948:
URL: https://github.com/apache/lucene/pull/13948#discussion_r1816322441
##
lucene/core/src/java/org/apache/lucene/store/RandomAccessInputDataInput.java:
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
iverase commented on code in PR #13948:
URL: https://github.com/apache/lucene/pull/13948#discussion_r1816321990
##
lucene/core/src/java/org/apache/lucene/index/BinaryDocValues.java:
##
@@ -33,4 +34,15 @@ protected BinaryDocValues() {}
* @return binary value
*/
public
jpountz commented on code in PR #13948:
URL: https://github.com/apache/lucene/pull/13948#discussion_r1812935475
##
lucene/core/src/java/org/apache/lucene/index/BinaryDocValues.java:
##
@@ -33,4 +34,15 @@ protected BinaryDocValues() {}
* @return binary value
*/
public
iverase opened a new pull request, #13948:
URL: https://github.com/apache/lucene/pull/13948
Following up this
[suggestion](https://github.com/apache/lucene/pull/12460#issuecomment-1715126194)
from @jpountz, here I propose to add a new method to the BinaryDocValues API
that returns the cont
18 matches
Mail list logo
