iverase commented on code in PR #13948: URL: https://github.com/apache/lucene/pull/13948#discussion_r1816323891
########## lucene/core/src/java/org/apache/lucene/store/RandomAccessInputDataInput.java: ########## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.store; + +import java.io.IOException; + +/** + * DataInput backed by a {@link RandomAccessInput}. <b>WARNING:</b> This class omits all low-level + * checks. + * + * @lucene.experimental + */ +public final class RandomAccessInputDataInput extends DataInput { + + private RandomAccessInput input; + + private long pos; + + public RandomAccessInputDataInput() {} + + // NOTE: sets pos to 0, which is not right if you had + // called reset w/ non-zero offset!! + public void rewind() { + pos = 0; + } + + public long getPosition() { + return pos; + } + + public void setPosition(long pos) { + this.pos = pos; + } + + public void reset(RandomAccessInput input) { + this.input = input; + pos = 0; + } + + public long length() { + return input.length(); + } + + @Override + public void skipBytes(long count) { + pos += count; + } + + @Override + public short readShort() throws IOException { + try { + return input.readShort(pos); + } finally { + pos += Short.BYTES; Review Comment: This class is a copy / paste from ByteArrayDataInput so it makes me wonder if that's something we need to change in that implementation too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
