iverase commented on code in PR #13948:
URL: https://github.com/apache/lucene/pull/13948#discussion_r1816321990


##########
lucene/core/src/java/org/apache/lucene/index/BinaryDocValues.java:
##########
@@ -33,4 +34,15 @@ protected BinaryDocValues() {}
    * @return binary value
    */
   public abstract BytesRef binaryValue() throws IOException;
+
+  /**
+   * Returns the binary value as a {@link RandomAccessInput} for the current 
document ID. The bytes
+   * start at position 0 up to {@link RandomAccessInput#length()}. It is 
illegal to call this method
+   * after {@link #advanceExact(int)} returned {@code false}.

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to