iverase commented on code in PR #13948: URL: https://github.com/apache/lucene/pull/13948#discussion_r1877904767
########## lucene/core/src/java/org/apache/lucene/search/FieldComparator.java: ########## @@ -234,7 +235,8 @@ public TermValComparator(int numHits, String field, boolean sortMissingLast) { private BytesRef getValueForDoc(int doc) throws IOException { if (docTerms.advanceExact(doc)) { - return docTerms.binaryValue(); + bytesRefBuilder.copyBytes(docTerms.randomAccessInputValue()); + return bytesRefBuilder.get(); Review Comment: agree, it will require a bit of rework here but should be doable. Maybe as a follow up? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org