rmuir commented on PR #14820:
URL: https://github.com/apache/lucene/pull/14820#issuecomment-2989816496
Several options if we want to use this linter in CI (i'm concerned the
java-gradle based one may be slow):
* get binaries from releases: https://gitlab.com/greut/eclint/-/releases
* b
rmuir commented on PR #14820:
URL: https://github.com/apache/lucene/pull/14820#issuecomment-2989794455
all done, took a few iterations due to that gnarly encoding error and
dealing with a long-tail of weird stuff.
Checker passes now:
```
$ time eclint
real 0m3.708s
use
rmuir commented on issue #14819:
URL: https://github.com/apache/lucene/issues/14819#issuecomment-2989770075
I'm having decent luck with the fast https://gitlab.com/greut/eclint, which
allows disabling some of the problems in the .editorconfig with `eclint_`
prefix. There are many categories
easyice commented on issue #14803:
URL: https://github.com/apache/lucene/issues/14803#issuecomment-2989753149
@rmuir You are right, it needs to be sorted on the timestamp field. In
addition to enabling delta-compression on the timestamp field, index sorting
brings another benefit: when sort
rmuir commented on issue #14803:
URL: https://github.com/apache/lucene/issues/14803#issuecomment-2989679301
@easyice Something like DELTA+FOR shouldn't require any cache, right? To me
that is a different problem with other challenges: index would need to be e.g.
sorted on timestamp field fo
rmuir commented on issue #14819:
URL: https://github.com/apache/lucene/issues/14819#issuecomment-2989648867
It looks to me like https://github.com/ec4j/editorconfig-gradle-plugin might
be exactly what is wanted here for the build to keep this tidy.
its TextLinter will address the comm
rmuir commented on code in PR #14818:
URL: https://github.com/apache/lucene/pull/14818#discussion_r2157934763
##
lucene/queryparser/docs/xml/LuceneContribQuery.dtd.html:
##
@@ -27,7 +27,7 @@
BooleanQuerys implement Boolean logic which controls how multiple Clauses
should be
github-actions[bot] commented on PR #14818:
URL: https://github.com/apache/lucene/pull/14818#issuecomment-2989632943
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog label to
it and you will stop
rmuir opened a new pull request, #14820:
URL: https://github.com/apache/lucene/pull/14820
Rather than have editors introduce these changes incrementally in unrelated
PRs over time, fix them in one commit which may be added to
.git-blame-ignore-revs as a followup commit.
Steps perform
rmuir opened a new issue, #14819:
URL: https://github.com/apache/lucene/issues/14819
### Description
editorconfig with aggressive settings was applied to all files, but without
fixing any existing problems or preventing new ones.
It causes the issue that when editing any impact
vsop-479 commented on code in PR #14814:
URL: https://github.com/apache/lucene/pull/14814#discussion_r2157890563
##
lucene/core/src/java/org/apache/lucene/util/PriorityQueue.java:
##
@@ -342,4 +342,13 @@ public T next() {
}
};
}
+
+ /**
+ * Returns {@code true}
vsop-479 commented on code in PR #14814:
URL: https://github.com/apache/lucene/pull/14814#discussion_r2157867142
##
lucene/core/src/java/org/apache/lucene/util/PriorityQueue.java:
##
@@ -342,4 +342,13 @@ public T next() {
}
};
}
+
+ /**
+ * Returns {@code true}
github-actions[bot] commented on PR #14818:
URL: https://github.com/apache/lucene/pull/14818#issuecomment-2989516049
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog label to
it and you will stop
rmuir opened a new pull request, #14818:
URL: https://github.com/apache/lucene/pull/14818
These html files (whether manually or automatically generated) have
inconsistent usage of 'gt' and 'amp' html entities: sometimes they do it,
sometimes they neglect to use it.
I added rules to t
easyice commented on issue #14803:
URL: https://github.com/apache/lucene/issues/14803#issuecomment-2989482091
Yeah, I’ve been thinking about this. Elasticsearch now supports a
time_series index mode with DELTA + FOR encoding on doc values. In time series
or logging scenarios, storage cost u
github-actions[bot] commented on PR #14738:
URL: https://github.com/apache/lucene/pull/14738#issuecomment-2989473038
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
rmuir commented on issue #14787:
URL: https://github.com/apache/lucene/issues/14787#issuecomment-2989181352
@dweiss another one to investigate as it advertises linting capabilities
too: https://github.com/nvuillam/npm-groovy-lint
--
This is an automated message from the Apache Git Service
rmuir commented on PR #14740:
URL: https://github.com/apache/lucene/pull/14740#issuecomment-2989130686
.editorconfig is not an intellij specific file. It is parsed and respected
by many editors, even ones you may not consider, such as github repository
editor in the browser UI. So the file
dsmiley commented on PR #14740:
URL: https://github.com/apache/lucene/pull/14740#issuecomment-2989124763
I'm confused how the presence of an `.editorconfig` resulted in errors; can
you elaborate how that could happen? Judging from your commit here just
recently, was this a minor glitch due
dweiss commented on issue #14787:
URL: https://github.com/apache/lucene/issues/14787#issuecomment-2989037837
I just went with the simplest route which allowed me to reformat existing
code automatically and keep it sane. If it feels too heavy - we can turn it off
by default (and periodically
rmuir commented on issue #14787:
URL: https://github.com/apache/lucene/issues/14787#issuecomment-2989031043
That's not an argument for it either, I haven't tried it out on our
codebase. Just a guess as to why you aren't finding lots of alternatives.
--
This is an automated message from th
rmuir commented on issue #14787:
URL: https://github.com/apache/lucene/issues/14787#issuecomment-2988998672
prettier supports many languages (including java) and there are plugins for
groovy. Because of its popularity esp. on the front-end side, its much more
widely used, and has good edito
rmuir merged PR #14812:
URL: https://github.com/apache/lucene/pull/14812
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
msokolov commented on PR #14740:
URL: https://github.com/apache/lucene/pull/14740#issuecomment-2988904498
This got me worried so I checked emacs editorconfig support
https://www.gnu.org/software/emacs/manual/html_node/emacs/EditorConfig-support.html
and it turns out it is off by def
msokolov commented on PR #14740:
URL: https://github.com/apache/lucene/pull/14740#issuecomment-2988905484
This got me worried so I checked emacs editorconfig support
https://www.gnu.org/software/emacs/manual/html_node/emacs/EditorConfig-support.html
and it turns out it is off by default, ph
rmuir commented on PR #14740:
URL: https://github.com/apache/lucene/pull/14740#issuecomment-2988890817
> I think you're missing a point of the value of this. It's _complementary_
with Spotless (or similar). It helps us write code formatted according to the
project's standards during the wri
rmuir commented on PR #14740:
URL: https://github.com/apache/lucene/pull/14740#issuecomment-2988878571
> The existing editorconfig was redundant with information in this
editorconfig, so I simply removed it. I'll merge this tonight.
That's not true, now a maximum line length is set, i
dweiss commented on PR #14764:
URL: https://github.com/apache/lucene/pull/14764#issuecomment-2988835937
https://github.com/apache/lucene/blob/main/help/workflow.txt#L15-L19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
dweiss commented on PR #14764:
URL: https://github.com/apache/lucene/pull/14764#issuecomment-2988835226
The standard: ```./gradlew check``` will do the job. You can use it on
branch_10x as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
dweiss commented on issue #14787:
URL: https://github.com/apache/lucene/issues/14787#issuecomment-2988833608
I know. I wish there was a simpler alternative. I am surprised groovy
doesn't include a formatter (since it has an ast parser api).
--
This is an automated message from the Apache
mikemccand commented on PR #14764:
URL: https://github.com/apache/lucene/pull/14764#issuecomment-2988527500
Thank you @dweiss for all the awesome attention to Lucene's build infra!
I used to run `./gradlew precommit` -- is there an equivalent in the new
shiny gradle plugin based build
mikemccand commented on PR #14178:
URL: https://github.com/apache/lucene/pull/14178#issuecomment-2988466651
Thanks @kaivalnp -- I think this is ready -- I will try to merge later today
or early tomorrow! Sandboxy fun experimental Codec...
--
This is an automated message from the Apache G
tteofili merged PR #14816:
URL: https://github.com/apache/lucene/pull/14816
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.ap
romseygeek merged PR #14807:
URL: https://github.com/apache/lucene/pull/14807
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
stefanvodita commented on PR #14807:
URL: https://github.com/apache/lucene/pull/14807#issuecomment-2988281014
Sorry, my bad, you're right!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
uschindler commented on issue #14787:
URL: https://github.com/apache/lucene/issues/14787#issuecomment-2988224422
💩
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
romseygeek commented on PR #14807:
URL: https://github.com/apache/lucene/pull/14807#issuecomment-2988226115
It's a package-private class so not part of the public API - I don't think I
would normally add a CHANGES entry here?
--
This is an automated message from the Apache Git Service.
To
dsmiley merged PR #14740:
URL: https://github.com/apache/lucene/pull/14740
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
thecoop commented on PR #14817:
URL: https://github.com/apache/lucene/pull/14817#issuecomment-298814
The subclasses that are remaining after this PR are:
* `TermsMergeQueue`. This has some additional state in the `stack` variable
* `FieldValueHitQueue`. This is further subclasse
github-actions[bot] commented on PR #14817:
URL: https://github.com/apache/lucene/pull/14817#issuecomment-2988081467
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog label to
it and you will stop
github-actions[bot] commented on PR #14817:
URL: https://github.com/apache/lucene/pull/14817#issuecomment-2988077064
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog label to
it and you will stop
github-actions[bot] commented on PR #14817:
URL: https://github.com/apache/lucene/pull/14817#issuecomment-2988043480
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog label to
it and you will stop
thecoop opened a new pull request, #14817:
URL: https://github.com/apache/lucene/pull/14817
A 3rd set of `PriorityQueue` conversions. These ones are more controversial,
and so need some specific review and discussion
--
This is an automated message from the Apache Git Service.
To respond
github-actions[bot] commented on PR #14816:
URL: https://github.com/apache/lucene/pull/14816#issuecomment-2988023256
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog label to
it and you will stop
tteofili opened a new pull request, #14816:
URL: https://github.com/apache/lucene/pull/14816
This simply exposes `AbstractKnnQuery#searchStrategy`.
This might be useful to debug/inspect and perform optimizations based on
different such strategies for consumers of such queries.
--
This
uschindler commented on PR #14811:
URL: https://github.com/apache/lucene/pull/14811#issuecomment-2987855642
Thanks Robert! As always: nice discussions. I will improve the signatures
file documentation to give a hint how the inner class binary names look like
(give an example).
--
This is
rmuir merged PR #14811:
URL: https://github.com/apache/lucene/pull/14811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
jimczi commented on issue #14681:
URL: https://github.com/apache/lucene/issues/14681#issuecomment-2987729521
Thanks for opening this and for all the work going into expanding vector
search in Lucene.
That said, I’m a bit concerned about the growing number of options being
proposed th
rmuir commented on PR #14804:
URL: https://github.com/apache/lucene/pull/14804#issuecomment-2987658166
@dweiss yeah, the parsers are generally fast. and the java one in particular
is very nice. Of course they are doing a lot less, too.
parser test framework tracks the performance in
rmuir commented on PR #14811:
URL: https://github.com/apache/lucene/pull/14811#issuecomment-2987609996
With help of @uschindler, this check is a bit different than how the
error-prone rules implement it, but more thorough.
The stated goal of the error-prone check is to prevent turnin
github-actions[bot] commented on PR #14811:
URL: https://github.com/apache/lucene/pull/14811#issuecomment-2987598490
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog label to
it and you will stop
uschindler commented on code in PR #14811:
URL: https://github.com/apache/lucene/pull/14811#discussion_r2156684715
##
gradle/validation/forbidden-apis/defaults.all.txt:
##
@@ -76,3 +76,9 @@ java.lang.Math#fma(float,float,float)
java.lang.Math#fma(double,double,double)
java.l
stefanvodita merged PR #14815:
URL: https://github.com/apache/lucene/pull/14815
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucen
stefanvodita commented on code in PR #14814:
URL: https://github.com/apache/lucene/pull/14814#discussion_r2156665168
##
lucene/core/src/java/org/apache/lucene/util/PriorityQueue.java:
##
@@ -342,4 +342,13 @@ public T next() {
}
};
}
+
+ /**
+ * Returns {@code t
uschindler commented on code in PR #14811:
URL: https://github.com/apache/lucene/pull/14811#discussion_r2156654935
##
gradle/validation/forbidden-apis/defaults.all.txt:
##
@@ -76,3 +76,15 @@ java.lang.Math#fma(float,float,float)
java.lang.Math#fma(double,double,double)
java.
vsop-479 commented on PR #14813:
URL: https://github.com/apache/lucene/pull/14813#issuecomment-2987535916
Benchmark:
```
Benchmark Mode Cnt ScoreError
Units
PriorityQueueBenchmark.getTopNWithHeap thrpt 15 ≈ 10⁻³
ops/us
github-actions[bot] commented on PR #14811:
URL: https://github.com/apache/lucene/pull/14811#issuecomment-2987524629
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog label to
it and you will stop
github-actions[bot] commented on PR #14815:
URL: https://github.com/apache/lucene/pull/14815#issuecomment-2987503989
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog label to
it and you will stop
rmuir commented on code in PR #14811:
URL: https://github.com/apache/lucene/pull/14811#discussion_r2156628908
##
gradle/validation/forbidden-apis/defaults.all.txt:
##
@@ -76,3 +76,15 @@ java.lang.Math#fma(float,float,float)
java.lang.Math#fma(double,double,double)
java.lang.
rmuir commented on code in PR #14812:
URL: https://github.com/apache/lucene/pull/14812#discussion_r2156626300
##
gradle/validation/ast-grep/rules/java-patterns.yml:
##
@@ -0,0 +1,24 @@
+# Banned Lucene source patterns
+# Historically implemented as regexes which are more difficu
vsop-479 opened a new pull request, #14815:
URL: https://github.com/apache/lucene/pull/14815
### Description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dweiss commented on PR #14804:
URL: https://github.com/apache/lucene/pull/14804#issuecomment-2987375548
FYI - spotless runs google java format in a single-thread, that's part of
the reason it's sluggish. But it's still an order of magnitude slower than the
c parser. I ran this, for the fun
github-actions[bot] commented on PR #14814:
URL: https://github.com/apache/lucene/pull/14814#issuecomment-2987489716
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog label to
it and you will stop
github-actions[bot] commented on PR #14812:
URL: https://github.com/apache/lucene/pull/14812#issuecomment-2987487274
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog label to
it and you will stop
rmuir commented on code in PR #14812:
URL: https://github.com/apache/lucene/pull/14812#discussion_r2156621252
##
gradle/validation/ast-grep/rules/java-patterns.yml:
##
@@ -0,0 +1,24 @@
+# Banned Lucene source patterns
+# Historically implemented as regexes which are more difficu
vsop-479 opened a new pull request, #14814:
URL: https://github.com/apache/lucene/pull/14814
### Description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dweiss commented on issue #14787:
URL: https://github.com/apache/lucene/issues/14787#issuecomment-2987473386
It's in a plugin that coordinates eclipse-gradle interaction. The bug is
simple but I don't think I want to go down and try to fix that particular code,
sorry - too hairy.
ht
dweiss closed issue #14787: spotlessGradleScripts doesn't work with
whitespace-paths on Windows
URL: https://github.com/apache/lucene/issues/14787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
vsop-479 opened a new pull request, #14813:
URL: https://github.com/apache/lucene/pull/14813
### Description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
rmuir merged PR #14810:
URL: https://github.com/apache/lucene/pull/14810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
github-actions[bot] commented on PR #14813:
URL: https://github.com/apache/lucene/pull/14813#issuecomment-2987467232
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog label to
it and you will stop
github-actions[bot] commented on PR #14812:
URL: https://github.com/apache/lucene/pull/14812#issuecomment-2987450127
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog label to
it and you will stop
rmuir commented on code in PR #14812:
URL: https://github.com/apache/lucene/pull/14812#discussion_r2156593895
##
gradle/validation/ast-grep/rules/java-patterns.yml:
##
@@ -0,0 +1,24 @@
+# Banned Lucene source patterns
+# Historically implemented as regexes which are more difficu
uschindler commented on PR #14811:
URL: https://github.com/apache/lucene/pull/14811#issuecomment-2987067126
> Source of the check:
https://github.com/google/error-prone/blob/master/core/src/main/java/com/google/errorprone/bugpatterns/BanClassLoader.java
>
> It also checks for explicit
uschindler commented on PR #14811:
URL: https://github.com/apache/lucene/pull/14811#issuecomment-2987082206
Final note abozut subclasses: You need to add all ctors of sublasses of
Classloader which reside in JDK. Now you might argue that one could define a
subclass in user code (extending U
uschindler commented on PR #14811:
URL: https://github.com/apache/lucene/pull/14811#issuecomment-2987071310
In addition the list on errorprone is incomplete. Since Java 16 there's
`Lookup#defineHiddenClass(**) & others (see expressions module).
--
This is an automated message from the Apa
uschindler commented on code in PR #14811:
URL: https://github.com/apache/lucene/pull/14811#discussion_r2156332399
##
gradle/validation/forbidden-apis/defaults.all.txt:
##
@@ -76,3 +76,15 @@ java.lang.Math#fma(float,float,float)
java.lang.Math#fma(double,double,double)
java.
uschindler commented on code in PR #14811:
URL: https://github.com/apache/lucene/pull/14811#discussion_r2156332399
##
gradle/validation/forbidden-apis/defaults.all.txt:
##
@@ -76,3 +76,15 @@ java.lang.Math#fma(float,float,float)
java.lang.Math#fma(double,double,double)
java.
gf2121 commented on issue #14803:
URL: https://github.com/apache/lucene/issues/14803#issuecomment-2987035325
OLAP engines splits format to `codec` and `compression`, both configurable.
For example, you can:
* Use `ForUtil` codec and `LZ4` compression in normal filesystem, cache
manag
dweiss commented on code in PR #14812:
URL: https://github.com/apache/lucene/pull/14812#discussion_r2156302413
##
gradle/validation/ast-grep/rules/java-patterns.yml:
##
@@ -0,0 +1,24 @@
+# Banned Lucene source patterns
+# Historically implemented as regexes which are more diffic
dweiss commented on code in PR #14812:
URL: https://github.com/apache/lucene/pull/14812#discussion_r2156296401
##
gradle/validation/ast-grep/rules/java-patterns.yml:
##
@@ -0,0 +1,24 @@
+# Banned Lucene source patterns
+# Historically implemented as regexes which are more diffic
uschindler commented on code in PR #14811:
URL: https://github.com/apache/lucene/pull/14811#discussion_r2156288518
##
gradle/validation/forbidden-apis/defaults.all.txt:
##
@@ -76,3 +76,15 @@ java.lang.Math#fma(float,float,float)
java.lang.Math#fma(double,double,double)
java.
82 matches
Mail list logo
