Re: [I] Compare the missing value with the top value even after the hit queue is full [lucene]

2024-08-13 Thread via GitHub
bugmakerr commented on issue #13643: URL: https://github.com/apache/lucene/issues/13643#issuecomment-2287906685 > I wonder if it's possible for this method to ever be invoked with a document that's "before" an established "after" value. This method is related to missing values, i

Re: [PR] Improve BaseRangeFieldQueryTestCase#verify failure output [lucene]

2024-08-13 Thread via GitHub
github-actions[bot] commented on PR #13382: URL: https://github.com/apache/lucene/pull/13382#issuecomment-2287479347 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Udpate ReadTask to not rely on search(Query, Collector) [lucene]

2024-08-13 Thread via GitHub
github-actions[bot] commented on PR #13602: URL: https://github.com/apache/lucene/pull/13602#issuecomment-2287478715 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Optimize decoding blocks of postings using the vector API. (#13636) [lucene]

2024-08-13 Thread via GitHub
uschindler commented on PR #13652: URL: https://github.com/apache/lucene/pull/13652#issuecomment-2287192249 > I don't remember, did we backport Chris changes to java 20, too? No we did not. Nevertheless, maybe the constants code backport would be cool. -- This is an automated messag

Re: [PR] Optimize decoding blocks of postings using the vector API. (#13636) [lucene]

2024-08-13 Thread via GitHub
uschindler commented on PR #13652: URL: https://github.com/apache/lucene/pull/13652#issuecomment-2287184150 Maybe for consistency it would be good. I don't remember, did we backport Chris changes to java 20, too? -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] Slightly speed up decoding blocks of postings/freqs/positions. [lucene]

2024-08-13 Thread via GitHub
jpountz closed pull request #13631: Slightly speed up decoding blocks of postings/freqs/positions. URL: https://github.com/apache/lucene/pull/13631 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Optimize decoding blocks of postings using the vector API. (#13636) [lucene]

2024-08-13 Thread via GitHub
jpountz commented on PR #13652: URL: https://github.com/apache/lucene/pull/13652#issuecomment-2287039270 @uschindler I was wondering while doing this backport: would you apply the same refactoring wrt `PanamaVectorConstants` to the `src/java20` folder, or would you keep it as-is? -- This

Re: [PR] Fix eclipse ide settings generation [lucene]

2024-08-13 Thread via GitHub
dweiss commented on PR #13649: URL: https://github.com/apache/lucene/pull/13649#issuecomment-2287039302 > Hi, The main problem was that it wasn't able to find the task "eclipse". You hacked around this by converting the root project to a java project. Well, I didn't hack around it - i

Re: [I] `gradlew eclipse` no longer works [lucene]

2024-08-13 Thread via GitHub
dweiss commented on issue #13638: URL: https://github.com/apache/lucene/issues/13638#issuecomment-2287035129 Which git version are you using? I think tidy will "clean up" those toml files by reordering them - there is a plugin for doing this. This plugin may be writing crlfs... but I don't

Re: [PR] Optimize decoding blocks of postings using the vector API. [lucene]

2024-08-13 Thread via GitHub
jpountz merged PR #13636: URL: https://github.com/apache/lucene/pull/13636 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

[PR] Add a Better Binary Quantizer (RaBitQ) format for dense vectors [lucene]

2024-08-13 Thread via GitHub
benwtrent opened a new pull request, #13651: URL: https://github.com/apache/lucene/pull/13651 # Not only a draft, but a very rough one indeed Not opening for the sake of review, but just openness and for those curious about the work. # Highlevel design RaBitQ is basicall

[I] Add higher quantization level for kNN vector search [lucene]

2024-08-13 Thread via GitHub
benwtrent opened a new issue, #13650: URL: https://github.com/apache/lucene/issues/13650 ### Description There have been multiple discussions around supporting higher vector quantization levels (e.g. more than scalar quantization can provide). We (elastic) have been doing some

Re: [I] Compare the missing value with the top value even after the hit queue is full [lucene]

2024-08-13 Thread via GitHub
gsmiller commented on issue #13643: URL: https://github.com/apache/lucene/issues/13643#issuecomment-2286585133 Thanks @bugmakerr. I was thinking about this change a bit more and wondering how you came across the issue. I definitely agree there's an opportunity here to tighten up the log

Re: [I] `gradlew eclipse` no longer works [lucene]

2024-08-13 Thread via GitHub
uschindler commented on issue #13638: URL: https://github.com/apache/lucene/issues/13638#issuecomment-2286541359 I will check what's wrong with my toml file. I have crlf handling completely switched off in my git config. It should not touch any line endings. -- This is an automated messag

Re: [PR] Fix eclipse ide settings generation [lucene]

2024-08-13 Thread via GitHub
uschindler commented on PR #13649: URL: https://github.com/apache/lucene/pull/13649#issuecomment-2286522904 Hi, The main problem was that it wasn't able to find the task "eclipse". You hacked around this by converting the root project to a java project. I have no idea how it was be

Re: [I] Lucene99FlatVectorsReader.getFloatVectorValues(): NPE: Cannot read field "vectorEncoding" because "fieldEntry" is null [lucene]

2024-08-13 Thread via GitHub
msokolov commented on issue #13626: URL: https://github.com/apache/lucene/issues/13626#issuecomment-2286421337 OK, I don't know if we want to go back and revisit all this stuff, but it seems to me as if we stumbled into requiring PerFieldCodec without necessarily realizing we had done so?

[PR] Fix eclipse ide settings generation [lucene]

2024-08-13 Thread via GitHub
dweiss opened a new pull request, #13649: URL: https://github.com/apache/lucene/pull/13649 A fix to https://github.com/apache/lucene/issues/13638. I don't see how the refactoring in https://github.com/apache/lucene/pull/13484 had something to do with the ide setup breaking. There are

Re: [I] Try applying bipartite graph reordering to KNN graph node ids [lucene]

2024-08-13 Thread via GitHub
msokolov commented on issue #13565: URL: https://github.com/apache/lucene/issues/13565#issuecomment-2286395734 One thing that confused me about the `BPIndexReorderer` solution: what happens if the IWC has indexSort configured *and* we apply the BPReorderingMergePolicy? I guess the index sor

Re: [I] Try applying bipartite graph reordering to KNN graph node ids [lucene]

2024-08-13 Thread via GitHub
msokolov commented on issue #13565: URL: https://github.com/apache/lucene/issues/13565#issuecomment-2286296865 Yes, I'd like this to be compatible with a different index sort for docids. I think it makes sense when you have hybrid search; keywords + semantic in the same query. But I suppose

Re: [I] testMergeStability failing for Knn formats [lucene]

2024-08-13 Thread via GitHub
msokolov commented on issue #13640: URL: https://github.com/apache/lucene/issues/13640#issuecomment-2286271018 found and fixed a branch_9x-only problem. Hopefully this calms down now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] gh-13640: Connect hnsw graph components when flushing [lucene]

2024-08-13 Thread via GitHub
msokolov merged PR #13648: URL: https://github.com/apache/lucene/pull/13648 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.ap

Re: [PR] gh-13640: Connect hnsw graph components when flushing [lucene]

2024-08-13 Thread via GitHub
msokolov commented on PR #13648: URL: https://github.com/apache/lucene/pull/13648#issuecomment-2286265814 addresses #13640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] gh-13640: Connect hnsw graph components when flushing [lucene]

2024-08-13 Thread via GitHub
msokolov opened a new pull request, #13648: URL: https://github.com/apache/lucene/pull/13648 It turns out that on branch9x we were not calling connectComponents on flush, only on merge, so the graph would grow when merging violating the stability test -- This is an automated message fr

Re: [I] Compare the missing value with the top value even after the hit queue is full [lucene]

2024-08-13 Thread via GitHub
bugmakerr commented on issue #13643: URL: https://github.com/apache/lucene/issues/13643#issuecomment-2285668553 > As it's currently written, I believe it will pass even without your change. @gsmiller Yes, you are right. The method `assertNonCompetitiveHitsAreSkipped` cannot make