bugmakerrrrrr commented on issue #13643: URL: https://github.com/apache/lucene/issues/13643#issuecomment-2285668553
> As it's currently written, I believe it will pass even without your change. @gsmiller Yes, you are right. The method `assertNonCompetitiveHitsAreSkipped` cannot make a right assertion, including the existing tests have the same problem. I wrote the test to compare the number of total hits before and after this change(14806+ vs. 513+). I will try to write a new test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
