gsmiller commented on issue #13643: URL: https://github.com/apache/lucene/issues/13643#issuecomment-2286585133
Thanks @bugmakerrrrrr. I was thinking about this change a bit more and wondering how you came across the issue. I definitely agree there's an opportunity here to tighten up the logic as you propose, but I wonder if it's possible for this method to ever be invoked with a document that's "before" an established "after" value. Did you actually hit this issue in the wild? I don't know the "wiring" of the field sort + "after" logic that well (and haven't had time to look through it in more detail in response to your PR), but I'm curious if there's actually a reachable code-path to hit this condition. Not opposed to adding this additional logic, just curious. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
