Re: [PR] Terminate automaton after matched the whole prefix for PrefixQuery. [lucene]

2024-04-12 Thread via GitHub
github-actions[bot] commented on PR #13072: URL: https://github.com/apache/lucene/pull/13072#issuecomment-2052720580 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Add BitVectors format and make flat vectors format easier to extend [lucene]

2024-04-12 Thread via GitHub
uschindler commented on PR #13288: URL: https://github.com/apache/lucene/pull/13288#issuecomment-2052630571 > Hey @uschindler I didn't want to move forward on merging without your thoughts. This is a separate idea from: #13200 Will check tomorrow. -- This is an automated message fr

Re: [PR] Add BitVectors format and make flat vectors format easier to extend [lucene]

2024-04-12 Thread via GitHub
benwtrent commented on PR #13288: URL: https://github.com/apache/lucene/pull/13288#issuecomment-2052231527 @jimczi I do like the further simplification. I can see about pulling in some of your ideas -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] Add BitVectors format and make flat vectors format easier to extend [lucene]

2024-04-12 Thread via GitHub
benwtrent commented on PR #13288: URL: https://github.com/apache/lucene/pull/13288#issuecomment-2052087989 Hey @uschindler I didn't want to move forward on merging without your thoughts. This is a separate idea from: https://github.com/apache/lucene/pull/13200 This change is more inl

Re: [PR] UnifiedHighlighter highlight on multiple fields (#13268) [lucene]

2024-04-12 Thread via GitHub
mayya-sharipova merged PR #13297: URL: https://github.com/apache/lucene/pull/13297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lu

[PR] Add more backwards compability tests for Scalar quantization [lucene]

2024-04-12 Thread via GitHub
benwtrent opened a new pull request, #13298: URL: https://github.com/apache/lucene/pull/13298 This adds more backwards compatibility coverage for scalar quantization. Adding a test that forces the older metadata version to be written and ensures that it can still be read. -- This is an a

Re: [PR] Converted FieldEntry to record [lucene]

2024-04-12 Thread via GitHub
jpountz commented on code in PR #13296: URL: https://github.com/apache/lucene/pull/13296#discussion_r1562691650 ## lucene/MIGRATE.md: ## @@ -180,6 +180,8 @@ access the members using method calls instead of field accesses. Affected classe - `IOContext`, `MergeInfo`, and `Flus

Re: [PR] Add BitVectors format and make flat vectors format easier to extend [lucene]

2024-04-12 Thread via GitHub
benwtrent commented on code in PR #13288: URL: https://github.com/apache/lucene/pull/13288#discussion_r1562457295 ## lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextKnnVectorsReader.java: ## @@ -472,9 +472,8 @@ private void readVector(byte[] value) throws IO

Re: [PR] UnifiedHighlighter highlight on multiple fields [lucene]

2024-04-12 Thread via GitHub
mayya-sharipova merged PR #13268: URL: https://github.com/apache/lucene/pull/13268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lu

Re: [PR] Add BitVectors format and make flat vectors format easier to extend [lucene]

2024-04-12 Thread via GitHub
tteofili commented on code in PR #13288: URL: https://github.com/apache/lucene/pull/13288#discussion_r1562353324 ## lucene/core/src/java/org/apache/lucene/codecs/hnsw/package-info.java: ## @@ -0,0 +1,19 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

Re: [PR] Avoid SegmentTermsEnumFrame reload block. [lucene]

2024-04-12 Thread via GitHub
vsop-479 commented on PR #13253: URL: https://github.com/apache/lucene/pull/13253#issuecomment-2051381459 @mikemccand Please take a look when you get a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Add BitVectors format and make flat vectors format easier to extend [lucene]

2024-04-12 Thread via GitHub
jpountz commented on code in PR #13288: URL: https://github.com/apache/lucene/pull/13288#discussion_r1562108834 ## lucene/core/src/java/org/apache/lucene/codecs/hnsw/FlatBitVectorsScorer.java: ## @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[PR] Converted FieldEntry to record [lucene]

2024-04-12 Thread via GitHub
iamsanjay opened a new pull request, #13296: URL: https://github.com/apache/lucene/pull/13296 Task from #13207 Avoid the usage of compact constructors because the compact constructor can only access the components of record, and most of FieldEntry relies on IndexInput object which