iamsanjay opened a new pull request, #13296: URL: https://github.com/apache/lucene/pull/13296
Task from #13207 Avoid the usage of compact constructors because the compact constructor can only access the components of record, and most of FieldEntry relies on IndexInput object which is not a part of record class. Hence, The purposed code is using the static factory method to create the FieldEntry. However, there is another way where we can make IndexInput a component of the record class and then access it in compact constructor. While it moves the code inside compact constructor, but the code accessing IndexInput has to be surrounded with try-catch as compact constructors cannot throw checked exception. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
