[GitHub] [lucene] shubhamvishu commented on pull request #12183: Make some heavy query rewrites concurrent

shubhamvishu commented on PR #12183: URL: https://github.com/apache/lucene/pull/12183#issuecomment-1463213951 > If there is something that **might** benefit from being made concurrent, it may be `TermStates.build` because it does I/O via terms dictionary lookups. A benefit of making the cha

[GitHub] [lucene] gsmiller commented on pull request #12194: [GITHUB-11915] [Discussion Only] Make Lucene smarter about long runs of matches via new API on DISI

gsmiller commented on PR #12194: URL: https://github.com/apache/lucene/pull/12194#issuecomment-1463206514 Oh and to clarify on my above comment, I’m not trying to create “scope creep” here. In fact, +1 to Adrien’s comment on limiting the scope of the initial PR. Just trying to suggest areas

[GitHub] [lucene] gsmiller commented on a diff in pull request #12194: [GITHUB-11915] [Discussion Only] Make Lucene smarter about long runs of matches via new API on DISI

gsmiller commented on code in PR #12194: URL: https://github.com/apache/lucene/pull/12194#discussion_r1131775078 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90PostingsReader.java: ## @@ -479,6 +481,31 @@ private void refillDocs() throws IOException { a

[GitHub] [lucene] gsmiller commented on pull request #12194: [GITHUB-11915] [Discussion Only] Make Lucene smarter about long runs of matches via new API on DISI

gsmiller commented on PR #12194: URL: https://github.com/apache/lucene/pull/12194#issuecomment-1463006136 Fun! Thanks for picking this up @zacharymorn. What about updating `FixedBitSet#or(disi)` to use this? That's used when rewriting `MultiTermQuery` instances, and I would think we'd see a

[GitHub] [lucene] jpountz commented on pull request #12183: Make some heavy query rewrites concurrent

jpountz commented on PR #12183: URL: https://github.com/apache/lucene/pull/12183#issuecomment-1462869568 If there is something that **might** benefit from being made concurrent, it may be `TermStates.build` because it does I/O via terms dictionary lookups. A benefit of making the change the

[GitHub] [lucene] uschindler merged pull request #12188: Alternative version: Implement MMapDirectory with Java 19/20 Project Panama Preview API

uschindler merged PR #12188: URL: https://github.com/apache/lucene/pull/12188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.

[GitHub] [lucene] stefanvodita commented on a diff in pull request #12184: [nocommit] Introduce ExpressionFacets along with a demo.

stefanvodita commented on code in PR #12184: URL: https://github.com/apache/lucene/pull/12184#discussion_r1131382134 ## lucene/facet/src/java/org/apache/lucene/facet/taxonomy/ExpressionFacets.java: ## @@ -0,0 +1,253 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [lucene] jpountz commented on a diff in pull request #12197: [Backport] GITHUB-11838 Add api to allow concurrent query rewrite

jpountz commented on code in PR #12197: URL: https://github.com/apache/lucene/pull/12197#discussion_r1131214184 ## lucene/core/src/java/org/apache/lucene/search/Query.java: ## @@ -45,6 +46,13 @@ */ public abstract class Query { + static final VirtualMethod oldMethod = +

[GitHub] [lucene] benwtrent opened a new pull request, #12197: [Backport] GITHUB-11838 Add api to allow concurrent query rewrite

benwtrent opened a new pull request, #12197: URL: https://github.com/apache/lucene/pull/12197 Backport of https://github.com/apache/lucene/pull/11840 Changes from original: - Query keeps `rewrite(IndexReader)`, but it is now deprecated - VirtualMethod is used to correct delegat